)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"24c329b1e11f85e23a542ae83502fdc7053e0d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45f13da4_d5f8f041","updated":"2024-01-02 09:15:56.000000000","message":"Done","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a17a537ae1e2dd058b4f22b014bfd588f1f2ef48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"62b9693a_486dad0d","updated":"2024-01-07 14:44:39.000000000","message":"There are few issues linked to the use of libusb.\nThe API of libusb does not return ERROR_OK but LIBUSB_XXX error codes.\nThe functions in the files libusb_helper.c/h return ERROR_OK, but not the original libusb ones.\nPlease fix this patch for the comment I have added, then please review the whole angie driver to fix the other issues with a new patch","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a89180abead1cd718a62e8034875d3a2577a1dae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de19ae74_32ef3810","in_reply_to":"62b9693a_486dad0d","updated":"2024-01-08 09:28:26.000000000","message":"Hello,\ni have reviewed angie driver and i found some functions that doesn\u0027t have an equivalent in libusb_helper.h/.c like for example:\n- (libusb_claim_interface) and (libusb_release_interface)\n- (libusb_strerror)\n- (libusb_get_string_descriptor_ascii)\n\nAll the others have been changed to libusb_helper functions!","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ee2673539337d4e1e19dca5b1006c2acdff8f07e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9484b95d_ec1358d8","updated":"2024-01-11 10:39:46.000000000","message":"Thanks!","commit_id":"b454fe3794cbc0986dad64590aae40ecebd15d4f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d79a0a8cd00354860773a2ba8a6985e680450d85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0c632b88_b1e35474","updated":"2024-01-13 17:28:53.000000000","message":"Ahmed,\nthis patch triggers two issues detected by scan-build:\nhttps://build.openocd.org/job/openocd-clang/1204/clang/new/\n\nCalling angie_quit() in the code causes calling angie_usb_close() that sets\nangie_handle-\u003eusb_device_handle \u003d NULL;\nAfter angie_quit() any tentative to use libusb causes a NULL pointer dereference and then a segmentation fault.\n\nCan you please provide a fix?","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"8d263359ab4f459996bd7856245c70f4df1f234a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"44eaae4d_04de4aa7","in_reply_to":"0c632b88_b1e35474","updated":"2024-01-15 12:58:36.000000000","message":"Yes i will fix it","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"}],"src/jtag/drivers/angie.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8cadb92a16d28b17f704c1a53fd2dafa08130d02","unresolved":true,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"\tusleep(delay_us);"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"\tangie_usb_open(device);"},{"line_number":342,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":343,"context_line":"\t\treturn ret;"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"\treturn libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"67cb5c0a_1823d673","line":342,"range":{"start_line":341,"start_character":1,"end_line":342,"end_character":21},"updated":"2023-12-30 17:56:09.000000000","message":"???\ndid you missed to assign\nret \u003d angie_usb_open(device);\n?","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"24c329b1e11f85e23a542ae83502fdc7053e0d08","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"\tusleep(delay_us);"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"\tangie_usb_open(device);"},{"line_number":342,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":343,"context_line":"\t\treturn ret;"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"\treturn libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9ac400b4_eb21f469","line":342,"range":{"start_line":341,"start_character":1,"end_line":342,"end_character":21},"in_reply_to":"67cb5c0a_1823d673","updated":"2024-01-02 09:15:56.000000000","message":"Ack","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8cadb92a16d28b17f704c1a53fd2dafa08130d02","unresolved":true,"context_lines":[{"line_number":500,"context_line":"\ti2c_data_buffer[0] \u003d 0; // write \u003d 0"},{"line_number":501,"context_line":"\ti2c_data_buffer[1] \u003d i2c_data_size - 1; // i2c_data count (without address)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"\tfor (int i \u003d 0; i \u003c i2c_data_size; i++)"},{"line_number":504,"context_line":"\t\ti2c_data_buffer[i + 2] \u003d i2c_data[i];"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"\t// Send i2c packet to Dev-board and configure its clock source /"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1b229911_6ccb3858","line":503,"updated":"2023-12-30 17:56:09.000000000","message":"some compiler will complain about comparison between signed \"i\" and unsigned \"i2c_data_size\".\nUse unsigned int for \"i\"","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"24c329b1e11f85e23a542ae83502fdc7053e0d08","unresolved":false,"context_lines":[{"line_number":500,"context_line":"\ti2c_data_buffer[0] \u003d 0; // write \u003d 0"},{"line_number":501,"context_line":"\ti2c_data_buffer[1] \u003d i2c_data_size - 1; // i2c_data count (without address)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"\tfor (int i \u003d 0; i \u003c i2c_data_size; i++)"},{"line_number":504,"context_line":"\t\ti2c_data_buffer[i + 2] \u003d i2c_data[i];"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"\t// Send i2c packet to Dev-board and configure its clock source /"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e89b7f1e_286f87a7","line":503,"in_reply_to":"1b229911_6ccb3858","updated":"2024-01-02 09:15:56.000000000","message":"Ack","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8cadb92a16d28b17f704c1a53fd2dafa08130d02","unresolved":true,"context_lines":[{"line_number":530,"context_line":"}"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"/**"},{"line_number":533,"context_line":" * Downloads a bitstream file to the ANGIE\u0027s FPGA through the EZ-USB microcontroller"},{"line_number":534,"context_line":" * over the USB bus."},{"line_number":535,"context_line":" *"},{"line_number":536,"context_line":" * @param device pointer to struct angie identifying ANGIE driver instance."},{"line_number":537,"context_line":" * @param i2c_adr i2c address of the gpio extender."}],"source_content_type":"text/x-csrc","patch_set":2,"id":"18660bff_ad7f58e4","line":534,"range":{"start_line":533,"start_character":3,"end_line":534,"end_character":20},"updated":"2023-12-30 17:56:09.000000000","message":"this same text is copy-paste from the previous function.\nDo they both do the same work?","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"24c329b1e11f85e23a542ae83502fdc7053e0d08","unresolved":false,"context_lines":[{"line_number":530,"context_line":"}"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"/**"},{"line_number":533,"context_line":" * Downloads a bitstream file to the ANGIE\u0027s FPGA through the EZ-USB microcontroller"},{"line_number":534,"context_line":" * over the USB bus."},{"line_number":535,"context_line":" *"},{"line_number":536,"context_line":" * @param device pointer to struct angie identifying ANGIE driver instance."},{"line_number":537,"context_line":" * @param i2c_adr i2c address of the gpio extender."}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2519f164_077b7ea1","line":534,"range":{"start_line":533,"start_character":3,"end_line":534,"end_character":20},"in_reply_to":"18660bff_ad7f58e4","updated":"2024-01-02 09:15:56.000000000","message":"Ack","commit_id":"e19a6cc1d7ab6255a8c801b9eda4a991ba4ba915"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a17a537ae1e2dd058b4f22b014bfd588f1f2ef48","unresolved":true,"context_lines":[{"line_number":343,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":344,"context_line":"\t\treturn ret;"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"\treturn libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":347,"context_line":"}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1ce09233_dfa80baa","line":346,"updated":"2024-01-07 14:44:39.000000000","message":"There is a problem, here, and I see other similar problems in angie driver (but also in other drivers...)\nThis function angie_load_firmware_and_renumerate() is supposed to return ERROR_OK or ERROR_FAIL. But libusb_claim_interface() returns LIBUSB_errors.\nHere it should be:\nret \u003d libusb_claim_interface(...);\nif (ret !\u003d LIBUSB_SUCCESS)\n   return ERROR_FAIL;\nreturn ERROR_OK;","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a89180abead1cd718a62e8034875d3a2577a1dae","unresolved":false,"context_lines":[{"line_number":343,"context_line":"\tif (ret !\u003d ERROR_OK)"},{"line_number":344,"context_line":"\t\treturn ret;"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"\treturn libusb_claim_interface(angie_handle-\u003eusb_device_handle, 0);"},{"line_number":347,"context_line":"}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"cabb6205_757dda66","line":346,"in_reply_to":"1ce09233_dfa80baa","updated":"2024-01-08 09:28:26.000000000","message":"Ack","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a17a537ae1e2dd058b4f22b014bfd588f1f2ef48","unresolved":true,"context_lines":[{"line_number":2262,"context_line":"\t\t\tangie_quit();"},{"line_number":2263,"context_line":"\t\t\treturn ret;"},{"line_number":2264,"context_line":"\t\t}"},{"line_number":2265,"context_line":"\t\tif (libusb_claim_interface(angie_handle-\u003eusb_device_handle, 1) !\u003d ERROR_OK) {"},{"line_number":2266,"context_line":"\t\t\tLOG_ERROR(\"Could not claim interface 1\");"},{"line_number":2267,"context_line":"\t\t\tangie_quit();"},{"line_number":2268,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0a0acb28_ffd7e143","line":2265,"updated":"2024-01-07 14:44:39.000000000","message":"if (libusb_claim_interface(...) !\u003d LIBUSB_SUCCESS) {","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a89180abead1cd718a62e8034875d3a2577a1dae","unresolved":false,"context_lines":[{"line_number":2262,"context_line":"\t\t\tangie_quit();"},{"line_number":2263,"context_line":"\t\t\treturn ret;"},{"line_number":2264,"context_line":"\t\t}"},{"line_number":2265,"context_line":"\t\tif (libusb_claim_interface(angie_handle-\u003eusb_device_handle, 1) !\u003d ERROR_OK) {"},{"line_number":2266,"context_line":"\t\t\tLOG_ERROR(\"Could not claim interface 1\");"},{"line_number":2267,"context_line":"\t\t\tangie_quit();"},{"line_number":2268,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"55d67180_14d65e8a","line":2265,"in_reply_to":"0a0acb28_ffd7e143","updated":"2024-01-08 09:28:26.000000000","message":"Ack","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a17a537ae1e2dd058b4f22b014bfd588f1f2ef48","unresolved":true,"context_lines":[{"line_number":2291,"context_line":"\t\t\tangie_quit();"},{"line_number":2292,"context_line":"\t\t\treturn ret;"},{"line_number":2293,"context_line":"\t\t}"},{"line_number":2294,"context_line":"\t\tif (libusb_release_interface(angie_handle-\u003eusb_device_handle, 1) !\u003d ERROR_OK) {"},{"line_number":2295,"context_line":"\t\t\tLOG_ERROR(\"Fail release interface 1\");"},{"line_number":2296,"context_line":"\t\t\tangie_quit();"},{"line_number":2297,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0b019faf_5af9b624","line":2294,"updated":"2024-01-07 14:44:39.000000000","message":"LIBUSB_SUCCESS","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"a89180abead1cd718a62e8034875d3a2577a1dae","unresolved":false,"context_lines":[{"line_number":2291,"context_line":"\t\t\tangie_quit();"},{"line_number":2292,"context_line":"\t\t\treturn ret;"},{"line_number":2293,"context_line":"\t\t}"},{"line_number":2294,"context_line":"\t\tif (libusb_release_interface(angie_handle-\u003eusb_device_handle, 1) !\u003d ERROR_OK) {"},{"line_number":2295,"context_line":"\t\t\tLOG_ERROR(\"Fail release interface 1\");"},{"line_number":2296,"context_line":"\t\t\tangie_quit();"},{"line_number":2297,"context_line":"\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"9ff8f051_649809db","line":2294,"in_reply_to":"0b019faf_5af9b624","updated":"2024-01-08 09:28:26.000000000","message":"Ack","commit_id":"285faa41648756cf323abaaa17eda1fb934c9e0a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d79a0a8cd00354860773a2ba8a6985e680450d85","unresolved":true,"context_lines":[{"line_number":544,"context_line":"static void angie_io_extender_config(struct angie *device, uint8_t i2c_adr, uint8_t cfg_value, uint8_t value)"},{"line_number":545,"context_line":"{"},{"line_number":546,"context_line":"\tuint8_t ioconfig[3] \u003d {i2c_adr, 3, cfg_value};"},{"line_number":547,"context_line":"\tangie_i2c_write(device, ioconfig, 3);"},{"line_number":548,"context_line":"\tuint8_t iovalue[3] \u003d {i2c_adr, 1, value};"},{"line_number":549,"context_line":"\tangie_i2c_write(device, iovalue, 3);"},{"line_number":550,"context_line":"\tusleep(500);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"ecac0486_3646edd3","line":547,"updated":"2024-01-13 17:28:53.000000000","message":"if this angie_i2c_write() fails, it calls internally angie_quit().\nContinue ...","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"8d263359ab4f459996bd7856245c70f4df1f234a","unresolved":false,"context_lines":[{"line_number":544,"context_line":"static void angie_io_extender_config(struct angie *device, uint8_t i2c_adr, uint8_t cfg_value, uint8_t value)"},{"line_number":545,"context_line":"{"},{"line_number":546,"context_line":"\tuint8_t ioconfig[3] \u003d {i2c_adr, 3, cfg_value};"},{"line_number":547,"context_line":"\tangie_i2c_write(device, ioconfig, 3);"},{"line_number":548,"context_line":"\tuint8_t iovalue[3] \u003d {i2c_adr, 1, value};"},{"line_number":549,"context_line":"\tangie_i2c_write(device, iovalue, 3);"},{"line_number":550,"context_line":"\tusleep(500);"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"86dd64df_3e3fa1de","line":547,"in_reply_to":"ecac0486_3646edd3","updated":"2024-01-15 12:58:36.000000000","message":"Ack","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d79a0a8cd00354860773a2ba8a6985e680450d85","unresolved":true,"context_lines":[{"line_number":546,"context_line":"\tuint8_t ioconfig[3] \u003d {i2c_adr, 3, cfg_value};"},{"line_number":547,"context_line":"\tangie_i2c_write(device, ioconfig, 3);"},{"line_number":548,"context_line":"\tuint8_t iovalue[3] \u003d {i2c_adr, 1, value};"},{"line_number":549,"context_line":"\tangie_i2c_write(device, iovalue, 3);"},{"line_number":550,"context_line":"\tusleep(500);"},{"line_number":551,"context_line":"}"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"ae582b54_f80c406d","line":549,"updated":"2024-01-13 17:28:53.000000000","message":"... continue here.\nWith previous angie_i2c_write() failed, then inside this angie_i2c_write() there will be a segmentation fault as soon as a libusb function is called. As reported by scan-build it would be at line 508.\n\nIf instead is this call to angie_i2c_write() that fails, then the caller of angie_io_extender_config() will experience the segmentation fault. It will be at line 2298, but potentially also at line 508 again.\n\nYou need to check and propagate the error returned by angie_i2c_write()","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"8d263359ab4f459996bd7856245c70f4df1f234a","unresolved":false,"context_lines":[{"line_number":546,"context_line":"\tuint8_t ioconfig[3] \u003d {i2c_adr, 3, cfg_value};"},{"line_number":547,"context_line":"\tangie_i2c_write(device, ioconfig, 3);"},{"line_number":548,"context_line":"\tuint8_t iovalue[3] \u003d {i2c_adr, 1, value};"},{"line_number":549,"context_line":"\tangie_i2c_write(device, iovalue, 3);"},{"line_number":550,"context_line":"\tusleep(500);"},{"line_number":551,"context_line":"}"},{"line_number":552,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":7,"id":"ad30d9a8_4c9c915a","line":549,"in_reply_to":"ae582b54_f80c406d","updated":"2024-01-15 12:58:36.000000000","message":"Ack","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d79a0a8cd00354860773a2ba8a6985e680450d85","unresolved":true,"context_lines":[{"line_number":2271,"context_line":"\t\t\tangie_quit();"},{"line_number":2272,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2273,"context_line":"\t\t}"},{"line_number":2274,"context_line":"\t\tangie_io_extender_config(angie_handle, 0x22, 0xFF, 0xFF);"},{"line_number":2275,"context_line":"\t\tif (ret !\u003d ERROR_OK) {"},{"line_number":2276,"context_line":"\t\t\tLOG_ERROR(\"Could not configure io extender 22\");"},{"line_number":2277,"context_line":"\t\t\tangie_quit();"},{"line_number":2278,"context_line":"\t\t\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c92aa10a_f1757893","line":2275,"range":{"start_line":2274,"start_character":1,"end_line":2275,"end_character":24},"updated":"2024-01-13 17:28:53.000000000","message":"here it\u0027s also my fault. I have not seen that ret is not assigned from the returned value of angie_io_extender_config().\nThis is an error, same in lines 2280, 2286 and 2292","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"},{"author":{"_account_id":1002151,"name":"ahmed BOUDJELIDA","display_name":"Ahmed BOUDJELIDA","email":"aboudjelida@nanoxplore.com","username":"aboudjelida"},"change_message_id":"8d263359ab4f459996bd7856245c70f4df1f234a","unresolved":false,"context_lines":[{"line_number":2271,"context_line":"\t\t\tangie_quit();"},{"line_number":2272,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2273,"context_line":"\t\t}"},{"line_number":2274,"context_line":"\t\tangie_io_extender_config(angie_handle, 0x22, 0xFF, 0xFF);"},{"line_number":2275,"context_line":"\t\tif (ret !\u003d ERROR_OK) {"},{"line_number":2276,"context_line":"\t\t\tLOG_ERROR(\"Could not configure io extender 22\");"},{"line_number":2277,"context_line":"\t\t\tangie_quit();"},{"line_number":2278,"context_line":"\t\t\treturn ret;"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"2ba73784_0e05ce0c","line":2275,"range":{"start_line":2274,"start_character":1,"end_line":2275,"end_character":24},"in_reply_to":"c92aa10a_f1757893","updated":"2024-01-15 12:58:36.000000000","message":"Ack","commit_id":"b50a8dbe4116c4fa18ab066f961f04d2fb075224"}]}