)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"3cfec3446ed1f5b30e6d10f9ab4a348800e1d508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb74394c_73818022","updated":"2024-01-03 00:52:59.000000000","message":"Merge conflict should be resolved once https://review.openocd.org/c/openocd/+/7982 is merged.  Fine to wait to review this until then... or please advise if there\u0027s a better way to avoid this issue.  Thanks.","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"700a0448_ed25c5ea","updated":"2024-01-08 18:41:40.000000000","message":"Thank you for all the clarifications, Antonio, and apologies for not knowing about these subtle but important distinctions.  I will be sure to keep this in mind as I add or update Xtensa commands in the future.","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d22f05e_d4faa744","updated":"2024-01-06 15:51:42.000000000","message":"Thanks for the prompt patch, Ian.\nFew remarks, valid also for future patches:\n- ERROR_COMMAND_SYNTAX_ERROR should be used when the command receives an unexpected amount of parameters. In this case OpenOCD will print the syntax and drop anything already sent through command_print(), so there is no need to print anything before.\n- ERROR_COMMAND_ARGUMENT_INVALID should be used for parameters out of range or with invalid value. In this case it\u0027s welcome, but not mandatory, to suggest the right range.\n- malloc()/calloc()/realloc()/strdup() error signals something dramatic with the heap space. In this case LOG_ERROR(\"const string\") is preferred, but there is no guarantee it will be printed as the OS could suddenly kill OpenOCD.","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"401b829e8e52239bd43da74383219651346eeaef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70c56b69_9c49f8e0","updated":"2024-01-13 18:05:14.000000000","message":"Thanks!","commit_id":"20177a57cb7631e81ffae5c5cbd2724fe015bc52"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3237,"context_line":"\tunsigned int parm_len \u003d strlen(parm);"},{"line_number":3238,"context_line":"\tif ((parm_len \u003e\u003d 64) || (parm_len \u0026 1)) {"},{"line_number":3239,"context_line":"\t\tcommand_print(CMD, \"Invalid parameter length (%d): must be even, \u003c 64 characters\", parm_len);"},{"line_number":3240,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":3241,"context_line":"\t}"},{"line_number":3242,"context_line":""},{"line_number":3243,"context_line":"\tuint8_t ops[32];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5003cd48_3c2699ea","line":3240,"updated":"2024-01-06 15:51:42.000000000","message":"This should be ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3237,"context_line":"\tunsigned int parm_len \u003d strlen(parm);"},{"line_number":3238,"context_line":"\tif ((parm_len \u003e\u003d 64) || (parm_len \u0026 1)) {"},{"line_number":3239,"context_line":"\t\tcommand_print(CMD, \"Invalid parameter length (%d): must be even, \u003c 64 characters\", parm_len);"},{"line_number":3240,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":3241,"context_line":"\t}"},{"line_number":3242,"context_line":""},{"line_number":3243,"context_line":"\tuint8_t ops[32];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1dde968c_b1c10e62","line":3240,"in_reply_to":"5003cd48_3c2699ea","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3312,"context_line":"\t\txtensa-\u003ecore_config-\u003ecore_type \u003d XT_NX;"},{"line_number":3313,"context_line":"\t} else {"},{"line_number":3314,"context_line":"\t\tcommand_print(CMD, \"xtdef [LX|NX]\\n\");"},{"line_number":3315,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3316,"context_line":"\t}"},{"line_number":3317,"context_line":"\treturn ERROR_OK;"},{"line_number":3318,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dac9d9c4_033f86b7","line":3315,"updated":"2024-01-06 15:51:42.000000000","message":"also this should be ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3312,"context_line":"\t\txtensa-\u003ecore_config-\u003ecore_type \u003d XT_NX;"},{"line_number":3313,"context_line":"\t} else {"},{"line_number":3314,"context_line":"\t\tcommand_print(CMD, \"xtdef [LX|NX]\\n\");"},{"line_number":3315,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3316,"context_line":"\t}"},{"line_number":3317,"context_line":"\treturn ERROR_OK;"},{"line_number":3318,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"66ec6f01_e3587395","line":3315,"in_reply_to":"dac9d9c4_033f86b7","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3440,"context_line":"\tbool is_dcache \u003d false;"},{"line_number":3441,"context_line":""},{"line_number":3442,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":3443,"context_line":"\t\tcommand_print(CMD, \"xtmem \u003ctype\u003e [parameters]\\n\");"},{"line_number":3444,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3445,"context_line":"\t}"},{"line_number":3446,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1d3e6259_25de5175","line":3443,"updated":"2024-01-06 15:51:42.000000000","message":"this can be dropped. By returning ERROR_COMMAND_SYNTAX_ERROR OpenOCD will already suggest the command syntax","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3440,"context_line":"\tbool is_dcache \u003d false;"},{"line_number":3441,"context_line":""},{"line_number":3442,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":3443,"context_line":"\t\tcommand_print(CMD, \"xtmem \u003ctype\u003e [parameters]\\n\");"},{"line_number":3444,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3445,"context_line":"\t}"},{"line_number":3446,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"42e53fb2_c166edf5","line":3443,"in_reply_to":"1d3e6259_25de5175","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3479,"context_line":""},{"line_number":3480,"context_line":"\tif (cachep) {"},{"line_number":3481,"context_line":"\t\tif ((CMD_ARGC !\u003d 4) \u0026\u0026 (CMD_ARGC !\u003d 5)) {"},{"line_number":3482,"context_line":"\t\t\tcommand_print(CMD, \"xtmem \u003ccachetype\u003e \u003clinebytes\u003e \u003ccachebytes\u003e \u003cways\u003e [writeback]\\n\");"},{"line_number":3483,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3484,"context_line":"\t\t}"},{"line_number":3485,"context_line":"\t\tcachep-\u003eline_size \u003d strtoul(CMD_ARGV[1], NULL, 0);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d05e0a8e_d258c220","line":3482,"updated":"2024-01-06 15:51:42.000000000","message":"can be dropped too","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3479,"context_line":""},{"line_number":3480,"context_line":"\tif (cachep) {"},{"line_number":3481,"context_line":"\t\tif ((CMD_ARGC !\u003d 4) \u0026\u0026 (CMD_ARGC !\u003d 5)) {"},{"line_number":3482,"context_line":"\t\t\tcommand_print(CMD, \"xtmem \u003ccachetype\u003e \u003clinebytes\u003e \u003ccachebytes\u003e \u003cways\u003e [writeback]\\n\");"},{"line_number":3483,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3484,"context_line":"\t\t}"},{"line_number":3485,"context_line":"\t\tcachep-\u003eline_size \u003d strtoul(CMD_ARGV[1], NULL, 0);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b9417146_b224530f","line":3482,"in_reply_to":"d05e0a8e_d258c220","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3489,"context_line":"\t\t\tstrtoul(CMD_ARGV[4], NULL, 0) : 0;"},{"line_number":3490,"context_line":"\t} else if (memp) {"},{"line_number":3491,"context_line":"\t\tif (CMD_ARGC !\u003d 3) {"},{"line_number":3492,"context_line":"\t\t\tcommand_print(CMD, \"xtmem \u003cmemtype\u003e \u003cbaseaddr\u003e \u003cbytes\u003e\\n\");"},{"line_number":3493,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3494,"context_line":"\t\t}"},{"line_number":3495,"context_line":"\t\tstruct xtensa_local_mem_region_config *memcfgp \u003d \u0026memp-\u003eregions[memp-\u003ecount];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"19a84f66_57b463c2","line":3492,"updated":"2024-01-06 15:51:42.000000000","message":"can be dropped too","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3489,"context_line":"\t\t\tstrtoul(CMD_ARGV[4], NULL, 0) : 0;"},{"line_number":3490,"context_line":"\t} else if (memp) {"},{"line_number":3491,"context_line":"\t\tif (CMD_ARGC !\u003d 3) {"},{"line_number":3492,"context_line":"\t\t\tcommand_print(CMD, \"xtmem \u003cmemtype\u003e \u003cbaseaddr\u003e \u003cbytes\u003e\\n\");"},{"line_number":3493,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3494,"context_line":"\t\t}"},{"line_number":3495,"context_line":"\t\tstruct xtensa_local_mem_region_config *memcfgp \u003d \u0026memp-\u003eregions[memp-\u003ecount];"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"453656c1_cbb4e910","line":3492,"in_reply_to":"19a84f66_57b463c2","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3512,"context_line":"COMMAND_HELPER(xtensa_cmd_xtmpu_do, struct xtensa *xtensa)"},{"line_number":3513,"context_line":"{"},{"line_number":3514,"context_line":"\tif (CMD_ARGC !\u003d 4) {"},{"line_number":3515,"context_line":"\t\tcommand_print(CMD, \"xtmpu \u003cnum FG seg\u003e \u003cmin seg size\u003e \u003clockable\u003e \u003cexecuteonly\u003e\\n\");"},{"line_number":3516,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3517,"context_line":"\t}"},{"line_number":3518,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2acc763b_78878103","line":3515,"updated":"2024-01-06 15:51:42.000000000","message":"can be dropped too","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3512,"context_line":"COMMAND_HELPER(xtensa_cmd_xtmpu_do, struct xtensa *xtensa)"},{"line_number":3513,"context_line":"{"},{"line_number":3514,"context_line":"\tif (CMD_ARGC !\u003d 4) {"},{"line_number":3515,"context_line":"\t\tcommand_print(CMD, \"xtmpu \u003cnum FG seg\u003e \u003cmin seg size\u003e \u003clockable\u003e \u003cexecuteonly\u003e\\n\");"},{"line_number":3516,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3517,"context_line":"\t}"},{"line_number":3518,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"00b41961_efde0937","line":3515,"in_reply_to":"2acc763b_78878103","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3553,"context_line":"COMMAND_HELPER(xtensa_cmd_xtmmu_do, struct xtensa *xtensa)"},{"line_number":3554,"context_line":"{"},{"line_number":3555,"context_line":"\tif (CMD_ARGC !\u003d 2) {"},{"line_number":3556,"context_line":"\t\tcommand_print(CMD, \"xtmmu \u003cNIREFILLENTRIES\u003e \u003cNDREFILLENTRIES\u003e\\n\");"},{"line_number":3557,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3558,"context_line":"\t}"},{"line_number":3559,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8002eb1b_9a712315","line":3556,"updated":"2024-01-06 15:51:42.000000000","message":"can be dropped too","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3553,"context_line":"COMMAND_HELPER(xtensa_cmd_xtmmu_do, struct xtensa *xtensa)"},{"line_number":3554,"context_line":"{"},{"line_number":3555,"context_line":"\tif (CMD_ARGC !\u003d 2) {"},{"line_number":3556,"context_line":"\t\tcommand_print(CMD, \"xtmmu \u003cNIREFILLENTRIES\u003e \u003cNDREFILLENTRIES\u003e\\n\");"},{"line_number":3557,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3558,"context_line":"\t}"},{"line_number":3559,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf1ba510_4adfd33a","line":3556,"in_reply_to":"8002eb1b_9a712315","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3587,"context_line":"\t\tint32_t numregs \u003d strtoul(CMD_ARGV[0], NULL, 0);"},{"line_number":3588,"context_line":"\t\tif ((numregs \u003c\u003d 0) || (numregs \u003e UINT16_MAX)) {"},{"line_number":3589,"context_line":"\t\t\tcommand_print(CMD, \"xtreg \u003cnumregs\u003e: Invalid \u0027numregs\u0027 (%d)\", numregs);"},{"line_number":3590,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3591,"context_line":"\t\t}"},{"line_number":3592,"context_line":"\t\tif ((xtensa-\u003egenpkt_regs_num \u003e 0) \u0026\u0026 (numregs \u003c (int32_t)xtensa-\u003egenpkt_regs_num)) {"},{"line_number":3593,"context_line":"\t\t\tcommand_print(CMD, \"xtregs (%d) must be larger than numgenregs (%d) (if xtregfmt specified)\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b313e500_7fc484e5","line":3590,"updated":"2024-01-06 15:51:42.000000000","message":"this should be ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3587,"context_line":"\t\tint32_t numregs \u003d strtoul(CMD_ARGV[0], NULL, 0);"},{"line_number":3588,"context_line":"\t\tif ((numregs \u003c\u003d 0) || (numregs \u003e UINT16_MAX)) {"},{"line_number":3589,"context_line":"\t\t\tcommand_print(CMD, \"xtreg \u003cnumregs\u003e: Invalid \u0027numregs\u0027 (%d)\", numregs);"},{"line_number":3590,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3591,"context_line":"\t\t}"},{"line_number":3592,"context_line":"\t\tif ((xtensa-\u003egenpkt_regs_num \u003e 0) \u0026\u0026 (numregs \u003c (int32_t)xtensa-\u003egenpkt_regs_num)) {"},{"line_number":3593,"context_line":"\t\t\tcommand_print(CMD, \"xtregs (%d) must be larger than numgenregs (%d) (if xtregfmt specified)\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"991e3348_70489090","line":3590,"in_reply_to":"b313e500_7fc484e5","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3592,"context_line":"\t\tif ((xtensa-\u003egenpkt_regs_num \u003e 0) \u0026\u0026 (numregs \u003c (int32_t)xtensa-\u003egenpkt_regs_num)) {"},{"line_number":3593,"context_line":"\t\t\tcommand_print(CMD, \"xtregs (%d) must be larger than numgenregs (%d) (if xtregfmt specified)\","},{"line_number":3594,"context_line":"\t\t\t\tnumregs, xtensa-\u003egenpkt_regs_num);"},{"line_number":3595,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3596,"context_line":"\t\t}"},{"line_number":3597,"context_line":"\t\txtensa-\u003etotal_regs_num \u003d numregs;"},{"line_number":3598,"context_line":"\t\txtensa-\u003ecore_regs_num \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b4206545_479d2d6b","line":3595,"updated":"2024-01-06 15:51:42.000000000","message":"ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3592,"context_line":"\t\tif ((xtensa-\u003egenpkt_regs_num \u003e 0) \u0026\u0026 (numregs \u003c (int32_t)xtensa-\u003egenpkt_regs_num)) {"},{"line_number":3593,"context_line":"\t\t\tcommand_print(CMD, \"xtregs (%d) must be larger than numgenregs (%d) (if xtregfmt specified)\","},{"line_number":3594,"context_line":"\t\t\t\tnumregs, xtensa-\u003egenpkt_regs_num);"},{"line_number":3595,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3596,"context_line":"\t\t}"},{"line_number":3597,"context_line":"\t\txtensa-\u003etotal_regs_num \u003d numregs;"},{"line_number":3598,"context_line":"\t\txtensa-\u003ecore_regs_num \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"07698c03_95c4b11d","line":3595,"in_reply_to":"b4206545_479d2d6b","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3600,"context_line":"\t\t/* A little more memory than required, but saves a second initialization pass */"},{"line_number":3601,"context_line":"\t\txtensa-\u003eoptregs \u003d calloc(xtensa-\u003etotal_regs_num, sizeof(struct xtensa_reg_desc));"},{"line_number":3602,"context_line":"\t\tif (!xtensa-\u003eoptregs) {"},{"line_number":3603,"context_line":"\t\t\tcommand_print(CMD, \"Failed to allocate xtensa-\u003eoptregs!\");"},{"line_number":3604,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":3605,"context_line":"\t\t}"},{"line_number":3606,"context_line":"\t\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf87fccb_4b857279","line":3603,"updated":"2024-01-06 15:51:42.000000000","message":"This should remain as LOG_ERROR().\nWe are even not sure if we will succeed to print anything after an error from calloc() as OpenOCD could be killed immediately.","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3600,"context_line":"\t\t/* A little more memory than required, but saves a second initialization pass */"},{"line_number":3601,"context_line":"\t\txtensa-\u003eoptregs \u003d calloc(xtensa-\u003etotal_regs_num, sizeof(struct xtensa_reg_desc));"},{"line_number":3602,"context_line":"\t\tif (!xtensa-\u003eoptregs) {"},{"line_number":3603,"context_line":"\t\t\tcommand_print(CMD, \"Failed to allocate xtensa-\u003eoptregs!\");"},{"line_number":3604,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":3605,"context_line":"\t\t}"},{"line_number":3606,"context_line":"\t\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dea5debb_2d265f58","line":3603,"in_reply_to":"bf87fccb_4b857279","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3613,"context_line":"\tif (xtensa-\u003eregmap_contiguous \u0026\u0026 !xtensa-\u003econtiguous_regs_desc) {"},{"line_number":3614,"context_line":"\t\txtensa-\u003econtiguous_regs_desc \u003d calloc(xtensa-\u003etotal_regs_num, sizeof(struct xtensa_reg_desc *));"},{"line_number":3615,"context_line":"\t\tif (!xtensa-\u003econtiguous_regs_desc) {"},{"line_number":3616,"context_line":"\t\t\tcommand_print(CMD, \"Failed to allocate xtensa-\u003econtiguous_regs_desc!\");"},{"line_number":3617,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":3618,"context_line":"\t\t}"},{"line_number":3619,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2c04eea7_1b09c070","line":3616,"updated":"2024-01-06 15:51:42.000000000","message":"same here, keep LOG_ERROR","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3613,"context_line":"\tif (xtensa-\u003eregmap_contiguous \u0026\u0026 !xtensa-\u003econtiguous_regs_desc) {"},{"line_number":3614,"context_line":"\t\txtensa-\u003econtiguous_regs_desc \u003d calloc(xtensa-\u003etotal_regs_num, sizeof(struct xtensa_reg_desc *));"},{"line_number":3615,"context_line":"\t\tif (!xtensa-\u003econtiguous_regs_desc) {"},{"line_number":3616,"context_line":"\t\t\tcommand_print(CMD, \"Failed to allocate xtensa-\u003econtiguous_regs_desc!\");"},{"line_number":3617,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":3618,"context_line":"\t\t}"},{"line_number":3619,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3f1a1580_f4abde42","line":3616,"in_reply_to":"2c04eea7_1b09c070","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9c01bbacb02855c61e6bb5574cbed7f5a05a1a59","unresolved":true,"context_lines":[{"line_number":3760,"context_line":"\t\t\t\t\t(xtensa-\u003etotal_regs_num \u003e 0))) {"},{"line_number":3761,"context_line":"\t\t\t\t\tcommand_print(CMD, \"xtregfmt: if specified, numgregs (%d) must be \u003c\u003d numregs (%d)\","},{"line_number":3762,"context_line":"\t\t\t\t\t\tnumgregs, xtensa-\u003etotal_regs_num);"},{"line_number":3763,"context_line":"\t\t\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3764,"context_line":"\t\t\t\t}"},{"line_number":3765,"context_line":"\t\t\t\txtensa-\u003egenpkt_regs_num \u003d numgregs;"},{"line_number":3766,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5d49be77_d7ffa949","line":3763,"updated":"2024-01-06 15:51:42.000000000","message":"ERROR_COMMAND_ARGUMENT_INVALID","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5f519bc8fa63f8248b7dee2930d1a425b492612c","unresolved":false,"context_lines":[{"line_number":3760,"context_line":"\t\t\t\t\t(xtensa-\u003etotal_regs_num \u003e 0))) {"},{"line_number":3761,"context_line":"\t\t\t\t\tcommand_print(CMD, \"xtregfmt: if specified, numgregs (%d) must be \u003c\u003d numregs (%d)\","},{"line_number":3762,"context_line":"\t\t\t\t\t\tnumgregs, xtensa-\u003etotal_regs_num);"},{"line_number":3763,"context_line":"\t\t\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":3764,"context_line":"\t\t\t\t}"},{"line_number":3765,"context_line":"\t\t\t\txtensa-\u003egenpkt_regs_num \u003d numgregs;"},{"line_number":3766,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"828cca74_fee25dc7","line":3763,"in_reply_to":"5d49be77_d7ffa949","updated":"2024-01-08 18:41:40.000000000","message":"Done","commit_id":"f70ff37c27d397dbbd3aecee4942372f5337fee7"}]}