)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5d3435c8b2b7f72d4e308dce7414d16f45f34c85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"72474468_58397d8a","updated":"2024-01-06 16:03:42.000000000","message":"Minor comments below.","commit_id":"64181d37c899257f6b3c22e18cc4bf5ee56965a1"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"9cb7d89049b3b48d1c128d5f9cce0a4e727f8798","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dad9fa16_4d92557d","updated":"2024-01-03 21:19:47.000000000","message":"Second attempt at review 8077...sorry for the churn.","commit_id":"64181d37c899257f6b3c22e18cc4bf5ee56965a1"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"3d326920b77f6add93f20ff420bfbd8cb9e59383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63ad4eab_8bee49dd","updated":"2024-01-09 15:18:26.000000000","message":"Please see the dependencies on the change 7149, not merged yet.","commit_id":"1c5d7ed1c26e954c3318799b8ef73ece6e470080"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"99579cda12e8effa4a6f3679bedd84b730698665","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0637043c_9d591447","updated":"2024-01-08 18:19:43.000000000","message":"Thanks, Antonio.  Comments addressed.","commit_id":"1c5d7ed1c26e954c3318799b8ef73ece6e470080"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"ffffaa6d04eea510784c8db3103e13e4a1c836ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37e94490_ea142060","updated":"2024-01-16 18:49:34.000000000","message":"hi Ian, as we discussed internally it would be good to have somewhat consistent settings for vdebug driver: The BFM and memory path settings could go to board config, similar to JTAG settings, as they will likely be different for every design.\nAlso the xtensa.cfg could be enhanced to accommodate any number of cores making the other config redundant.","commit_id":"5471fd791690946a4753a07b9ef6ba8630352779"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"e8c4015df8809fe2d7803312b881c112f460be0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"046d296f_a4f50190","in_reply_to":"37e94490_ea142060","updated":"2024-01-19 00:24:41.000000000","message":"Good suggestions, Jacek.  Thanks.  Much cleaner this way.  Rebased and pushed both changes.","commit_id":"5471fd791690946a4753a07b9ef6ba8630352779"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"8ff1760bf12fbc12d0b923d7e4f8a196dc8026df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4fb9955_52e7a6c7","updated":"2024-01-19 15:42:46.000000000","message":"Thank you for the last changes Ian. Looks good to me.","commit_id":"eb29f786cb5560a5b5ee2ede3fdb242f29713133"}],"tcl/target/vd_xtensa_jtag.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5d3435c8b2b7f72d4e308dce7414d16f45f34c85","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Default hooks"},{"line_number":27,"context_line":"$_TARGETNAME configure -event examine-end { vdebug_examine_end }"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1aad4697_193fc49f","line":28,"updated":"2024-01-06 16:03:42.000000000","message":"please remove the extra line at the end of the file.","commit_id":"64181d37c899257f6b3c22e18cc4bf5ee56965a1"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"99579cda12e8effa4a6f3679bedd84b730698665","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Default hooks"},{"line_number":27,"context_line":"$_TARGETNAME configure -event examine-end { vdebug_examine_end }"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"8c11fe6f_b960e7b7","line":28,"in_reply_to":"1aad4697_193fc49f","updated":"2024-01-08 18:19:43.000000000","message":"Done","commit_id":"64181d37c899257f6b3c22e18cc4bf5ee56965a1"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"3d326920b77f6add93f20ff420bfbd8cb9e59383","unresolved":true,"context_lines":[{"line_number":18,"context_line":"# Configure Xtensa core parameters next"},{"line_number":19,"context_line":"# Generate [xtensa-core-XXX.cfg] via \"xt-gdb --dump-oocd-config\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# register target"},{"line_number":22,"context_line":"proc vdebug_examine_end {} {"},{"line_number":23,"context_line":"#    vdebug register_target"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Default hooks"},{"line_number":27,"context_line":"$_TARGETNAME configure -event examine-end { vdebug_examine_end }"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"6daed4bf_38132404","line":27,"range":{"start_line":21,"start_character":0,"end_line":27,"end_character":64},"updated":"2024-01-09 15:18:26.000000000","message":"hi Ian,\nThis functionality is not merged yet. Perhaps it can be removed to avoid dependency.","commit_id":"1c5d7ed1c26e954c3318799b8ef73ece6e470080"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5bc2566a2d9ee942e0db8534f715beecb5c395c6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Configure Xtensa core parameters next"},{"line_number":19,"context_line":"# Generate [xtensa-core-XXX.cfg] via \"xt-gdb --dump-oocd-config\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# register target"},{"line_number":22,"context_line":"proc vdebug_examine_end {} {"},{"line_number":23,"context_line":"#    vdebug register_target"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Default hooks"},{"line_number":27,"context_line":"$_TARGETNAME configure -event examine-end { vdebug_examine_end }"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"135dc2fe_110d265d","line":27,"range":{"start_line":21,"start_character":0,"end_line":27,"end_character":64},"in_reply_to":"6daed4bf_38132404","updated":"2024-01-09 21:20:46.000000000","message":"Yes, thanks for the suggestion, @jacek.  I\u0027ve removed these hooks and confirmed functionality on palladium/vdebug systems.","commit_id":"1c5d7ed1c26e954c3318799b8ef73ece6e470080"}],"tcl/target/vd_xtensa_jtag_dual.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5d3435c8b2b7f72d4e308dce7414d16f45f34c85","unresolved":true,"context_lines":[{"line_number":26,"context_line":"# Default hooks"},{"line_number":27,"context_line":"$_TAPNAME0 configure -event examine-end { vdebug_examine_end }"},{"line_number":28,"context_line":"$_TAPNAME1 configure -event examine-end { vdebug_examine_end }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b811521e_95121cd0","line":29,"updated":"2024-01-06 16:03:42.000000000","message":"also here, drop extra empty line","commit_id":"64181d37c899257f6b3c22e18cc4bf5ee56965a1"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"99579cda12e8effa4a6f3679bedd84b730698665","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Default hooks"},{"line_number":27,"context_line":"$_TAPNAME0 configure -event examine-end { vdebug_examine_end }"},{"line_number":28,"context_line":"$_TAPNAME1 configure -event examine-end { vdebug_examine_end }"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"bb9c210e_ac8ced92","line":29,"in_reply_to":"b811521e_95121cd0","updated":"2024-01-08 18:19:43.000000000","message":"Done","commit_id":"64181d37c899257f6b3c22e18cc4bf5ee56965a1"},{"author":{"_account_id":1001872,"name":"Jacek Wuwer","email":"jacekmw8@gmail.com","username":"jacekmw8"},"change_message_id":"3d326920b77f6add93f20ff420bfbd8cb9e59383","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48edc17b_1017c58c","line":29,"range":{"start_line":21,"start_character":0,"end_line":29,"end_character":0},"updated":"2024-01-09 15:18:26.000000000","message":"hi Ian,\nThis procedure is not yet merged into the mainstream. I think it can be removed for this change","commit_id":"1c5d7ed1c26e954c3318799b8ef73ece6e470080"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"5bc2566a2d9ee942e0db8534f715beecb5c395c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"576ccace_118597db","line":29,"range":{"start_line":21,"start_character":0,"end_line":29,"end_character":0},"in_reply_to":"48edc17b_1017c58c","updated":"2024-01-09 21:20:46.000000000","message":"Done","commit_id":"1c5d7ed1c26e954c3318799b8ef73ece6e470080"}]}