)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"9ea491dfb507660a79538a8acc0d12d609bffdf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"440836d9_9e3e193a","updated":"2024-03-17 22:31:41.000000000","message":"Antonio,\n\nSorry for that.\n\nHere\u0027s the new fix. After fixing ipdbg.c:\n\"scan-build: No bugs found.\"\n\nThanks for your patience!","commit_id":"93aa83f47df5c7b442d54fce0d21059c4d98c190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca809f19b0f71a72e08d71bd636f61edeab47d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d4eaae9_a388f0b0","updated":"2024-03-17 16:03:24.000000000","message":"Thanks for the fix, but now there is a new issue: memory leak!\n\nI think the cleaner solution would be to drop the function ```ipdbg_create_hub()``` that is only called one time, and put it\u0027s content directly inside ```handle_ipdbg_create_hub_command```. There is would be easier to check the alloc/free flow.","commit_id":"93aa83f47df5c7b442d54fce0d21059c4d98c190"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6761ce62b370d2e230830be836cd71584a087389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca5a6771_2198d9ea","updated":"2024-04-18 07:43:10.000000000","message":"Thanks!","commit_id":"ef3fb37ff893fd4ac40d8610ef6c1f08f8ca0e96"}],"src/server/ipdbg.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ca809f19b0f71a72e08d71bd636f61edeab47d27","unresolved":true,"context_lines":[{"line_number":986,"context_line":"{"},{"line_number":987,"context_line":"\tstruct ipdbg_hub *new_hub \u003d ipdbg_allocate_hub(data_register_length, virtual_ir, name);"},{"line_number":988,"context_line":"\tif (!new_hub)"},{"line_number":989,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"\tif (virtual_ir)"},{"line_number":992,"context_line":"\t\tbuf_set_u32(new_hub-\u003escratch_memory.vir_out_val, 0, virtual_ir-\u003elength, virtual_ir-\u003evalue);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ed8df85d_28549e25","line":989,"updated":"2024-03-17 16:03:24.000000000","message":"if you quit here, ```virtual_ir``` never gets free and leaks","commit_id":"93aa83f47df5c7b442d54fce0d21059c4d98c190"},{"author":{"_account_id":1001810,"name":"Daniel Anselmi","email":"danselmi@gmx.ch","username":"danselmi"},"change_message_id":"9ea491dfb507660a79538a8acc0d12d609bffdf1","unresolved":false,"context_lines":[{"line_number":986,"context_line":"{"},{"line_number":987,"context_line":"\tstruct ipdbg_hub *new_hub \u003d ipdbg_allocate_hub(data_register_length, virtual_ir, name);"},{"line_number":988,"context_line":"\tif (!new_hub)"},{"line_number":989,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"\tif (virtual_ir)"},{"line_number":992,"context_line":"\t\tbuf_set_u32(new_hub-\u003escratch_memory.vir_out_val, 0, virtual_ir-\u003elength, virtual_ir-\u003evalue);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6ed2a8e7_0ea225d9","line":989,"in_reply_to":"ed8df85d_28549e25","updated":"2024-03-17 22:31:41.000000000","message":"Done","commit_id":"93aa83f47df5c7b442d54fce0d21059c4d98c190"}]}