)]}'
{"id":"openocd~master~I607cb3aee6529cd5a97bc1200a0226cf6ef43caf","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-01-28 14:18:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I607cb3aee6529cd5a97bc1200a0226cf6ef43caf","subject":"target: get_gdb_arch() accepts target via const pointer","status":"MERGED","created":"2024-01-12 17:14:04.000000000","updated":"2024-01-28 14:18:54.000000000","submitted":"2024-01-28 14:18:54.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8093","meta_rev_id":"573d179e73a143b7008faa290433c8e72b0961fa","_number":8093,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-28 14:18:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-28 14:18:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-28 14:18:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-12 17:57:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-14 16:30:52.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-01-15 13:57:52.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"}],"messages":[{"id":"9acbee7b65a6bab0e9676cdb6c56688495ac8f88","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-01-12 17:14:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c8a165aa57cc0e4645e674e3763675953846754","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-12 17:57:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19226/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18387/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a2e9dabb267878886b50d741e2c49498f442353c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-14 16:30:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"fbe14e70abad57c9667dfb12c61bf1393f04380d","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-01-15 13:57:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0963bd31aa851c653805b16cae4e1e2e6ad526dc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-28 14:18:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"573d179e73a143b7008faa290433c8e72b0961fa","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-28 14:18:54.000000000","message":"Change has been successfully cherry-picked as 1b0ffa97ea90c09e96b068450644e462102c10ae","accounts_in_message":[],"_revision_number":2}],"current_revision":"1b0ffa97ea90c09e96b068450644e462102c10ae","revisions":{"1b0ffa97ea90c09e96b068450644e462102c10ae":{"kind":"REWORK","_number":2,"created":"2024-01-28 14:18:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/93/8093/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/93/8093/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/2 \u0026\u0026 git checkout -b change-8093 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/93/8093/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"67675323e1ea09b5d1a4250bf58163103c85b844","subject":"target: pass target to observers via const pointer"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-01-12 13:29:32.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-01-28 14:18:54.000000000","tz":0},"subject":"target: get_gdb_arch() accepts target via const pointer","message":"target: get_gdb_arch() accepts target via const pointer\n\nThe function in question does not need to change target state. It is a\ntarget-type-dependant function, however, IMHO, it is safe to assume that\nany target type would not need to change type-independant state of a\ntarget to figure out the arch.\n\nChange-Id: I607cb3aee6529cd5a97bc1200a0226cf6ef43caf\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8093\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1d11122e892c7c57f54730ee7e45ad49fcbb32ef":{"kind":"REWORK","_number":1,"created":"2024-01-12 17:14:04.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/93/8093/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/93/8093/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/1 \u0026\u0026 git checkout -b change-8093 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/93/8093/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/93/8093/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d3e17e30136ed23c19d143cdca25a8332822e2df","subject":"target: pass target to observers via const pointer"}],"author":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-01-12 13:29:32.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"evgeniy.naydanov@syntacore.com","date":"2024-01-12 17:12:24.000000000","tz":180},"subject":"target: get_gdb_arch() accepts target via const pointer","message":"target: get_gdb_arch() accepts target via const pointer\n\nThe function in question does not need to change target state. It is a\ntarget-type-dependant function, however, IMHO, it is safe to assume that\nany target type would not need to change type-independant state of a\ntarget to figure out the arch.\n\nChange-Id: I607cb3aee6529cd5a97bc1200a0226cf6ef43caf\nSigned-off-by: Evgeniy Naydanov \u003cevgeniy.naydanov@syntacore.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}