)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ba379c7cab673f3e6a26d2d784ce5d2fa9e8cb98","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"server/gdb-server:fix type error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix flash operation error when addr-width \u003e 32bit on windows."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I199f1cc5128c45bd0bb155e37acb2fb6325dff88"},{"line_number":12,"context_line":"Signed-off-by: wangyanwen \u003cwangyanwen@nucleisys.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffdec779_476a9fbc","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":61},"updated":"2024-01-19 08:09:28.000000000","message":"Not necessarily on windows. 32-bit systems have 4 byte wide long.","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1002226,"name":"Alan-19950616","display_name":"wangyanwen","email":"wangyanwen@nucleisys.com","username":"Alan-19950616"},"change_message_id":"e8fc7d92de41ca29fb4710e9547184266d93575f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"server/gdb-server:fix type error."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix flash operation error when addr-width \u003e 32bit on windows."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I199f1cc5128c45bd0bb155e37acb2fb6325dff88"},{"line_number":12,"context_line":"Signed-off-by: wangyanwen \u003cwangyanwen@nucleisys.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"adf99ed1_9974366a","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":61},"in_reply_to":"ffdec779_476a9fbc","updated":"2024-01-24 06:37:22.000000000","message":"unsigned long type on windowsz(32/64) is defined as 4 bytes\n\nhttps://learn.microsoft.com/en-us/cpp/cpp/data-type-ranges?view\u003dmsvc-170","commit_id":"4910de738945580ecb7db326776e0f569682807d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1002226,"name":"Alan-19950616","display_name":"wangyanwen","email":"wangyanwen@nucleisys.com","username":"Alan-19950616"},"change_message_id":"c60dad2cd8a3a89f2855454cc1706c121c480f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8dc40776_a4e608f7","updated":"2024-02-04 03:21:24.000000000","message":"I had mentioned an ISSUE here that I hope will help you.\n\nhttps://github.com/riscv/riscv-openocd/issues/923","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1002226,"name":"Alan-19950616","display_name":"wangyanwen","email":"wangyanwen@nucleisys.com","username":"Alan-19950616"},"change_message_id":"736816c74e1ef723b07dff5c078dbd158f9b5687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67eded1b_da144188","updated":"2024-02-04 04:10:54.000000000","message":"Thanks\nI will submit an updated patch.","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ba379c7cab673f3e6a26d2d784ce5d2fa9e8cb98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec2baa06_5ec4c3c2","updated":"2024-01-19 08:09:28.000000000","message":"Thanks for the fix!","commit_id":"4910de738945580ecb7db326776e0f569682807d"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"ba379c7cab673f3e6a26d2d784ce5d2fa9e8cb98","unresolved":true,"context_lines":[{"line_number":3287,"context_line":""},{"line_number":3288,"context_line":"\tif (strncmp(packet, \"vFlashErase:\", 12) \u003d\u003d 0) {"},{"line_number":3289,"context_line":"\t\ttarget_addr_t addr;"},{"line_number":3290,"context_line":"\t\ttarget_addr_t length;"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"\t\tchar const *parse \u003d packet + 12;"},{"line_number":3293,"context_line":"\t\tif (*parse \u003d\u003d \u0027\\0\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b2c69d85_3fd2fb2e","line":3290,"range":{"start_line":3290,"start_character":2,"end_line":3290,"end_character":15},"updated":"2024-01-19 08:09:28.000000000","message":"Please do not use target_addr_t for length.\n\nThe real flash devices are fortunately smaller than 4 GBytes, so uint32_t\nwill suffice for some time. Currently, the flash size limit of 32 bit is imposed also by the flash infrastructure and most of flash drivers.","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1002226,"name":"Alan-19950616","display_name":"wangyanwen","email":"wangyanwen@nucleisys.com","username":"Alan-19950616"},"change_message_id":"4feab0d20e69b737137c4b4065eedd3dd51f2457","unresolved":false,"context_lines":[{"line_number":3287,"context_line":""},{"line_number":3288,"context_line":"\tif (strncmp(packet, \"vFlashErase:\", 12) \u003d\u003d 0) {"},{"line_number":3289,"context_line":"\t\ttarget_addr_t addr;"},{"line_number":3290,"context_line":"\t\ttarget_addr_t length;"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"\t\tchar const *parse \u003d packet + 12;"},{"line_number":3293,"context_line":"\t\tif (*parse \u003d\u003d \u0027\\0\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e6588aa3_080d8b5c","line":3290,"range":{"start_line":3290,"start_character":2,"end_line":3290,"end_character":15},"in_reply_to":"2004df3f_367afb61","updated":"2024-02-04 04:12:50.000000000","message":"Thanks\nI will submit an updated patch.","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"9c08fa8d586bb443f0e57416e0abcd3a1fe9c2ce","unresolved":true,"context_lines":[{"line_number":3287,"context_line":""},{"line_number":3288,"context_line":"\tif (strncmp(packet, \"vFlashErase:\", 12) \u003d\u003d 0) {"},{"line_number":3289,"context_line":"\t\ttarget_addr_t addr;"},{"line_number":3290,"context_line":"\t\ttarget_addr_t length;"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"\t\tchar const *parse \u003d packet + 12;"},{"line_number":3293,"context_line":"\t\tif (*parse \u003d\u003d \u0027\\0\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2004df3f_367afb61","line":3290,"range":{"start_line":3290,"start_character":2,"end_line":3290,"end_character":15},"in_reply_to":"a7a83ec2_8988bf25","updated":"2024-02-04 04:02:19.000000000","message":"I agree with extending `addr`\n\nRegarding to `length` I repeat once more\n- there are currently no flash devices bigger than 4 GBytes\n- the flash infrastructure and flash driver uses uint32_t for erase/write block length and it **is enough**\n\nI see no point in using wider type just here and then pass it to uint32_t parameter of flash_erase_address_range() or image_add_section(). It would be just misleading.","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1002226,"name":"Alan-19950616","display_name":"wangyanwen","email":"wangyanwen@nucleisys.com","username":"Alan-19950616"},"change_message_id":"e8fc7d92de41ca29fb4710e9547184266d93575f","unresolved":false,"context_lines":[{"line_number":3287,"context_line":""},{"line_number":3288,"context_line":"\tif (strncmp(packet, \"vFlashErase:\", 12) \u003d\u003d 0) {"},{"line_number":3289,"context_line":"\t\ttarget_addr_t addr;"},{"line_number":3290,"context_line":"\t\ttarget_addr_t length;"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"\t\tchar const *parse \u003d packet + 12;"},{"line_number":3293,"context_line":"\t\tif (*parse \u003d\u003d \u0027\\0\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cd566467_eb5cc78c","line":3290,"range":{"start_line":3290,"start_character":2,"end_line":3290,"end_character":15},"in_reply_to":"b2c69d85_3fd2fb2e","updated":"2024-01-24 06:37:22.000000000","message":"4GBytes is indeed sufficient for Flash devices on the market. It doesn\u0027t make sense that we can\u0027t limit the starting address of Flash to the 4G range.","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"d6ef8ba0eddb68b551c790899bd4e9cccff10f74","unresolved":true,"context_lines":[{"line_number":3287,"context_line":""},{"line_number":3288,"context_line":"\tif (strncmp(packet, \"vFlashErase:\", 12) \u003d\u003d 0) {"},{"line_number":3289,"context_line":"\t\ttarget_addr_t addr;"},{"line_number":3290,"context_line":"\t\ttarget_addr_t length;"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"\t\tchar const *parse \u003d packet + 12;"},{"line_number":3293,"context_line":"\t\tif (*parse \u003d\u003d \u0027\\0\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fda44b65_65f0eca2","line":3290,"range":{"start_line":3290,"start_character":2,"end_line":3290,"end_character":15},"in_reply_to":"cd566467_eb5cc78c","updated":"2024-02-04 03:05:01.000000000","message":"Could you please submit an updated patch?","commit_id":"4910de738945580ecb7db326776e0f569682807d"},{"author":{"_account_id":1002226,"name":"Alan-19950616","display_name":"wangyanwen","email":"wangyanwen@nucleisys.com","username":"Alan-19950616"},"change_message_id":"3b44383b1a555460a8a9a3a752e3591b29e251e4","unresolved":false,"context_lines":[{"line_number":3287,"context_line":""},{"line_number":3288,"context_line":"\tif (strncmp(packet, \"vFlashErase:\", 12) \u003d\u003d 0) {"},{"line_number":3289,"context_line":"\t\ttarget_addr_t addr;"},{"line_number":3290,"context_line":"\t\ttarget_addr_t length;"},{"line_number":3291,"context_line":""},{"line_number":3292,"context_line":"\t\tchar const *parse \u003d packet + 12;"},{"line_number":3293,"context_line":"\t\tif (*parse \u003d\u003d \u0027\\0\u0027) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a7a83ec2_8988bf25","line":3290,"range":{"start_line":3290,"start_character":2,"end_line":3290,"end_character":15},"in_reply_to":"fda44b65_65f0eca2","updated":"2024-02-04 03:14:58.000000000","message":"The uint32_t is not enough, when the start address of the flash is bigger than 32bit, even though the flash capacity is not more than 4G. so I think target_addr_t is more appropriate.","commit_id":"4910de738945580ecb7db326776e0f569682807d"}]}