)]}'
{"id":"openocd~master~I0da05b87f43c3d0facb78e54d8f00c1728fe7c46","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-02-11 23:02:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0da05b87f43c3d0facb78e54d8f00c1728fe7c46","subject":"target/cortex_m: drop useless target_halt() call","status":"MERGED","created":"2024-01-21 11:31:13.000000000","updated":"2025-06-14 11:42:12.000000000","submitted":"2024-02-11 23:02:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8098","meta_rev_id":"057319c566c66e66f6a5fd7b8388f9d57425e6a6","_number":8098,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-11 23:02:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-11 23:02:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-21 11:47:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-22 09:53:05.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2025-06-14 09:31:01.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"CC"}],"messages":[{"id":"7a972677f3a7ce6c57b2173e1584a14541fb3d3c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-01-21 11:31:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9dfe5f2c5b82e9c093cebd7d88918e5f8a4e9e2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-21 11:47:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19244/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18405/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"012b1b2d14ee9d773783fa9cfef74251d0c80e9f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-01-22 09:53:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8af72ea66a90f0061a804fb0d4d9191c7e07a2fa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-11 23:02:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"554b66f7ce4c8130bfcb5cd88c3cc2ffbae4901a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-11 23:02:29.000000000","message":"Change has been successfully cherry-picked as 226085065bdfdfd44bfadbfb2973971ff154eb22","accounts_in_message":[],"_revision_number":2},{"id":"7d3c873d8f40c880233070219d4d176e30d7fc54","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-06-14 09:31:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f4bbbf7548c0ebf8810cdf38c2f40f97dc32e97e","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2025-06-14 10:34:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"057319c566c66e66f6a5fd7b8388f9d57425e6a6","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2025-06-14 11:42:12.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"226085065bdfdfd44bfadbfb2973971ff154eb22","revisions":{"c0cb3d306a896ec8363194839935398ce6ba40dc":{"kind":"REWORK","_number":1,"created":"2024-01-21 11:31:13.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/98/8098/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/8098/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/1 \u0026\u0026 git checkout -b change-8098 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/8098/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e51bd964ee4c0db543a479bb4c5c557e4a0df563","subject":"target/cortex_m: prevent asserting reset if examine is deferred"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-21 11:05:35.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-21 11:20:01.000000000","tz":60},"subject":"target/cortex_m: drop useless target_halt() call","message":"target/cortex_m: drop useless target_halt() call\n\nIn 2008 the commit 182936125371 (\"define resetting\nthe target into the halted or running state as an atomic operation.\")\nintroduced the target_halt() call to the end of cortex_m3_assert_reset(),\n\nCheckpatch-ignore: GIT_COMMIT_ID\n\nA year later the commit ed36a8d15dfd\n(\"... Updated halt handling for cortex_m3\")\nprevented cortex_m3_halt() take any action in case of TARGET_RESET state.\nThis narrowed the target_halt() called from cortex_m3_assert_reset()\nto setting target-\u003ehalt_issued and storing a time stamp.\n\nIntroducing ocd_process_reset(_inner) made the setting of halt_issued\nand halt_issued_time useless. The Tcl function waits for halt\nof all targets if applicable.\n\ncortex_m_halt() and also target_halt() does not work as expected\nif the cached target state is TARGET_RESET (although the core could\nbe out of reset and ready to be halted, just have not been polled).\nExplicit Tcl arp_poll must be issued in many scenarios.\n\nRemove the useless hack.\n\nAlso remove the explicit error return from cortex_m_halt_one()\nin case of RESET_SRST_PULLS_TRST and asserted srst. If the communication\nwith the target is gated by any reset, cortex_m_write_debug_halt_mask()\nfails. Propagate the error return of this call instead.\n\nChange-Id: I0da05b87f43c3d0facb78e54d8f00c1728fe7c46\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"226085065bdfdfd44bfadbfb2973971ff154eb22":{"kind":"REWORK","_number":2,"created":"2024-02-11 23:02:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/98/8098/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/8098/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/2 \u0026\u0026 git checkout -b change-8098 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/8098/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/8098/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"38616990744b2bac7026f0d41da9247b42494379","subject":"target/cortex_m: prevent asserting reset if examine is deferred"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-21 11:05:35.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-11 23:02:29.000000000","tz":0},"subject":"target/cortex_m: drop useless target_halt() call","message":"target/cortex_m: drop useless target_halt() call\n\nIn 2008 the commit 182936125371 (\"define resetting\nthe target into the halted or running state as an atomic operation.\")\nintroduced the target_halt() call to the end of cortex_m3_assert_reset(),\n\nCheckpatch-ignore: GIT_COMMIT_ID\n\nA year later the commit ed36a8d15dfd\n(\"... Updated halt handling for cortex_m3\")\nprevented cortex_m3_halt() take any action in case of TARGET_RESET state.\nThis narrowed the target_halt() called from cortex_m3_assert_reset()\nto setting target-\u003ehalt_issued and storing a time stamp.\n\nIntroducing ocd_process_reset(_inner) made the setting of halt_issued\nand halt_issued_time useless. The Tcl function waits for halt\nof all targets if applicable.\n\ncortex_m_halt() and also target_halt() does not work as expected\nif the cached target state is TARGET_RESET (although the core could\nbe out of reset and ready to be halted, just have not been polled).\nExplicit Tcl arp_poll must be issued in many scenarios.\n\nRemove the useless hack.\n\nAlso remove the explicit error return from cortex_m_halt_one()\nin case of RESET_SRST_PULLS_TRST and asserted srst. If the communication\nwith the target is gated by any reset, cortex_m_write_debug_halt_mask()\nfails. Propagate the error return of this call instead.\n\nChange-Id: I0da05b87f43c3d0facb78e54d8f00c1728fe7c46\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8098\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}