)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f1a73eb678dac9f717719741bf06c893a5facce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb38ce19_516e04ba","updated":"2024-01-22 09:23:42.000000000","message":"Thanks for the patch.\n\nIn COMMAND_HANDLER() functions we try to avoid LOG_XX() and if the function has to produce some output we use command_print().\nIn this case we can use only ERROR_COMMAND_SYNTAX_ERROR to force openocd to dump the command syntax in case of incorrect number of parameters.\n\nApart from the point above, adding the new command is ok, but you need to document it.","commit_id":"4ea322005f1e52dc38d2776560e50bbdb96c4259"},{"author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"change_message_id":"de24c4c9a10662485877f18d78e9db4546e9946c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d634ee7c_818dcdcb","in_reply_to":"bb38ce19_516e04ba","updated":"2024-01-22 23:30:04.000000000","message":"Hi Antonio, as I see from most of the patches, newcomers make the same fixes and you are spending time explaining to everyone. You did a clear summary here. https://review.openocd.org/c/openocd/+/8076/comments/7d22f05e_d4faa744\n\nCan we consider to create a new file like \"dev-guide.txt\" to consolidate frequently needed information for newcomers and the patches.","commit_id":"4ea322005f1e52dc38d2776560e50bbdb96c4259"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3a5025247c2de865bd0cdca73f43d98cec34133a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a9a58263_a3784f2c","updated":"2024-01-23 14:28:59.000000000","message":"Thanks!","commit_id":"a386268bef19e62c0448420f58b0c54991347974"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f1a73eb678dac9f717719741bf06c893a5facce","unresolved":true,"context_lines":[{"line_number":3441,"context_line":"@end itemize"},{"line_number":3442,"context_line":"@end deffn"},{"line_number":3443,"context_line":""},{"line_number":3444,"context_line":"@deffn {Config Command} {openjtag device_desc} string"},{"line_number":3445,"context_line":"The USB device description string of the adapter."},{"line_number":3446,"context_line":"This value is only used with the standard variant."},{"line_number":3447,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"6d99fcdd_08b7c78b","line":3444,"updated":"2024-01-22 09:23:42.000000000","message":"You need to add the new command \"openjtag vid_pid\"","commit_id":"4ea322005f1e52dc38d2776560e50bbdb96c4259"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3a5025247c2de865bd0cdca73f43d98cec34133a","unresolved":false,"context_lines":[{"line_number":3441,"context_line":"@end itemize"},{"line_number":3442,"context_line":"@end deffn"},{"line_number":3443,"context_line":""},{"line_number":3444,"context_line":"@deffn {Config Command} {openjtag device_desc} string"},{"line_number":3445,"context_line":"The USB device description string of the adapter."},{"line_number":3446,"context_line":"This value is only used with the standard variant."},{"line_number":3447,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"24790946_76fb12d7","line":3444,"in_reply_to":"6d99fcdd_08b7c78b","updated":"2024-01-23 14:28:59.000000000","message":"Done","commit_id":"4ea322005f1e52dc38d2776560e50bbdb96c4259"}],"src/jtag/drivers/openjtag.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9f1a73eb678dac9f717719741bf06c893a5facce","unresolved":true,"context_lines":[{"line_number":863,"context_line":""},{"line_number":864,"context_line":"COMMAND_HANDLER(openjtag_handle_vid_pid_command)"},{"line_number":865,"context_line":"{"},{"line_number":866,"context_line":"\tif (CMD_ARGC \u003e 2) {"},{"line_number":867,"context_line":"\t\tLOG_WARNING(\"ignoring extra IDs in openjtag_vid_pid \""},{"line_number":868,"context_line":"\t\t\t\t\t\"(maximum is 1 pair)\");"},{"line_number":869,"context_line":"\t\tCMD_ARGC \u003d 2;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4f8344a0_c891c8fc","line":866,"updated":"2024-01-22 09:23:42.000000000","message":"please simplify the whole function as:\nif (CMD_ARGC !\u003d 2)\nreturn ERROR_COMMAND_SYNTAX_ERROR;\nCOMMAND_PARSE_NUMBER(u16, CMD_ARGV[0], openjtag_vid);\nCOMMAND_PARSE_NUMBER(u16, CMD_ARGV[1], openjtag_pid);\nreturn ERROR_OK;","commit_id":"4ea322005f1e52dc38d2776560e50bbdb96c4259"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3a5025247c2de865bd0cdca73f43d98cec34133a","unresolved":false,"context_lines":[{"line_number":863,"context_line":""},{"line_number":864,"context_line":"COMMAND_HANDLER(openjtag_handle_vid_pid_command)"},{"line_number":865,"context_line":"{"},{"line_number":866,"context_line":"\tif (CMD_ARGC \u003e 2) {"},{"line_number":867,"context_line":"\t\tLOG_WARNING(\"ignoring extra IDs in openjtag_vid_pid \""},{"line_number":868,"context_line":"\t\t\t\t\t\"(maximum is 1 pair)\");"},{"line_number":869,"context_line":"\t\tCMD_ARGC \u003d 2;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c3590849_6cef6ae1","line":866,"in_reply_to":"4f8344a0_c891c8fc","updated":"2024-01-23 14:28:59.000000000","message":"Done","commit_id":"4ea322005f1e52dc38d2776560e50bbdb96c4259"}]}