)]}'
{"id":"openocd~master~I63faf38dad79440a0117ed79930442bd2843c6db","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-05-27 16:33:23.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I63faf38dad79440a0117ed79930442bd2843c6db","subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase","status":"MERGED","created":"2024-01-25 08:35:20.000000000","updated":"2024-06-08 09:20:14.000000000","submitted":"2024-06-08 09:20:14.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8115","meta_rev_id":"736a85e4dae2cecd978ab2b3fc2f7e77f7526114","_number":8115,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 09:20:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 09:20:14.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-08 09:20:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 09:20:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-25 11:15:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-08 23:09:34.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-02-11 14:17:36.000000000","updated_by":{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"},"reviewer":{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"},"state":"REVIEWER"}],"messages":[{"id":"ed8287ba88aa2c8913dafb4bc48d72eceaaaa6e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-01-25 08:35:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"32b6c8e361ff3027d1931f4f63c4d5d8548823e4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-25 11:15:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/18433/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/19271/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8cc8eded96b131f3d0ce196cf5ad7f5c83b3c953","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-01-25 21:22:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"337ef7936c4d048f5415950c2a3b79c383b5d2fa","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-25 22:02:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19277/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18438/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ff58d29b27b577ced516c9a74d812e968d9554cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-01-29 17:04:35.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e90313ab25859656cd7ee2fb8a26377592330f88","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-29 17:44:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19289/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18452/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"5e2c13a35235074923ce12f64f56ea232c15f7f7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-08 23:09:34.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e8aff2c692ffaba4062160e3f70036e1348d2f46","author":{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"},"real_author":{"_account_id":1002220,"name":"Tomáš Beneš","email":"tomas@dronetag.cz","username":"optical-o"},"date":"2024-02-11 14:17:36.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"73eabd73243377c2a09cd998946ceb8de869c2b3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-05-27 16:33:23.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"736a85e4dae2cecd978ab2b3fc2f7e77f7526114","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-08 09:20:14.000000000","message":"Change has been successfully cherry-picked as e4c0904731320c686e5074e68db8358e2f3ce83d","accounts_in_message":[],"_revision_number":4}],"current_revision":"e4c0904731320c686e5074e68db8358e2f3ce83d","revisions":{"1a3e07d7d95ce2bcf854722fffeb12f6e3d0603f":{"kind":"REWORK","_number":1,"created":"2024-01-25 08:35:20.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/8115/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8115/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/1 \u0026\u0026 git checkout -b change-8115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8115/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8782530f3062e996964b30abbcc38296b58a13cb","subject":"flash/nor/nrf5: show proper SoC type on newer nRF91 devices"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-22 20:09:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-25 08:32:36.000000000","tz":60},"subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF53/91 flash erase","message":"flash/nor/nrf5: handle ERROR_WAIT during nRF53/91 flash erase\n\nErase is initiated by write to a flash address. The write stalls\nthe bus until the page erase is finished (takes up to 87ms).\nIf the adapter does not handle SWD WAIT properly, the following read\nin nrf5_wait_for_nvmc() returns ERROR_WAIT.\n\nWait for fixed time before accessing AP. Not nice, but the only\nworking solution until all adapters handle SWD WAIT.\nIf the fixed wait did not suffice, continue the wait loop after a delay.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I63faf38dad79440a0117ed79930442bd2843c6db\n"}},"d68f82ab98dab6aec4025bf7c354cabee7345357":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-01-25 21:22:56.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/8115/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8115/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/2 \u0026\u0026 git checkout -b change-8115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8115/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bd464203c024dc69ae871d015561fce0226f3f9b","subject":"flash/nor/nrf5: show proper SoC type on newer nRF91 devices"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-22 20:09:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-25 21:22:35.000000000","tz":60},"subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF53/91 flash erase","message":"flash/nor/nrf5: handle ERROR_WAIT during nRF53/91 flash erase\n\nErase is initiated by write to a flash address. The write stalls\nthe bus until the page erase is finished (takes up to 87ms).\nIf the adapter does not handle SWD WAIT properly, the following read\nin nrf5_wait_for_nvmc() returns ERROR_WAIT.\n\nWait for fixed time before accessing AP. Not nice, but the only\nworking solution until all adapters handle SWD WAIT.\nIf the fixed wait did not suffice, continue the wait loop after a delay.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I63faf38dad79440a0117ed79930442bd2843c6db\n"}},"9a8704eeba2cce7ccc2844b56c06a3b86cf33185":{"kind":"REWORK","_number":3,"created":"2024-01-29 17:04:35.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/8115/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8115/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/3 \u0026\u0026 git checkout -b change-8115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8115/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae24a20c9c4e0b2955323f75fd84671aef1a7c41","subject":"flash/nor/nrf5: show proper SoC type on newer nRF91 devices"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-22 20:09:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-29 17:00:29.000000000","tz":60},"subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase","message":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase\n\nErase is initiated by write to a flash address. Due to the\nsilicon errata of nRF91 the write stalls the bus until the page erase\nis finished (takes up to 87ms).\nIf the adapter does not handle SWD WAIT properly, the following read\nin nrf5_wait_for_nvmc() returns ERROR_WAIT.\n\nWait for fixed time before accessing AP. Not nice, but the only\nworking solution until all adapters handle SWD WAIT.\n\nIf the fixed wait does not suffice, continue the wait loop after a delay.\nIt makes some unnecessary noise however erase works.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I63faf38dad79440a0117ed79930442bd2843c6db\n"}},"e4c0904731320c686e5074e68db8358e2f3ce83d":{"kind":"REWORK","_number":4,"created":"2024-06-08 09:20:14.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/15/8115/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8115/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/4 \u0026\u0026 git checkout -b change-8115 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8115/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8115/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"70b362d4f47194eced99b448cc99b093641d1465","subject":"flash/nor/nrf5: show proper SoC type on newer nRF91 devices"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-01-22 20:09:31.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-06-08 09:20:14.000000000","tz":0},"subject":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase","message":"flash/nor/nrf5: handle ERROR_WAIT during nRF91 flash erase\n\nErase is initiated by write to a flash address. Due to the\nsilicon errata of nRF91 the write stalls the bus until the page erase\nis finished (takes up to 87ms).\nIf the adapter does not handle SWD WAIT properly, the following read\nin nrf5_wait_for_nvmc() returns ERROR_WAIT.\n\nWait for fixed time before accessing AP. Not nice, but the only\nworking solution until all adapters handle SWD WAIT.\n\nIf the fixed wait does not suffice, continue the wait loop after a delay.\nIt makes some unnecessary noise however erase works.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I63faf38dad79440a0117ed79930442bd2843c6db\nReviewed-on: https://review.openocd.org/c/openocd/+/8115\nReviewed-by: Tomáš Beneš \u003ctomas@dronetag.cz\u003e\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}