)]}'
{"src/target/arc.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[{"line_number":795,"context_line":"\t\t\tcurr-\u003esmp \u003d 0;"},{"line_number":796,"context_line":"\t\t\tret \u003d arc_halt(curr);"},{"line_number":797,"context_line":"\t\t\tif (ret !\u003d ERROR_OK) {"},{"line_number":798,"context_line":"\t\t\t\tLOG_ERROR(\"smp halt failed coreid: %\" PRId32 \" error code: %d\","},{"line_number":799,"context_line":"\t\t\t\t\t\tcurr-\u003ecoreid, ret);"},{"line_number":800,"context_line":"\t\t\t\tretval \u003d ret;"},{"line_number":801,"context_line":"\t\t\t}"},{"line_number":802,"context_line":"\t\t\tcurr-\u003esmp \u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"eda47851_b694c786","line":799,"range":{"start_line":798,"start_character":6,"end_line":799,"end_character":25},"updated":"2024-02-12 23:42:07.000000000","message":"Don\u0027t use ```coreid``` in the error message, as it is not really useful.\nUse instead the target name, e.g.\nLOG_TARGET_ERROR(curr, \"smp halt failed. Error code: %d\", ret);","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[{"line_number":1081,"context_line":"\t\t\tcurr-\u003esmp \u003d 0;"},{"line_number":1082,"context_line":"\t\t\tret \u003d arc_poll(curr);"},{"line_number":1083,"context_line":"\t\t\tif (ret !\u003d ERROR_OK) {"},{"line_number":1084,"context_line":"\t\t\t\tLOG_ERROR(\"smp poll failed coreid: %\" PRId32 \" error code: %d\","},{"line_number":1085,"context_line":"\t\t\t\t\t\tcurr-\u003ecoreid, ret);"},{"line_number":1086,"context_line":"\t\t\t\tretval \u003d ret;"},{"line_number":1087,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"49d4d6ec_9ca482e0","line":1084,"updated":"2024-02-12 23:42:07.000000000","message":"same here, use target name in place  of coreid","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[{"line_number":1346,"context_line":"\t\t\tcurr-\u003esmp \u003d 0;"},{"line_number":1347,"context_line":"\t\t\tret \u003d arc_resume(curr, current, address, handle_breakpoints, debug_execution);"},{"line_number":1348,"context_line":"\t\t\tif (ret !\u003d ERROR_OK) {"},{"line_number":1349,"context_line":"\t\t\t\tLOG_ERROR(\"smp resume failed coreid: %\" PRId32 \" error code: %d\","},{"line_number":1350,"context_line":"\t\t\t\t\t\tcurr-\u003ecoreid, ret);"},{"line_number":1351,"context_line":"\t\t\t\tretval \u003d ret;"},{"line_number":1352,"context_line":"\t\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b9c32950_c79b98e7","line":1349,"updated":"2024-02-12 23:42:07.000000000","message":"same here","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[{"line_number":1350,"context_line":"\t\t\t\t\t\tcurr-\u003ecoreid, ret);"},{"line_number":1351,"context_line":"\t\t\t\tretval \u003d ret;"},{"line_number":1352,"context_line":"\t\t\t}"},{"line_number":1353,"context_line":"\t\t\tcurr-\u003esmp \u003d 1;"},{"line_number":1354,"context_line":"\t\t}"},{"line_number":1355,"context_line":"\t}"},{"line_number":1356,"context_line":"\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"637e61bc_0893c5a2","line":1353,"updated":"2024-02-12 23:42:07.000000000","message":"Humm, this breaks the purpose of https://review.openocd.org/6979 !!!\nAnd I see the same done in:\nsrc/target/aarch64.c\nsrc/target/espressif/esp_xtensa_smp.c\nsrc/target/cortex_a.c\nplus it is broken from src/target/smp.c too!\n\nThis is more a reminder to me that there is something visibly broken.\nKeep it in your code, it should be addressed globally out of this patch.","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[{"line_number":1439,"context_line":"\tCHECK_RETVAL(arc_jtag_read_aux_reg_one(\u0026arc-\u003ejtag_info, AUX_STATUS32_REG, \u0026value));"},{"line_number":1440,"context_line":"\tvalue \u0026\u003d ~SET_CORE_HALT_BIT;        /* clear the HALT bit */"},{"line_number":1441,"context_line":"\tCHECK_RETVAL(arc_jtag_write_aux_reg_one(\u0026arc-\u003ejtag_info, AUX_STATUS32_REG, value));"},{"line_number":1442,"context_line":"\tLOG_DEBUG(\"Core %s started to run\", target_name(target));"},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"\t/* registers are now invalid */"},{"line_number":1445,"context_line":"\tregister_cache_invalidate(arc-\u003ecore_and_aux_cache);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"350c8062_7b29f9cc","line":1442,"updated":"2024-02-12 23:42:07.000000000","message":"use\nLOG_TARGET_DEBUG(target, \"Core started to run\");","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"}],"tcl/board/snps_hsdk_smp.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34a963bc_da911fb6","line":26,"updated":"2024-02-12 23:42:07.000000000","message":"please remove the empty line at the end of the file","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"}],"tcl/target/snps_hsdk_smp.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"489cb88951342f21cba5916620dfba6aa6592e82","unresolved":true,"context_lines":[{"line_number":34,"context_line":"\tjtag newtap $_CHIPNAME cpu$core_index -irlen 4 -ircapture 0x1 -expected-id $expected_id"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\ttarget create $_TARGETNAME arcv2 -chain-position $_TARGETNAME"},{"line_number":37,"context_line":"\t$_TARGETNAME configure -coreid $_coreid"},{"line_number":38,"context_line":"\t$_TARGETNAME configure -dbgbase $_dbgbase"},{"line_number":39,"context_line":"\t# Flush L2$."},{"line_number":40,"context_line":"\t$_TARGETNAME configure -event reset-assert \"arc_hs_reset $_TARGETNAME\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2cf2b588_b6fa01b5","line":37,"updated":"2024-02-12 23:42:07.000000000","message":"Just a question, no need for any code change.\nWe are re-discussing what ```-coreid``` means in ```target create``` and ```targetname configure```. Please see comments in:\nhttps://review.openocd.org/c/openocd/+/7957\nhttps://review.openocd.org/c/openocd/+/8129\n\nI don\u0027t see the the value ```coreid``` being used in arc target nor in this patch (apart from the LOG already commented). So I don\u0027t see any impact when the SMP index would be changed from ```coreid``` to the core position in the command ```smp create```.\nDo you see any issue?","commit_id":"8ff251367be11e3399cc5334edbbe4a1da6fdbc5"}]}