)]}'
{"id":"openocd~master~I7e0f76f8491efefff1ccaeb4b1ae16e722d76df4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002105":{"account":{"_account_id":1002105,"name":"N S","email":"nlshipp@yahoo.com","username":"nlshipp"},"last_update":"2024-02-11 23:11:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7e0f76f8491efefff1ccaeb4b1ae16e722d76df4","subject":"jtag/drivers: fix reset logic handling in OpenJTAG","status":"MERGED","created":"2024-01-28 04:31:04.000000000","updated":"2024-02-11 23:11:00.000000000","submitted":"2024-02-11 23:11:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8121","meta_rev_id":"bfa8e331e95f5a263aca89499f2deb2df38cfcf1","_number":8121,"owner":{"_account_id":1002105,"name":"N S","email":"nlshipp@yahoo.com","username":"nlshipp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-11 23:11:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-11 23:11:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-28 04:44:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-03 12:49:10.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d5fa17633c764e127db971e87e57f2d1fae869fd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002105,"name":"N S","email":"nlshipp@yahoo.com","username":"nlshipp"},"real_author":{"_account_id":1002105,"name":"N S","email":"nlshipp@yahoo.com","username":"nlshipp"},"date":"2024-01-28 04:31:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f59db9098b91e0ce48562fa48d46c6525260b0bb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-01-28 04:44:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19285/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18446/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"818534a8b31fb6cf816184370f2bee8e21748482","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-03 12:49:10.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4b792c9a7e124869b7f12911c0ba154109b63fd0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-11 23:10:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bfa8e331e95f5a263aca89499f2deb2df38cfcf1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-11 23:11:00.000000000","message":"Change has been successfully cherry-picked as c6e7e48b053c281ef4a9dd50f2d94fa12184a956","accounts_in_message":[],"_revision_number":2}],"current_revision":"c6e7e48b053c281ef4a9dd50f2d94fa12184a956","revisions":{"c6e7e48b053c281ef4a9dd50f2d94fa12184a956":{"kind":"REWORK","_number":2,"created":"2024-02-11 23:11:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/21/8121/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/8121/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/2 \u0026\u0026 git checkout -b change-8121 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/8121/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7295ddc15c0516a64c9996d2b351accb50175803","subject":"jtag/drivers: OpenJTAG standard variant perf improvement"}],"author":{"name":"N S","email":"nlshipp@yahoo.com","date":"2024-01-23 05:47:34.000000000","tz":-480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-11 23:11:00.000000000","tz":0},"subject":"jtag/drivers: fix reset logic handling in OpenJTAG","message":"jtag/drivers: fix reset logic handling in OpenJTAG\n\nThe OpenJTAG driver behaviour always forces a system reset on jtag_init.\nThe driver was incorrectly assuming that when execute_reset is called\nwith trst set to 1 - perform a software TAP reset, otherwise perform a\nsystem reset when trst is 0.\n\nThe set_state call assumes the that OpenJTAG hardware will perform a\nsoftware TLR reset if the target state is TAP_RESET. This is not the\ncase: the published VHDL will simply find the shortest path to TLR and\nnot perform a fixed 5 cycle operation with TMS held high.\n\nFix the code to only perform system resets when srst is 1 in\nexecute_reset and to force a software TAP reset operation in set_state\nwhen the target state is TAP_RESET.\n\nChange-Id: I7e0f76f8491efefff1ccaeb4b1ae16e722d76df4\nSigned-off-by: N S \u003cnlshipp@yahoo.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8121\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"4545cc2cdbd6bf201eee0ccc1496434dffe19cea":{"kind":"REWORK","_number":1,"created":"2024-01-28 04:31:04.000000000","uploader":{"_account_id":1002105,"name":"N S","email":"nlshipp@yahoo.com","username":"nlshipp"},"ref":"refs/changes/21/8121/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/8121/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/1 \u0026\u0026 git checkout -b change-8121 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/8121/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/8121/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"151b743714382120dbe0dee0e0eeb75826ef5b3a","subject":"jtag/vdebug: add support for DAP6"}],"author":{"name":"N S","email":"nlshipp@yahoo.com","date":"2024-01-23 05:47:34.000000000","tz":-480},"committer":{"name":"N S","email":"nlshipp@yahoo.com","date":"2024-01-27 19:33:46.000000000","tz":-480},"subject":"jtag/drivers: fix reset logic handling in OpenJTAG","message":"jtag/drivers: fix reset logic handling in OpenJTAG\n\nThe OpenJTAG driver behaviour always forces a system reset on jtag_init.\nThe driver was incorrectly assuming that when execute_reset is called\nwith trst set to 1 - perform a software TAP reset, otherwise perform a\nsystem reset when trst is 0.\n\nThe set_state call assumes the that OpenJTAG hardware will perform a\nsoftware TLR reset if the target state is TAP_RESET. This is not the\ncase: the published VHDL will simply find the shortest path to TLR and\nnot perform a fixed 5 cycle operation with TMS held high.\n\nFix the code to only perform system resets when srst is 1 in\nexecute_reset and to force a software TAP reset operation in set_state\nwhen the target state is TAP_RESET.\n\nChange-Id: I7e0f76f8491efefff1ccaeb4b1ae16e722d76df4\nSigned-off-by: N S \u003cnlshipp@yahoo.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}