)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"9e8235361f4753589506d61d3b6ec9cb4f3b1007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7df11de0_ae8dc963","updated":"2024-01-28 20:47:45.000000000","message":"0b prefix means binary number, not 0b hex!!!!","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"f8f9e2ef099ee6fb3ec224636e90958fac9b4dd8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6d0660fe_b9374076","updated":"2024-01-28 20:48:18.000000000","message":"Sorry, these are *not* hex numbers, they are binary numbers.\nUnfortunately, C has standardized them only as late as C23 (C++ did it earlier), even though a number of compilers already treated them correctly before.\nThus, the entire patch is wrong. If you want to make it compilable on older compilers, you need to turn the binary numbers into hex numbers:\n\n0b01 \u003d\u003e 0x1\n0b111 \u003d\u003e 0xF","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"d20274033de2afe5b6b7ba1b0ff3a34b87bd29cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eadeacab_37793726","in_reply_to":"1d0f2b2b_0ca07c02","updated":"2024-01-29 16:00:00.000000000","message":"Done","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"0ea59a943562128487298298d63af7f009cd9902","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd1c1472_50e3ca06","in_reply_to":"6d0660fe_b9374076","updated":"2024-01-28 20:56:19.000000000","message":"Ah, thanks for the explanation. I\u0027ll work through these and armv8 support (since the issue is there too and follow up.\ne.g\nsrc/target/armv8_dpm.c:49:19: error: invalid suffix \"b1\" on integer constant\nsrc/target/armv8_dpm.c:324:69: error: invalid suffix \"b1001100000100000\" on integer constant\nsrc/target/armv8_dpm.c:412:71: error: invalid suffix \"b1001100000100000\" on integer constant","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"c5d3179c7148ddf820fe7676f7251cb77fcdefa0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d0f2b2b_0ca07c02","in_reply_to":"d6604f3e_cc761a11","updated":"2024-01-29 15:48:17.000000000","message":"Convert the remainder of src/target/armv8_opcodes.h to hex for completeness if this is ok so far?","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"b5348c02034d23c10f42017fa24413179ff52be7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f29e6ea6_af445685","in_reply_to":"dd1c1472_50e3ca06","updated":"2024-01-28 21:23:16.000000000","message":"Perhaps configure.ac should be taught to find out whether the compiler supports binary constants. If not, the respective places could be #ifdef\u0027ed.","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"4f4565a67262fb500d113d1860efc44b9d990e5d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6604f3e_cc761a11","in_reply_to":"f29e6ea6_af445685","updated":"2024-01-29 00:53:21.000000000","message":"On OpenOCD 0.12.0, this is what\u0027s currently using binary numbers, if I configure with `--enable-buspirate --enable-stlink --enable-dummy --enable-jtag_vpi --enable-remote-bitbang` and attempt to build.  \n\nBasically armv8 target \u0026 src/flash/nor/xcf.c  \n\n```\n--- src/flash/nor/xcf.c.orig\t2024-01-27 18:23:11.000000000 +0000\n+++ src/flash/nor/xcf.c\t2024-01-27 18:25:03.000000000 +0000\n@@ -130,8 +130,8 @@\n \tjtag_add_ir_scan(bank-\u003etarget-\u003etap, \u0026scan, TAP_IDLE);\n \tjtag_execute_queue();\n \n-\tret.isc_error   \u003d ((irdata[0] \u003e\u003e 7) \u0026 3) \u003d\u003d 0b01;\n-\tret.prog_error  \u003d ((irdata[0] \u003e\u003e 5) \u0026 3) \u003d\u003d 0b01;\n+\tret.isc_error   \u003d ((irdata[0] \u003e\u003e 7) \u0026 3) \u003d\u003d 0x1;\n+\tret.prog_error  \u003d ((irdata[0] \u003e\u003e 5) \u0026 3) \u003d\u003d 0x1;\n \tret.prog_busy   \u003d ((irdata[0] \u003e\u003e 4) \u0026 1) \u003d\u003d 0;\n \tret.isc_mode    \u003d ((irdata[0] \u003e\u003e 3) \u0026 1) \u003d\u003d 1;\n \n@@ -528,7 +528,7 @@\n {\n \tuint8_t buf[4];\n \tuint32_t btc \u003d 0xFFFFFFFF;\n-\tbtc \u0026\u003d ~0b1111;\n+\tbtc \u0026\u003d ~0xF;\n \tbtc |\u003d ((bank-\u003enum_sectors - 1) \u003c\u003c 2);\n \tbtc \u0026\u003d ~(1 \u003c\u003c 4);\n \th_u32_to_le(buf, btc);\n--- src/target/armv8_dpm.c.orig\t2024-01-28 21:01:24.000000000 +0000\n+++ src/target/armv8_dpm.c\t2024-01-28 21:05:05.000000000 +0000\n@@ -46,7 +46,7 @@\n \tdpm-\u003elast_el \u003d el;\n \n \t/* In Debug state, each bit gives the current Execution state of each EL */\n-\tif ((rw \u003e\u003e el) \u0026 0b1)\n+\tif ((rw \u003e\u003e el) \u0026 0x1)\n \t\treturn ARM_STATE_AARCH64;\n \n \treturn ARM_STATE_ARM;\n--- src/target/armv8_opcodes.h.orig\t2024-01-28 21:06:46.000000000 +0000\n+++ src/target/armv8_opcodes.h\t2024-01-29 00:09:48.000000000 +0000\n@@ -30,13 +30,13 @@\n #define SYSTEM_DAIF_MASK\t\t0x3C0\n #define SYSTEM_DAIF_SHIFT\t\t6\n \n-#define SYSTEM_ELR_EL1\t\t\t0b1100001000000001\n-#define SYSTEM_ELR_EL2\t\t\t0b1110001000000001\n-#define SYSTEM_ELR_EL3\t\t\t0b1111001000000001\n-\n-#define SYSTEM_SCTLR_EL1\t0b1100000010000000\n-#define SYSTEM_SCTLR_EL2\t0b1110000010000000\n-#define SYSTEM_SCTLR_EL3\t0b1111000010000000\n+#define SYSTEM_ELR_EL1\t\t\t0xC201\n+#define SYSTEM_ELR_EL2\t\t\t0xE201\n+#define SYSTEM_ELR_EL3\t\t\t0xF201\n+\n+#define SYSTEM_SCTLR_EL1\t0xC080\n+#define SYSTEM_SCTLR_EL2\t0xE080\n+#define SYSTEM_SCTLR_EL3\t0xF080\n \n #define SYSTEM_FPCR\t\t\t0b1101101000100000\n #define SYSTEM_FPSR\t\t\t0b1101101000100001\n@@ -51,55 +51,55 @@\n #define SYSTEM_SPSR_IRQ\t\t\t0b1110001000011000\n #define SYSTEM_SPSR_UND\t\t\t0b1110001000011010\n \n-#define SYSTEM_SPSR_EL1\t\t\t0b1100001000000000\n-#define SYSTEM_SPSR_EL2\t\t\t0b1110001000000000\n-#define SYSTEM_SPSR_EL3\t\t\t0b1111001000000000\n+#define SYSTEM_SPSR_EL1\t\t\t0xC200\n+#define SYSTEM_SPSR_EL2\t\t\t0xE200\n+#define SYSTEM_SPSR_EL3\t\t\t0xF200\n \n #define SYSTEM_ISR_EL1\t\t\t0b1100011000001000\n \n #define SYSTEM_DBG_DSPSR_EL0    0b1101101000101000\n #define SYSTEM_DBG_DLR_EL0\t\t0b1101101000101001\n-#define SYSTEM_DBG_DTRRX_EL0\t0b1001100000101000\n-#define SYSTEM_DBG_DTRTX_EL0\t0b1001100000101000\n-#define SYSTEM_DBG_DBGDTR_EL0\t0b1001100000100000\n-\n-#define SYSTEM_CCSIDR\t\t\t0b1100100000000000\n-#define SYSTEM_CLIDR\t\t\t0b1100100000000001\n-#define SYSTEM_CSSELR\t\t\t0b1101000000000000\n+#define SYSTEM_DBG_DTRRX_EL0\t0x9828\n+#define SYSTEM_DBG_DTRTX_EL0\t0x9828\n+#define SYSTEM_DBG_DBGDTR_EL0\t0x9820\n+\n+#define SYSTEM_CCSIDR\t\t\t0xC800\n+#define SYSTEM_CLIDR\t\t\t0xC801\n+#define SYSTEM_CSSELR\t\t\t0xD000\n #define SYSTEM_CTYPE\t\t\t0b1101100000000001\n-#define SYSTEM_CTR\t\t\t\t0b1101100000000001\n+#define SYSTEM_CTR\t\t\t0xD801\n \n-#define SYSTEM_DCCISW\t\t\t0b0100001111110010\n+#define SYSTEM_DCCISW\t\t\t0x43F2\n #define SYSTEM_DCCSW\t\t\t0b0100001111010010\n-#define SYSTEM_ICIVAU\t\t\t0b0101101110101001\n+#define SYSTEM_ICIVAU\t\t\t0x5BA9\n #define SYSTEM_DCCVAU\t\t\t0b0101101111011001\n-#define SYSTEM_DCCIVAC\t\t\t0b0101101111110001\n+#define SYSTEM_DCCIVAC\t\t\t0x5BF1\n \n-#define SYSTEM_MPIDR\t\t\t0b1100000000000101\n+#define SYSTEM_MPIDR\t\t\t0xC005\n \n-#define SYSTEM_TCR_EL1\t\t\t0b1100000100000010\n-#define SYSTEM_TCR_EL2\t\t\t0b1110000100000010\n-#define SYSTEM_TCR_EL3\t\t\t0b1111000100000010\n+#define SYSTEM_TCR_EL1\t\t\t0xC102\n+#define SYSTEM_TCR_EL2\t\t\t0xE102\n+#define SYSTEM_TCR_EL3\t\t\t0xF102\n \n-#define SYSTEM_TTBR0_EL1\t\t0b1100000100000000\n-#define SYSTEM_TTBR0_EL2\t\t0b1110000100000000\n-#define SYSTEM_TTBR0_EL3\t\t0b1111000100000000\n+#define SYSTEM_TTBR0_EL1\t\t0xC100\n+#define SYSTEM_TTBR0_EL2\t\t0xE100\n+#define SYSTEM_TTBR0_EL3\t\t0xF100\n #define SYSTEM_TTBR1_EL1\t\t0b1100000100000001\n \n /* ARMv8 address translation */\n-#define SYSTEM_PAR_EL1\t\t\t0b1100001110100000\n-#define SYSTEM_ATS12E0R\t\t\t0b0110001111000110\n-#define SYSTEM_ATS12E1R\t\t\t0b0110001111000100\n-#define SYSTEM_ATS1E2R\t\t\t0b0110001111000000\n-#define SYSTEM_ATS1E3R\t\t\t0b0111001111000000\n+#define SYSTEM_PAR_EL1\t\t\t0xC3A0\n+#define SYSTEM_ATS12E0R\t\t\t0x63C6\n+#define SYSTEM_ATS12E1R\t\t\t0x63C4\n+#define SYSTEM_ATS1E2R\t\t\t0x63C0\n+#define SYSTEM_ATS1E3R\t\t\t0x73C0\n \n /* fault status and fault address */\n #define SYSTEM_FAR_EL1\t\t\t0b1100001100000000\n #define SYSTEM_FAR_EL2\t\t\t0b1110001100000000\n #define SYSTEM_FAR_EL3\t\t\t0b1111001100000000\n-#define SYSTEM_ESR_EL1\t\t\t0b1100001010010000\n-#define SYSTEM_ESR_EL2\t\t\t0b1110001010010000\n-#define SYSTEM_ESR_EL3\t\t\t0b1111001010010000\n+#define SYSTEM_ESR_EL1\t\t\t0xC290\n+#define SYSTEM_ESR_EL2\t\t\t0xE290\n+#define SYSTEM_ESR_EL3\t\t\t0xF290\n \n #define ARMV8_MRS_DSPSR(rt)\t(0xd53b4500 | (rt))\n #define ARMV8_MSR_DSPSR(rt)\t(0xd51b4500 | (rt))\n ```","commit_id":"42d6e1b9644e6436d252652e22b1cbf4256e236e"},{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"03fd4242ab57a8ff46187d8e850ae45eedb21848","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf23e046_a2264a3c","updated":"2024-02-01 19:50:28.000000000","message":"In addition to the Jenink build failure – I am not sure I am completely happy about removing binary literals. It\u0027s kind of going a step backwards to historical practice, rather than forward to the future, now that C23 is almost ready to go, and many compilers already support the feature.\nI\u0027d have preferred to somehow encapsulate and #ifdef the binary constants. However, I admit I\u0027m not sure whether this is really practical, so I\u0027d like to hear others\u0027 opinions, and vote neither negative nor positive about your suggestion.","commit_id":"31c67f1aa5314865c41876434b79dab29374f4f0"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"87962e49b9703cf7ad7310328ddf74ada662d28a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad3ce6d4_644392ad","updated":"2024-02-01 19:35:53.000000000","message":"The codebase is now free of binary literals.","commit_id":"31c67f1aa5314865c41876434b79dab29374f4f0"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"0f08c78792a98043989a77ada14a8ffd104038d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a9f602c_4d3354e6","in_reply_to":"04f41455_d3c1feac","updated":"2024-02-01 22:19:21.000000000","message":"Done","commit_id":"31c67f1aa5314865c41876434b79dab29374f4f0"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"d84f1cd3ac4af5eeff56f5b853b27f7c4aabf1f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04f41455_d3c1feac","in_reply_to":"bf23e046_a2264a3c","updated":"2024-02-01 20:59:19.000000000","message":"Apart from a bunch of constants, there\u0027s a few lines in 2 other files. I think it\u0027s hardly an onset to a new language standard support \u0026 with this change makes it accessible to a lot more systems new \u0026 ancient. (I\u0027m now able to use openocd on a 20 year old mac).\nI look forward to feedback.\nI\u0027ve fixed the whitespace/tab issue \u0026 build now passes 😊","commit_id":"31c67f1aa5314865c41876434b79dab29374f4f0"},{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"be123af6750c1a280c4c8a009ed4468dd5caeba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a24accc2_d21cdcab","updated":"2024-02-01 22:26:03.000000000","message":"I eyeball-reviewed the translated constants, and think they are OK.","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f721e33db975c0f509f086ac26865e5c7decd361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d3b3df7_0e753816","updated":"2024-02-02 16:28:00.000000000","message":"Karl, thanks a lot for checking the conversion!\n\nSevan, the change looks good, I commented just a couple of cosmetic nits.","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"403be044ccf74b10d9b69ee39e60a155e904bc03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6cd33e4_c188f112","updated":"2024-02-01 20:58:21.000000000","message":"Looks good to me.  The vast majority of the code base uses hex, and I find that even 16bit makes for literals that are too long to count bits in binary form.  \n\nThere\u0027s no reason to keep the 0b form \"just because\" when we can make it compile in more places for free, even making it more consistent code.  (you can see even in just this patch set that it was mixing binary and hex literals (and decimal) on adjacent lines)\n\nIf someone wants to go crazy, the armv8 stuff could be composed from symbolic bits, you can see that especially the ELx levels are all shared.  That\u0027s far more than needs to be done here.\nI\u0027ve manually reverified all the changed constants are consistent.  LGTM","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"b5e6dd0180d9e2dfb96dcc443242fe7a72ab063a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"331bc165_9acf8cbc","updated":"2024-02-02 16:46:38.000000000","message":"Thanks for the heads up. I\u0027ve mades those changes.","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"461bb1e15e3b3d427c0a9d9b8ac6ece7c9a66948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0879390d_5c3296c0","in_reply_to":"a24accc2_d21cdcab","updated":"2024-02-02 13:28:22.000000000","message":"Thanks.","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"be123af6750c1a280c4c8a009ed4468dd5caeba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a2f009b9_6bef50aa","in_reply_to":"c6cd33e4_c188f112","updated":"2024-02-01 22:26:03.000000000","message":"Indeed, longer binary constants only make sense when being able to use group markers:\n\n0b1001\u00271100\u00271000\u00270000\n\nThese, however, are still relatively new for C (have been around already for C++), so keeping with hex is the best compromise, it seems.","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1000622,"name":"Jörg Wunsch","email":"openocd@uriah.heep.sax.de","username":"dl8dtl"},"change_message_id":"2afc846193c03b3b35f181e83dc44ea6a8d864d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"38ca69f6_28ae883f","updated":"2024-02-02 19:59:18.000000000","message":"fine with me","commit_id":"ab5111e8c0255de7afacf754fba8df740e515305"}],"src/flash/nor/xcf.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f721e33db975c0f509f086ac26865e5c7decd361","unresolved":true,"context_lines":[{"line_number":130,"context_line":"\tjtag_add_ir_scan(bank-\u003etarget-\u003etap, \u0026scan, TAP_IDLE);"},{"line_number":131,"context_line":"\tjtag_execute_queue();"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"\tret.isc_error   \u003d ((irdata[0] \u003e\u003e 7) \u0026 3) \u003d\u003d 0x1;"},{"line_number":134,"context_line":"\tret.prog_error  \u003d ((irdata[0] \u003e\u003e 5) \u0026 3) \u003d\u003d 0x1;"},{"line_number":135,"context_line":"\tret.prog_busy   \u003d ((irdata[0] \u003e\u003e 4) \u0026 1) \u003d\u003d 0;"},{"line_number":136,"context_line":"\tret.isc_mode    \u003d ((irdata[0] \u003e\u003e 3) \u0026 1) \u003d\u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"b21ee10f_1c54f4dc","line":133,"range":{"start_line":133,"start_character":45,"end_line":133,"end_character":48},"updated":"2024-02-02 16:28:00.000000000","message":"Please use just `1` instead of `0x1`.\n`0b01` suggested that 2 bits were used - this corresponds to the mask on left side. But there no such point after converting binary to any other base.\n\nA line below too","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"b5e6dd0180d9e2dfb96dcc443242fe7a72ab063a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"\tjtag_add_ir_scan(bank-\u003etarget-\u003etap, \u0026scan, TAP_IDLE);"},{"line_number":131,"context_line":"\tjtag_execute_queue();"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"\tret.isc_error   \u003d ((irdata[0] \u003e\u003e 7) \u0026 3) \u003d\u003d 0x1;"},{"line_number":134,"context_line":"\tret.prog_error  \u003d ((irdata[0] \u003e\u003e 5) \u0026 3) \u003d\u003d 0x1;"},{"line_number":135,"context_line":"\tret.prog_busy   \u003d ((irdata[0] \u003e\u003e 4) \u0026 1) \u003d\u003d 0;"},{"line_number":136,"context_line":"\tret.isc_mode    \u003d ((irdata[0] \u003e\u003e 3) \u0026 1) \u003d\u003d 1;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"3ddeb79a_4db28a17","line":133,"range":{"start_line":133,"start_character":45,"end_line":133,"end_character":48},"in_reply_to":"b21ee10f_1c54f4dc","updated":"2024-02-02 16:46:38.000000000","message":"Done","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"}],"src/target/armv8_dpm.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f721e33db975c0f509f086ac26865e5c7decd361","unresolved":true,"context_lines":[{"line_number":46,"context_line":"\tdpm-\u003elast_el \u003d el;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\t/* In Debug state, each bit gives the current Execution state of each EL */"},{"line_number":49,"context_line":"\tif ((rw \u003e\u003e el) \u0026 0x1)"},{"line_number":50,"context_line":"\t\treturn ARM_STATE_AARCH64;"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"\treturn ARM_STATE_ARM;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"dc797d3e_0d2ecd55","line":49,"range":{"start_line":49,"start_character":18,"end_line":49,"end_character":21},"updated":"2024-02-02 16:28:00.000000000","message":"Same here","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"},{"author":{"_account_id":1002231,"name":"Sevan Janiyan","email":"venture37@geeklan.co.uk","username":"sevan"},"change_message_id":"b5e6dd0180d9e2dfb96dcc443242fe7a72ab063a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\tdpm-\u003elast_el \u003d el;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\t/* In Debug state, each bit gives the current Execution state of each EL */"},{"line_number":49,"context_line":"\tif ((rw \u003e\u003e el) \u0026 0x1)"},{"line_number":50,"context_line":"\t\treturn ARM_STATE_AARCH64;"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"\treturn ARM_STATE_ARM;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"0e7eecc6_104ab981","line":49,"range":{"start_line":49,"start_character":18,"end_line":49,"end_character":21},"in_reply_to":"dc797d3e_0d2ecd55","updated":"2024-02-02 16:46:38.000000000","message":"Done","commit_id":"7917d1b7e22ce9048e2ec00108e1ddd9125d6ce7"}]}