)]}'
{"id":"openocd~master~Ic5a0e1774e2dbd58f1a05127f14816c8251a7d9c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002235":{"account":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"last_update":"2024-02-24 13:41:06.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-02-18 20:23:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"Ic5a0e1774e2dbd58f1a05127f14816c8251a7d9c","subject":"jtag/commands: fixed buffer overflow","status":"MERGED","created":"2024-02-02 11:40:16.000000000","updated":"2024-02-24 13:41:18.000000000","submitted":"2024-02-24 13:41:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8126","meta_rev_id":"1da52e690f422664516e2ac4513ca32beb6cab3b","_number":8126,"owner":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-24 13:41:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-24 13:41:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-24 13:41:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-02 11:53:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-02 15:50:18.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-02-18 18:54:51.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-02-18 23:01:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"86383da60e794666c95227362255973b1a5bf253","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"real_author":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"date":"2024-02-02 11:40:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aadf81ae765dda91f418547b5c7ad65cc06eb5bd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-02 11:53:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19309/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18470/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cc84d5a7c3ad5472d12d4aab1d6e39c9eba1ac6c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-02 15:50:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7035ffcfc4248ba8c0ad1f8ecd39af1896d74a27","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-18 18:54:51.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"079bb905be2a1256edf7508eb67d220f6d308d60","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"real_author":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"date":"2024-02-18 18:58:21.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"abd6108bc542159061a27f75ae728347b18bce44","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-18 19:12:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19367/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18528/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"6dd2d6853f4360a4e34382b9f1b75a0fde1f50d5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-18 20:23:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5d21a23671da7f572c73efb87e1d4db2356514ab","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-18 23:01:45.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6e64849e2c984c456c8c89f4db6728eae3c741fb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-24 13:40:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0e29f7aff2e1b62b106efef089e20b0c0631a541","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-24 13:41:06.000000000","message":"Change has been successfully cherry-picked as 179169268ca1bbac092324f597fbea090d75355e","accounts_in_message":[],"_revision_number":3},{"id":"1da52e690f422664516e2ac4513ca32beb6cab3b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-24 13:41:18.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision":"179169268ca1bbac092324f597fbea090d75355e","revisions":{"179169268ca1bbac092324f597fbea090d75355e":{"kind":"REWORK","_number":3,"created":"2024-02-24 13:41:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/26/8126/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/8126/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/3 \u0026\u0026 git checkout -b change-8126 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/8126/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"33573cda4aa5685b32c44a81b1f2d84a28d78810","subject":"src/target/riscv: Help older compilers"}],"author":{"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","date":"2024-02-02 11:12:48.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-24 13:41:06.000000000","tz":0},"subject":"jtag/commands: fixed buffer overflow","message":"jtag/commands: fixed buffer overflow\n\nWhen performing a command queue allocation larger than the default page\nsize of 1MiB any subsequent allocations will run into an integer under-\nflow when checking for the remaining memory left in the current page.\nCausing the function returning a pointer past the end of the buffer and\nthus creating a buffer overflow.\n\nThis has been observed to cause some transfers to Efinix FPGAs to fail,\nbecause another buffer can get corrupted in the process, causing its\nrespective free() to fail.\n\nChange-Id: Ic5a0e1774e2dbd58f1a05127f14816c8251a7d9c\nSigned-off-by: SydMontague \u003csydmontague@phoenix-staffel.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8126\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"760aa3df90860ba7b10328b863500bd9d47461bc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-02-18 18:58:21.000000000","uploader":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"ref":"refs/changes/26/8126/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/8126/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/2 \u0026\u0026 git checkout -b change-8126 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/8126/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9659a9b5e28dc615dfb508d301fdd8fa426c191b","subject":"target/esirisc: free memory at OpenOCD exit"}],"author":{"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","date":"2024-02-02 11:12:48.000000000","tz":60},"committer":{"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","date":"2024-02-18 18:56:50.000000000","tz":60},"subject":"jtag/commands: fixed buffer overflow","message":"jtag/commands: fixed buffer overflow\n\nWhen performing a command queue allocation larger than the default page\nsize of 1MiB any subsequent allocations will run into an integer under-\nflow when checking for the remaining memory left in the current page.\nCausing the function returning a pointer past the end of the buffer and\nthus creating a buffer overflow.\n\nThis has been observed to cause some transfers to Efinix FPGAs to fail,\nbecause another buffer can get corrupted in the process, causing its\nrespective free() to fail.\n\nChange-Id: Ic5a0e1774e2dbd58f1a05127f14816c8251a7d9c\nSigned-off-by: SydMontague \u003csydmontague@phoenix-staffel.de\u003e\n"}},"6802bde3fb2083450d63b1183c45ba404eaa581f":{"kind":"REWORK","_number":1,"created":"2024-02-02 11:40:16.000000000","uploader":{"_account_id":1002235,"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","username":"SydMontague"},"ref":"refs/changes/26/8126/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/26/8126/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/1 \u0026\u0026 git checkout -b change-8126 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/26/8126/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/26/8126/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9659a9b5e28dc615dfb508d301fdd8fa426c191b","subject":"target/esirisc: free memory at OpenOCD exit"}],"author":{"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","date":"2024-02-02 11:12:48.000000000","tz":60},"committer":{"name":"SydMontague","email":"sydmontague@phoenix-staffel.de","date":"2024-02-02 11:39:40.000000000","tz":60},"subject":"jtag/commands: fixed buffer overflow","message":"jtag/commands: fixed buffer overflow\n\nWhen performing a command queue allocation larger than the default page\nsize of 1MiB any subsequent allocations will run into an integer under-\nflow when checking for the remaining memory left in the current page.\nCuasing the function returning a pointer past the end of the buffer and\nthus creating a buffer overflow.\n\nThis has been observed to cause some transfers to Efinix FPGAs to fail,\nbecause another buffer can get corrupted in the process, causing it\u0027s\nrespective free() to fail.\n\nChange-Id: Ic5a0e1774e2dbd58f1a05127f14816c8251a7d9c\nSigned-off-by: SydMontague \u003csydmontague@phoenix-staffel.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}