)]}'
{"id":"openocd~master~I0b9601c160dd4f2421a03ce6e3e7c55c6212f714","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002214":{"account":{"_account_id":1002214,"name":"RolfNoot","display_name":"RolfNoot","email":"r.nooteboom@gmail.com","username":"RolfNoot"},"last_update":"2024-07-13 16:44:53.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-07-13 16:44:47.000000000","reason":"removed on reply"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-07-13 16:44:53.000000000","reason":"Change was submitted"},"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2024-07-13 16:44:53.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-06-25 07:22:02.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"I0b9601c160dd4f2421a03ce6e3e7c55c6212f714","subject":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU","status":"MERGED","created":"2024-02-03 13:45:53.000000000","updated":"2024-07-13 16:44:53.000000000","submitted":"2024-07-13 16:44:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8128","meta_rev_id":"c734d84d430f94da28f714653cb2e22f41e8c074","_number":8128,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 16:44:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-07-13 16:44:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-07-13 16:44:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002214,"name":"RolfNoot","display_name":"RolfNoot","email":"r.nooteboom@gmail.com","username":"RolfNoot"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"}],"reviewers":{"CC":[{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},{"_account_id":1002214,"name":"RolfNoot","display_name":"RolfNoot","email":"r.nooteboom@gmail.com","username":"RolfNoot"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-03 14:02:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-03 14:11:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"state":"REVIEWER"},{"updated":"2024-02-03 14:11:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2024-02-03 14:11:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002214,"name":"RolfNoot","display_name":"RolfNoot","email":"r.nooteboom@gmail.com","username":"RolfNoot"},"state":"REVIEWER"},{"updated":"2024-02-03 14:11:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-06-25 19:56:00.000000000","updated_by":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"reviewer":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"state":"CC"}],"messages":[{"id":"7480e2fe8f045a65527990ea96604f1430d3c45d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-03 13:45:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d3c1ad0368d23771ef9c1b953612445127c87d0f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-03 14:02:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19312/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18473/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"79e81c7e6463efecf20646e6cdc9c6d53bd68884","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-03 14:11:45.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e6893e413117d6b0a2919dddec140f6d8b8208be","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-03 16:33:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"453b3a6886f7dce355e4271761ab36634149bb70","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-03 18:57:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e8e3a8ed64f5bf06c2935796c303101d71a3d01c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-03 19:49:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"796954ec714b96bf1cf2fc0470ad96e64caf1c82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-04 14:17:06.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"37fb3ea6f6eb8f9fa8c31c58710561aeb9a9bf4a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-04 14:30:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19318/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18479/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5d2f58f0bee902c3d21ce51e0f839d7374d6fa04","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 17:59:54.000000000","message":"Uploaded patch set 3: Code-Review+1.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"5b6bb0a88b97cb0ca0a48ea2d7a0f64135aba01f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-08 18:36:46.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19685/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18841/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"7a73ee80527d0be594488ece132f16fe8631c4bd","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-06-25 07:22:02.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8503a219ae0a46585dce88824a11482d4675559e","author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"real_author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"date":"2024-06-25 19:56:00.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e25ede9cbaebac8bb80db6db91fba3ec428e703a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 16:44:47.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c734d84d430f94da28f714653cb2e22f41e8c074","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-07-13 16:44:53.000000000","message":"Change has been successfully cherry-picked as 2fe392ef5085432bb5ae762469ed16e08678f102","accounts_in_message":[],"_revision_number":4}],"current_revision":"2fe392ef5085432bb5ae762469ed16e08678f102","revisions":{"2fe392ef5085432bb5ae762469ed16e08678f102":{"kind":"REWORK","_number":4,"created":"2024-07-13 16:44:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8128/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8128/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/4 \u0026\u0026 git checkout -b change-8128 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8128/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c9f22c79dfecf61a7160a324a8b9f4fce695c67c","subject":"doc: document \u0027target create\u0027 flags \u0027-dbgbase\u0027 and \u0027-coreid\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-03 13:29:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-07-13 16:44:53.000000000","tz":0},"subject":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU","message":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU\n\nThe flag \u0027-coreid\u0027 is used by the command \u0027target create\u0027 to\nspecify the debug controller of the target, either in case of a\nsingle debug controller for multiple CPU (e.g. RISC-V harts) or\nin case of multiple CPU on a DAP access port (e.g. Cortex-A SMP\ncluster).\nIt is also currently used to specify the CPU ID in a SMP cluster,\nbut this is going to be reworked.\n\nThis flag has no effects on Cortex-M; ARM specifies that only one\nCPU Cortex-M can occupy the DAP access port by using hardcoded\naddresses.\n\nThe flash driver \u0027psoc6\u0027 uses the flag \u0027-coreid\u0027 to detect if the\ncurrent target is the Cortex-M0 on AP#1 or the Cortex-M4 on AP#2\nin the SoC.\nThere are other ways to run such detection, without using such\nunrelated \u0027-coreid\u0027 flag, e.g. using the AP number or the arch\ntype of the target.\n\nUse the arch type to detect Cortex-M0 (ARM_ARCH_V6M) vs Cortex-M4\n(ARM_ARCH_V7M).\nDrop the flags \u0027-coreid\u0027 from the psoc6 configuration file.\n\nChange-Id: I0b9601c160dd4f2421a03ce6e3e7c55c6212f714\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8128\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ebcf46a3460710e436f023a8845b33f644793c8f":{"kind":"REWORK","_number":3,"created":"2024-06-08 17:59:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8128/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8128/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/3 \u0026\u0026 git checkout -b change-8128 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8128/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ead302902ed96525d44a06060e29f6efdbe66a56","subject":"doc: document \u0027target create\u0027 flags \u0027-dbgbase\u0027 and \u0027-coreid\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-03 13:29:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-08 17:52:13.000000000","tz":120},"subject":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU","message":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU\n\nThe flag \u0027-coreid\u0027 is used by the command \u0027target create\u0027 to\nspecify the debug controller of the target, either in case of a\nsingle debug controller for multiple CPU (e.g. RISC-V harts) or\nin case of multiple CPU on a DAP access port (e.g. Cortex-A SMP\ncluster).\nIt is also currently used to specify the CPU ID in a SMP cluster,\nbut this is going to be reworked.\n\nThis flag has no effects on Cortex-M; ARM specifies that only one\nCPU Cortex-M can occupy the DAP access port by using hardcoded\naddresses.\n\nThe flash driver \u0027psoc6\u0027 uses the flag \u0027-coreid\u0027 to detect if the\ncurrent target is the Cortex-M0 on AP#1 or the Cortex-M4 on AP#2\nin the SoC.\nThere are other ways to run such detection, without using such\nunrelated \u0027-coreid\u0027 flag, e.g. using the AP number or the arch\ntype of the target.\n\nUse the arch type to detect Cortex-M0 (ARM_ARCH_V6M) vs Cortex-M4\n(ARM_ARCH_V7M).\nDrop the flags \u0027-coreid\u0027 from the psoc6 configuration file.\n\nChange-Id: I0b9601c160dd4f2421a03ce6e3e7c55c6212f714\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5bc75e51db9b1dd61722299cf5f4ede50d6f8d94":{"kind":"REWORK","_number":2,"created":"2024-02-04 14:17:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8128/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8128/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/2 \u0026\u0026 git checkout -b change-8128 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8128/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"879fb24a6f84c3c88f7a7909aa6b2ae3185b9024","subject":"doc: document \u0027target create\u0027 flags \u0027-dbgbase\u0027 and \u0027-coreid\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-03 13:29:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-04 14:16:12.000000000","tz":60},"subject":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU","message":"flash: psoc6: drop use of \u0027coreid\u0027 to identify the CPU\n\nThe flag \u0027-coreid\u0027 is used by the command \u0027target create\u0027 to\nspecify the debug controller of the target, either in case of a\nsingle debug controller for multiple CPU (e.g. RISC-V harts) or\nin case of multiple CPU on a DAP access port (e.g. Cortex-A SMP\ncluster).\nIt is also currently used to specify the CPU ID in a SMP cluster,\nbut this is going to be reworked.\n\nThis flag has no effects on Cortex-M; ARM specifies that only one\nCPU Cortex-M can occupy the DAP access port by using hardcoded\naddresses.\n\nThe flash driver \u0027psoc6\u0027 uses the flag \u0027-coreid\u0027 to detect if the\ncurrent target is the Cortex-M0 or the Cortex-M4 in the SoC.\nThere are other ways to run such detection, without using such\nunrelated flag. E.g. the AP number or the arch type.\n\nUse the arch type to detect Cortex-M0 (ARM_ARCH_V6M) vs Cortex-M4\n(ARM_ARCH_V7M).\nDrop the flags \u0027-coreid\u0027 from the psoc6 configuration file.\n\nChange-Id: I0b9601c160dd4f2421a03ce6e3e7c55c6212f714\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"55f41b7d8e1d37e74b831a0fbb2e8894fedc0bdc":{"kind":"REWORK","_number":1,"created":"2024-02-03 13:45:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8128/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8128/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/1 \u0026\u0026 git checkout -b change-8128 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8128/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8128/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9659a9b5e28dc615dfb508d301fdd8fa426c191b","subject":"target/esirisc: free memory at OpenOCD exit"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-03 13:29:57.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-03 13:43:20.000000000","tz":60},"subject":"flash: psoc6: drop incorrect use of \u0027coreid\u0027","message":"flash: psoc6: drop incorrect use of \u0027coreid\u0027\n\nThe flag \u0027-coreid\u0027 is used by the command \u0027target create\u0027 to parse\nthe ROM table of the DAP AP and to select the N-th CPU, where \u0027N\u0027\nis the value provided as \u0027coreid\u0027.\n\nThis flag has no effects on Cortex-M; ARM specifies that only one\nCPU Cortex-M can occupy the AP, using hardcoded addresses.\n\nThe flash driver \u0027psoc6\u0027 abuses the flag \u0027-coreid\u0027 to detect if\nthe current target is the Cortex-M0 or the Cortex-M4.\nThere are other ways to run such detection, without abusing an\nunrelated flag. E.g. the AP number or the arch type.\n\nUse the arch type to detect Cortex-M0 (ARM_ARCH_V6M) vs Cortex-M4\n(ARM_ARCH_V7M).\nDrop the flags \u0027-coreid\u0027 from the psoc6 configuration file.\n\nChange-Id: I0b9601c160dd4f2421a03ce6e3e7c55c6212f714\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}