)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"3fdb88dff3a196548413d9639e17a443016f1cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"efba9cdf_46b5c209","updated":"2024-03-01 19:25:02.000000000","message":"changed puts to echo","commit_id":"b3c060c42f5290b1e2a5c6c9b00b26f80d82843f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bf4a0a8260e44d4327386db631084d49cd5461c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8bb23984_b51a763f","updated":"2024-04-16 15:27:23.000000000","message":"minor comment, I let you decide how to proceed.\nFor the rest, I\u0027m ok to merge it","commit_id":"b3c060c42f5290b1e2a5c6c9b00b26f80d82843f"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"efffbf8130035f12787fc2dda97b4ebe753ad57c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6d7d4c3e_b0b9ff0c","updated":"2024-03-22 17:40:37.000000000","message":"ping?","commit_id":"b3c060c42f5290b1e2a5c6c9b00b26f80d82843f"}],"tcl/target/xilinx_zynqmp.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7580036b6f4e49a93d3f7654b551c193823455e6","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"set OCM_RAM_BASE\t\t0xfffc0000"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"rename BIT {}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"add_help_text halt_pmu \"Halt the PMU in preparation for loading new firmware.\\"},{"line_number":139,"context_line":"\tThis should be matched with a call to resume_pmu.\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"d3df0dfb_6b9dc646","line":136,"updated":"2024-02-24 17:51:19.000000000","message":"why you make the proc disappear?","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3b0d086465f0b49ad802ee67bdad3dd9b6f6d3d4","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"set OCM_RAM_BASE\t\t0xfffc0000"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"rename BIT {}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"add_help_text halt_pmu \"Halt the PMU in preparation for loading new firmware.\\"},{"line_number":139,"context_line":"\tThis should be matched with a call to resume_pmu.\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"e4d3d049_a695ffff","line":136,"in_reply_to":"1649376f_3bd15fee","updated":"2024-04-16 15:37:39.000000000","message":"Only because it looks strange. But again, I\u0027m ok to proceed with this if you prefer keeping as is","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bf4a0a8260e44d4327386db631084d49cd5461c6","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"set OCM_RAM_BASE\t\t0xfffc0000"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"rename BIT {}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"add_help_text halt_pmu \"Halt the PMU in preparation for loading new firmware.\\"},{"line_number":139,"context_line":"\tThis should be matched with a call to resume_pmu.\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"dd80555b_cf012798","line":136,"in_reply_to":"a5e7ffa1_5a81cbf6","updated":"2024-04-16 15:27:23.000000000","message":"I\u0027m not sure this is what you want, but for proc\u0027s that should have limited visibility, you can add a \u0027_\u0027 character in front so it will not clash with OpenOCD commands:\n```\nproc _BIT {n} {\n    ...\n}\n```\nlike you did for proc _rvbaraddr below, and then add its name to the list of commands/proc to not be visible by the auto-completion:\n```\nlappend _telnet_autocomplete_skip _BIT\n```\nin this way even typing \u0027_\u0027 following by a TAB you will not find _BIT","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"bb1b07d7d4b184b39d42b68b0cf164a7a9746ef3","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"set OCM_RAM_BASE\t\t0xfffc0000"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"rename BIT {}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"add_help_text halt_pmu \"Halt the PMU in preparation for loading new firmware.\\"},{"line_number":139,"context_line":"\tThis should be matched with a call to resume_pmu.\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"a5e7ffa1_5a81cbf6","line":136,"in_reply_to":"d3df0dfb_6b9dc646","updated":"2024-03-01 19:20:15.000000000","message":"It\u0027s just a helper function. I don\u0027t want it to be part of this file\u0027s API.","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"e7d69ff4ef826269fe59d3de95a421de4d84d7d7","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"set OCM_RAM_BASE\t\t0xfffc0000"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"rename BIT {}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"add_help_text halt_pmu \"Halt the PMU in preparation for loading new firmware.\\"},{"line_number":139,"context_line":"\tThis should be matched with a call to resume_pmu.\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1649376f_3bd15fee","line":136,"in_reply_to":"dd80555b_cf012798","updated":"2024-04-16 15:31:36.000000000","message":"But what\u0027s the point? The function is only a helper for the constants; once the constants are set we don\u0027t need it any more.","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"47429315fa31eeb3e026ab91820a14be22edb794","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"set OCM_RAM_BASE\t\t0xfffc0000"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"rename BIT {}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"add_help_text halt_pmu \"Halt the PMU in preparation for loading new firmware.\\"},{"line_number":139,"context_line":"\tThis should be matched with a call to resume_pmu.\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a6315aa_877ecb4a","line":136,"in_reply_to":"e4d3d049_a695ffff","updated":"2024-04-16 15:40:52.000000000","message":"Ack","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7580036b6f4e49a93d3f7654b551c193823455e6","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\tafter we resume it.\""},{"line_number":221,"context_line":"proc boot_pmu {image} {"},{"line_number":222,"context_line":"\thalt_pmu"},{"line_number":223,"context_line":"\tputs \"Info : Loading PMU firmware $image to $::PMU_RAM_BASE\""},{"line_number":224,"context_line":"\tload_image $image $::PMU_RAM_BASE"},{"line_number":225,"context_line":"\tresume_pmu"},{"line_number":226,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"f135d148_4e429633","line":223,"updated":"2024-02-24 17:51:19.000000000","message":"the TCL command ```puts``` prints on stdout.\nIn OpenOCD we prefers not using stdout because OpenOCD can optionally be run from inside GDB using stdin/stdout as the communication channel between GDB and OpenOCD.\nUse OpenOCD command ```echo``` for such message. It will use stderr by default, and can be re-directed to log file.","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"3fdb88dff3a196548413d9639e17a443016f1cb9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"\tafter we resume it.\""},{"line_number":221,"context_line":"proc boot_pmu {image} {"},{"line_number":222,"context_line":"\thalt_pmu"},{"line_number":223,"context_line":"\tputs \"Info : Loading PMU firmware $image to $::PMU_RAM_BASE\""},{"line_number":224,"context_line":"\tload_image $image $::PMU_RAM_BASE"},{"line_number":225,"context_line":"\tresume_pmu"},{"line_number":226,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"e93776fa_8606042e","line":223,"in_reply_to":"d3c1b889_b7cd5905","updated":"2024-03-01 19:25:02.000000000","message":"Done","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"bb1b07d7d4b184b39d42b68b0cf164a7a9746ef3","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\tafter we resume it.\""},{"line_number":221,"context_line":"proc boot_pmu {image} {"},{"line_number":222,"context_line":"\thalt_pmu"},{"line_number":223,"context_line":"\tputs \"Info : Loading PMU firmware $image to $::PMU_RAM_BASE\""},{"line_number":224,"context_line":"\tload_image $image $::PMU_RAM_BASE"},{"line_number":225,"context_line":"\tresume_pmu"},{"line_number":226,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"d3c1b889_b7cd5905","line":223,"in_reply_to":"f135d148_4e429633","updated":"2024-03-01 19:20:15.000000000","message":"Ah, thanks. I was wondering what the right command was.","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7580036b6f4e49a93d3f7654b551c193823455e6","unresolved":true,"context_lines":[{"line_number":234,"context_line":"\ttargets $::_TARGETNAME.$apu"},{"line_number":235,"context_line":"\thalt"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"\tputs \"Info : Loading APU$apu firmware $image to $addr\""},{"line_number":238,"context_line":"\tload_image $image $addr"},{"line_number":239,"context_line":"\tresume $addr"},{"line_number":240,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"6cee8a80_1614c500","line":237,"updated":"2024-02-24 17:51:19.000000000","message":"ditto","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"},{"author":{"_account_id":1001960,"name":"sean-anderson-seco","email":"sean.anderson@seco.com","username":"sean-anderson-seco"},"change_message_id":"3fdb88dff3a196548413d9639e17a443016f1cb9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"\ttargets $::_TARGETNAME.$apu"},{"line_number":235,"context_line":"\thalt"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"\tputs \"Info : Loading APU$apu firmware $image to $addr\""},{"line_number":238,"context_line":"\tload_image $image $addr"},{"line_number":239,"context_line":"\tresume $addr"},{"line_number":240,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"02b10c4c_5ac0f98c","line":237,"in_reply_to":"6cee8a80_1614c500","updated":"2024-03-01 19:25:02.000000000","message":"Done","commit_id":"b45820dc9eadbfc895eb53230e1772292c36e726"}]}