)]}'
{"id":"openocd~master~I701083cb72030e398ce1c74310676e13895a77ff","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002239":{"account":{"_account_id":1002239,"name":"Luca Rufer","display_name":"Luca Rufer","email":"lucarufer333@gmail.com","username":"LucaRufer"},"last_update":"2024-03-02 11:03:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I701083cb72030e398ce1c74310676e13895a77ff","subject":"src/jtag/drivers/mpsse: Add support for new FTDI chip types.","status":"MERGED","created":"2024-02-08 21:18:37.000000000","updated":"2024-03-02 11:03:10.000000000","submitted":"2024-03-02 11:03:10.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8134","meta_rev_id":"fd3d242271cdf0a456d24892231884d2e2dba1b9","_number":8134,"owner":{"_account_id":1002239,"name":"Luca Rufer","display_name":"Luca Rufer","email":"lucarufer333@gmail.com","username":"LucaRufer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-02 11:03:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-02 11:03:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-02 11:03:10.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-08 21:32:46.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-10 21:39:02.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-02-24 18:05:27.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"52e19aa74399661491f101b4db2205713f9f7adf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002239,"name":"Luca Rufer","display_name":"Luca Rufer","email":"lucarufer333@gmail.com","username":"LucaRufer"},"real_author":{"_account_id":1002239,"name":"Luca Rufer","display_name":"Luca Rufer","email":"lucarufer333@gmail.com","username":"LucaRufer"},"date":"2024-02-08 21:18:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a782fe4dabc01de1212ad8065990bae872b47089","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-08 21:32:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19331/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18492/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8d66ca9efa442c82128234d5572ba484cf2fea64","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-10 21:39:02.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1446d771bb8bc0ac2ef834ecf19b6e611017911b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-24 18:05:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"754a8dad14f5d0f7504fd51a245d6a3489ce5805","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-02 11:03:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fd3d242271cdf0a456d24892231884d2e2dba1b9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-02 11:03:10.000000000","message":"Change has been successfully cherry-picked as 56a7925a1d2d890adbb5dbd76542bfe901620103","accounts_in_message":[],"_revision_number":2}],"current_revision":"56a7925a1d2d890adbb5dbd76542bfe901620103","revisions":{"0dacd1f297ef1c3c394718ea47a8b6866cf049d8":{"kind":"REWORK","_number":1,"created":"2024-02-08 21:18:37.000000000","uploader":{"_account_id":1002239,"name":"Luca Rufer","display_name":"Luca Rufer","email":"lucarufer333@gmail.com","username":"LucaRufer"},"ref":"refs/changes/34/8134/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/8134/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/1 \u0026\u0026 git checkout -b change-8134 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/8134/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0d3d4c981ac77b600ce95c9ea6f1cdb280127342","subject":"jtag/adapter: retype adapter_gpio_config.{gpio,chip}_num"}],"author":{"name":"Luca Rufer","email":"lucarufer333@gmail.com","date":"2024-02-08 20:59:47.000000000","tz":60},"committer":{"name":"Luca Rufer","email":"lucarufer333@gmail.com","date":"2024-02-08 21:17:01.000000000","tz":60},"subject":"src/jtag/drivers/mpsse: Add support for new FTDI chip types.","message":"src/jtag/drivers/mpsse: Add support for new FTDI chip types.\n\nThe new FTDI ICs with USB-C Support have different bcdDevice\nidentifiers. The added bcdDevice identifiers are taken from\nthe chips datasheet, respectively. The patch was tested with\na FT4232HP IC.\nThe used bcdDevice IDs can be found in Section 8.1 of the respective\nDatasheets:\nhttps://ftdichip.com/wp-content/uploads/2023/09/DS_FT233HP-v1.4.pdf\nhttps://ftdichip.com/wp-content/uploads/2023/09/DS_FT2233HP-v1.4.pdf\nhttps://ftdichip.com/wp-content/uploads/2023/09/DS_FT4233HP-v1.5.pdf\n\nChange-Id: I701083cb72030e398ce1c74310676e13895a77ff\nSigned-off-by: Luca Rufer \u003clucarufer333@gmail.com\u003e\n"}},"56a7925a1d2d890adbb5dbd76542bfe901620103":{"kind":"REWORK","_number":2,"created":"2024-03-02 11:03:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/8134/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/8134/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/2 \u0026\u0026 git checkout -b change-8134 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/8134/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/8134/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"179169268ca1bbac092324f597fbea090d75355e","subject":"jtag/commands: fixed buffer overflow"}],"author":{"name":"Luca Rufer","email":"lucarufer333@gmail.com","date":"2024-02-08 20:59:47.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-02 11:03:10.000000000","tz":0},"subject":"src/jtag/drivers/mpsse: Add support for new FTDI chip types.","message":"src/jtag/drivers/mpsse: Add support for new FTDI chip types.\n\nThe new FTDI ICs with USB-C Support have different bcdDevice\nidentifiers. The added bcdDevice identifiers are taken from\nthe chips datasheet, respectively. The patch was tested with\na FT4232HP IC.\nThe used bcdDevice IDs can be found in Section 8.1 of the respective\nDatasheets:\nhttps://ftdichip.com/wp-content/uploads/2023/09/DS_FT233HP-v1.4.pdf\nhttps://ftdichip.com/wp-content/uploads/2023/09/DS_FT2233HP-v1.4.pdf\nhttps://ftdichip.com/wp-content/uploads/2023/09/DS_FT4233HP-v1.5.pdf\n\nChange-Id: I701083cb72030e398ce1c74310676e13895a77ff\nSigned-off-by: Luca Rufer \u003clucarufer333@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8134\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}