)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2d62be8fcd9b0579977f684aa989ce9687a1d688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df258a90_1d124830","updated":"2024-02-20 15:04:24.000000000","message":"Hi Tomas, thank you very much for the clean up and expanded functionality.  I\u0027ve tested this patch on an Xtensa/DAP board and it works as expected.  \n\nOne minor comment below which doesn\u0027t need to hold up merging this now if you\u0027d prefer to.  Thanks again.","commit_id":"cd5456eba2475afee15ef52d36c3076502ead7fe"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"26d1c756303105cb6c9699bc27f9ae316009cf88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d125bd5f_b161bb5e","updated":"2024-02-26 17:51:35.000000000","message":"I\u0027m reworking all the JIM related functions, and this would be part of it. But it\u0027s a long journey...\nI could comment that ```adiv5_jim_configure()`` can be moved as a ```static inline``` in ```arm_adi_v5.h``` but, since I will rework them later on, let\u0027s it stay as is.\nThanks","commit_id":"cd5456eba2475afee15ef52d36c3076502ead7fe"}],"src/target/xtensa/xtensa_chip.c":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"2d62be8fcd9b0579977f684aa989ce9687a1d688","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"static int xtensa_chip_jim_configure(struct target *target, struct jim_getopt_info *goi)"},{"line_number":146,"context_line":"{"},{"line_number":147,"context_line":"\treturn adiv5_jim_configure_ext(target, goi, NULL, ADI_CONFIGURE_DAP_OPTIONAL);"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"/** Methods for generic example of Xtensa-based chip-level targets. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fac77a54_891391ae","line":147,"updated":"2024-02-20 15:04:24.000000000","message":"Could we keep these LOG_DEBUG messages?  I\u0027m happy to add them back via a separate patch if you\u0027d rather not add them now.","commit_id":"cd5456eba2475afee15ef52d36c3076502ead7fe"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"d8a98cc556d7951dff013e00d11af0170f31714a","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"static int xtensa_chip_jim_configure(struct target *target, struct jim_getopt_info *goi)"},{"line_number":146,"context_line":"{"},{"line_number":147,"context_line":"\treturn adiv5_jim_configure_ext(target, goi, NULL, ADI_CONFIGURE_DAP_OPTIONAL);"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"/** Methods for generic example of Xtensa-based chip-level targets. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"63e69853_e23baa29","line":147,"in_reply_to":"680ff844_44c45970","updated":"2024-02-20 18:31:14.000000000","message":"sounds reasonable to me.  thanks for the explanation.","commit_id":"cd5456eba2475afee15ef52d36c3076502ead7fe"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"6223a315d2e314650966b56a8ab1d95a01abc016","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"static int xtensa_chip_jim_configure(struct target *target, struct jim_getopt_info *goi)"},{"line_number":146,"context_line":"{"},{"line_number":147,"context_line":"\treturn adiv5_jim_configure_ext(target, goi, NULL, ADI_CONFIGURE_DAP_OPTIONAL);"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"/** Methods for generic example of Xtensa-based chip-level targets. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"680ff844_44c45970","line":147,"in_reply_to":"fac77a54_891391ae","updated":"2024-02-20 17:52:24.000000000","message":"Be aware that this piece of code is called on parsing of every single parameter of target create or configure. I understand that the original hack with the static variable demanded some extra debugging. Now it\u0027s a standard call, no surprises, so I\u0027d recommend not to be over verbose and do it similarly as other targets do: I checked arm_adi_v5.c and aarch64.c and there is no debug logs as well. If you want emphasize -dap configuration, xxx_target_create() is a better place - and I see LOG_DEBUG is there.","commit_id":"cd5456eba2475afee15ef52d36c3076502ead7fe"}]}