)]}'
{"id":"openocd~master~I744e56e21a5a2dc2c4494cc0d7bbcb4be14ddb23","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-03-16 14:37:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I744e56e21a5a2dc2c4494cc0d7bbcb4be14ddb23","subject":"jtag/drivers/bitbang: limit SWD WAIT retries by timeout","status":"MERGED","created":"2024-02-17 12:46:22.000000000","updated":"2024-03-16 14:37:26.000000000","submitted":"2024-03-16 14:37:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8153","meta_rev_id":"cd35c65e39c595e5b7ec7f20c589d0163360dcd7","_number":8153,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-16 14:37:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-16 14:37:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-17 13:50:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-26 22:22:44.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d7005d16d6adf9536900917e550ac0b72020f77b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-17 12:46:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"541931dd912068ba1c835469026c9c40bb7256b5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-17 13:50:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19355/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18518/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"894b6fea0b54fb12130fafff9863fe176e7bcbd8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-26 22:22:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9ae4164eeebd6f82996f2553fd03a143c6efa5c9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 14:37:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cd35c65e39c595e5b7ec7f20c589d0163360dcd7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 14:37:26.000000000","message":"Change has been successfully cherry-picked as 31af18e9d1807d442885d0254ff5b13a66ea3a65","accounts_in_message":[],"_revision_number":2}],"current_revision":"31af18e9d1807d442885d0254ff5b13a66ea3a65","revisions":{"31af18e9d1807d442885d0254ff5b13a66ea3a65":{"kind":"REWORK","_number":2,"created":"2024-03-16 14:37:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/8153/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8153/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/2 \u0026\u0026 git checkout -b change-8153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8153/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f7f4fa84f1466036ebec80b3143fdd32ce181344","subject":"jtag/drivers/bitbang: use LOG_CUSTOM_LEVEL() macro for SWD"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-02-17 12:14:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-16 14:37:26.000000000","tz":0},"subject":"jtag/drivers/bitbang: limit SWD WAIT retries by timeout","message":"jtag/drivers/bitbang: limit SWD WAIT retries by timeout\n\nThe bitbang driver kept retrying a SWD command as long as\nthe debugged device had been responding by SWD WAIT.\nIf the DP stalled in WAIT permanently, OpenOCD hanged.\n\nCheck 0.5 sec timeout in WAIT retry loop.\n\nWhile on it insert a short alive_sleep() if the command\nis retried 20 or more times.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I744e56e21a5a2dc2c4494cc0d7bbcb4be14ddb23\nReviewed-on: https://review.openocd.org/c/openocd/+/8153\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"f0e822009838e55d6ddb081cf84f97dbd0ad5ea2":{"kind":"REWORK","_number":1,"created":"2024-02-17 12:46:22.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/53/8153/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/8153/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/1 \u0026\u0026 git checkout -b change-8153 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/8153/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/8153/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"887d47f1fad9a95e2ccbab9c904bae10ee6bb150","subject":"jtag/drivers/bitbang: use LOG_CUSTOM_LEVEL() macro for SWD"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-02-17 12:14:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-02-17 12:43:35.000000000","tz":60},"subject":"jtag/drivers/bitbang: limit SWD WAIT retries by timeout","message":"jtag/drivers/bitbang: limit SWD WAIT retries by timeout\n\nThe bitbang driver kept retrying a SWD command as long as\nthe debugged device had been responding by SWD WAIT.\nIf the DP stalled in WAIT permanently, OpenOCD hanged.\n\nCheck 0.5 sec timeout in WAIT retry loop.\n\nWhile on it insert a short alive_sleep() if the command\nis retried 20 or more times.\n\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I744e56e21a5a2dc2c4494cc0d7bbcb4be14ddb23\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}