)]}'
{"id":"openocd~master~I3328748c1c3e0661c5ecd6eb070ac519b190ace2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-03-16 14:38:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3328748c1c3e0661c5ecd6eb070ac519b190ace2","subject":"target/adi_v5_swd: fix DP registers banking","status":"MERGED","created":"2024-02-17 13:07:11.000000000","updated":"2024-03-16 14:38:21.000000000","submitted":"2024-03-16 14:38:21.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8154","meta_rev_id":"3b5e265eb33da0d431307613932962faa3362ce8","_number":8154,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-16 14:38:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-16 14:38:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-17 14:40:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-26 22:40:52.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ad3f8dd9e4fc805af1c37a777db90171d853dd2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-17 13:07:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2909c683000f614f367783524564001f29a6a539","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-17 14:40:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19359/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18521/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"228c2afe42808528ec88851a223f24944f841928","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-26 22:40:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6249b42687de416c515661482d35021a39669692","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 14:38:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3b5e265eb33da0d431307613932962faa3362ce8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 14:38:21.000000000","message":"Change has been successfully cherry-picked as 4c0a2cf42ea0a0b48a948be1ff825629265bbf21","accounts_in_message":[],"_revision_number":2}],"current_revision":"4c0a2cf42ea0a0b48a948be1ff825629265bbf21","revisions":{"4c0a2cf42ea0a0b48a948be1ff825629265bbf21":{"kind":"REWORK","_number":2,"created":"2024-03-16 14:38:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/8154/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/8154/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/2 \u0026\u0026 git checkout -b change-8154 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/8154/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"31af18e9d1807d442885d0254ff5b13a66ea3a65","subject":"jtag/drivers/bitbang: limit SWD WAIT retries by timeout"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-02-15 09:05:21.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-16 14:38:21.000000000","tz":0},"subject":"target/adi_v5_swd: fix DP registers banking","message":"target/adi_v5_swd: fix DP registers banking\n\nADIv6 brought more complicated rules for DP reg 0 banking.\nNeither the original implementation [1] nor the later\nmodification [2] respected that the DP reg 0 is banked\nfor read only, not for write. Enforcing of an useless\nSELECT write before a write to ABORT register may trigger\nFAULT (CTRL/STAT bits ORUNDETECT and STICKYORUN are set)\nor WAIT (DP is stalled by an outstanding previous operation)\nand therefore make ABORT register virtually unusable\non some adapters (bitbang, CMSIS-DAP).\n\nThere are DP ABORT specific functions swd_queue_ap_abort()\nand swd_clear_sticky_errors() which worked around the problem\nusing the lowest level swd-\u003ewrite_reg(). Using a specific\nwrite procedure for a single DP register was error prone\n(there are other DP_ABORT writes using swd_queue_dp_write_inner())\nand also the Tcl command \u0027xx.dap dpreg 0 value\u0027 suffered\nfrom unwanted SELECT write.\n\nOther smaller discords in DP banking probably do not\ninfluence normal DP operation however they may complicate\ndebugging in corner cases.\n\nAdhere strictly to the DP banking rules for both ADI versions.\n\nFixes: [1] commit 72fb88613f02 (\"adiv6: add low level swd transport\")\nFixes: [2] commit ee3fb5a0eacb (\"target/arm_adi_v5: fix DP SELECT logic\")\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I3328748c1c3e0661c5ecd6eb070ac519b190ace2\nReviewed-on: https://review.openocd.org/c/openocd/+/8154\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e7a1fa37bc19b1fdf233ac9f8557b5801fefc86f":{"kind":"REWORK","_number":1,"created":"2024-02-17 13:07:11.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/54/8154/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/8154/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/1 \u0026\u0026 git checkout -b change-8154 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/8154/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/8154/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7145b984a9852a0494e2e63df2f61aa36f877377","subject":"portability fix: Switch binary literals to hex"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-02-15 09:05:21.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-02-17 13:03:42.000000000","tz":60},"subject":"target/adi_v5_swd: fix DP registers banking","message":"target/adi_v5_swd: fix DP registers banking\n\nADIv6 brought more complicated rules for DP reg 0 banking.\nNeither the original implementation [1] nor the later\nmodification [2] respected that the DP reg 0 is banked\nfor read only, not for write. Enforcing of an useless\nSELECT write before a write to ABORT register may trigger\nFAULT (CTRL/STAT bits ORUNDETECT and STICKYORUN are set)\nor WAIT (DP is stalled by an outstanding previous operation)\nand therefore make ABORT register virtually unusable\non some adapters (bitbang, CMSIS-DAP).\n\nThere are DP ABORT specific functions swd_queue_ap_abort()\nand swd_clear_sticky_errors() which worked around the problem\nusing the lowest level swd-\u003ewrite_reg(). Using a specific\nwrite procedure for a single DP register was error prone\n(there are other DP_ABORT writes using swd_queue_dp_write_inner())\nand also the Tcl command \u0027xx.dap dpreg 0 value\u0027 suffered\nfrom unwanted SELECT write.\n\nOther smaller discords in DP banking probably do not\ninfluence normal DP operation however they may complicate\ndebugging in corner cases.\n\nAdhere strictly to the DP banking rules for both ADI versions.\n\nFixes: [1] commit 72fb88613f02 (\"adiv6: add low level swd transport\")\nFixes: [2] commit ee3fb5a0eacb (\"target/arm_adi_v5: fix DP SELECT logic\")\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: I3328748c1c3e0661c5ecd6eb070ac519b190ace2\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}