)]}'
{"id":"openocd~master~I1c4e274c06147683db2a59a8920ae5ccd863e15c","project":"openocd","branch":"master","hashtags":[],"change_id":"I1c4e274c06147683db2a59a8920ae5ccd863e15c","subject":"mem_ap: fix GDB connections","status":"MERGED","created":"2024-02-25 13:01:43.000000000","updated":"2024-03-09 11:03:49.000000000","submitted":"2024-03-09 11:03:49.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8163","meta_rev_id":"f21d337bacb32710f1337220ca834f11e4d35a1f","_number":8163,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-09 11:03:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-09 11:03:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-25 13:16:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"78107364da26a4242e36f13182e021e61de5fc9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-25 13:01:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e97c899337386aec38178223836707ccb803d3d7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-25 13:16:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19392/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18553/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fd8d9651d62358f9d53daf2ea2bf5586f061877f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-25 17:23:20.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e9a504167c5f9c9d23de3e6cf2f7d0c41ef34ab7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 11:03:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f21d337bacb32710f1337220ca834f11e4d35a1f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 11:03:49.000000000","message":"Change has been successfully cherry-picked as 5c395fdef42a5750852ea0fc0abd944cf303a39b","accounts_in_message":[],"_revision_number":2}],"current_revision":"5c395fdef42a5750852ea0fc0abd944cf303a39b","revisions":{"b157c9bb0e2158775f1cc136d5f6494c932dbb57":{"kind":"REWORK","_number":1,"created":"2024-02-25 13:01:43.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/8163/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/8163/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/1 \u0026\u0026 git checkout -b change-8163 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/8163/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"179169268ca1bbac092324f597fbea090d75355e","subject":"jtag/commands: fixed buffer overflow"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-25 11:22:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-25 11:32:05.000000000","tz":60},"subject":"mem_ap: fix GDB connections","message":"mem_ap: fix GDB connections\n\nAfter commit d9b2607ca094 (\"gdb_server: support sparse register\nmaps\"), GDB crashes while requesting the value of \u0027cpsr\u0027 because\nthe fake register is tagged as not existing.\n\nChange the logic and set all register as existing, while still\nlimiting the list for the initial GDB request at connect.\n\nChange-Id: I1c4e274c06147683db2a59a8920ae5ccd863e15c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5c395fdef42a5750852ea0fc0abd944cf303a39b":{"kind":"REWORK","_number":2,"created":"2024-03-09 11:03:49.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/8163/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/8163/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/2 \u0026\u0026 git checkout -b change-8163 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/8163/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/8163/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"61e19349b2b83f844e9729a76ad5698e6c77c686","subject":"flash/nor/nrf5: use BIT() instead of \u003c\u003c operator"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-25 11:22:44.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 11:03:49.000000000","tz":0},"subject":"mem_ap: fix GDB connections","message":"mem_ap: fix GDB connections\n\nAfter commit d9b2607ca094 (\"gdb_server: support sparse register\nmaps\"), GDB crashes while requesting the value of \u0027cpsr\u0027 because\nthe fake register is tagged as not existing.\n\nChange the logic and set all register as existing, while still\nlimiting the list for the initial GDB request at connect.\n\nChange-Id: I1c4e274c06147683db2a59a8920ae5ccd863e15c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8163\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
