)]}'
{"id":"openocd~master~I1ea20bf96abb5d2f1fcdba1e3861df257c396bb6","project":"openocd","branch":"master","hashtags":[],"change_id":"I1ea20bf96abb5d2f1fcdba1e3861df257c396bb6","subject":"gdb_server: drop useless check in gdb_keep_client_alive()","status":"MERGED","created":"2024-02-26 17:16:27.000000000","updated":"2024-03-24 13:40:27.000000000","submitted":"2024-03-24 13:40:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8166","meta_rev_id":"7aeb067cc144842b8398e6a96a04388af40bbfed","_number":8166,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-24 13:40:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-24 13:40:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-26 17:31:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5a6022cb654cc7df7adf9210fc674999f28e1a1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-26 17:16:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e0abf754d9d8491214536306af4840cac2c6be4a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-02-26 17:31:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19395/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18556/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"54ceb95226b85d40a74efe5c45e898fb941f0598","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-26 17:53:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"978f91452d74d69a84370814260d7dd35baf6108","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 12:27:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7aeb067cc144842b8398e6a96a04388af40bbfed","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-24 13:40:27.000000000","message":"Change has been successfully cherry-picked as 35e4c4616f5a924313e85290f56f84f7a8534801","accounts_in_message":[],"_revision_number":2}],"current_revision":"35e4c4616f5a924313e85290f56f84f7a8534801","revisions":{"114123ab42f5c6da5f222b45d410a10cd841370d":{"kind":"REWORK","_number":1,"created":"2024-02-26 17:16:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/8166/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8166/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/1 \u0026\u0026 git checkout -b change-8166 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8166/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"40c8db64e10c1eb718d1e3dcfef5ced78a92328c","subject":"gdb_server: add async-notif keep-alive during memory read/write"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-25 22:03:27.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-26 17:14:53.000000000","tz":60},"subject":"gdb_server: drop useless check in gdb_keep_client_alive()","message":"gdb_server: drop useless check in gdb_keep_client_alive()\n\nOpenOCD can send it\u0027s log to gdb, and gdb replies with \u0027OK\u0027.\nCalls to LOG_XXX() are also present in the code that communicates\nwith gdb. This can cause infinite nested calls.\n\nOpenOCD uses the flag \u0027gdb_con-\u003ebusy\u0027 to protect the communication\nwith gdb and prevent nested calls.\n\nThere is no reason to check for \u0027gdb_con-\u003ebusy\u0027 in the code for\nkeep-alive, as keep_alive() is never called in this gdb server;\nthe flag would eventually be set if the current keep_alive() will\nsend something to gdb.\n\nDrop the flag \u0027gdb_con-\u003ebusy\u0027 in gdb_keep_client_alive().\nWhile there, document the use of \u0027gdb_con-\u003ebusy\u0027.\n\nChange-Id: I1ea20bf96abb5d2f1fcdba1e3861df257c396bb6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"35e4c4616f5a924313e85290f56f84f7a8534801":{"kind":"REWORK","_number":2,"created":"2024-03-24 13:40:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/8166/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8166/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/2 \u0026\u0026 git checkout -b change-8166 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8166/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8166/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0c0243228cb958b7c12c2e5a81c84d35734fce25","subject":"gdb_server: add async-notif keep-alive during memory read/write"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-02-25 22:03:27.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-24 13:40:27.000000000","tz":0},"subject":"gdb_server: drop useless check in gdb_keep_client_alive()","message":"gdb_server: drop useless check in gdb_keep_client_alive()\n\nOpenOCD can send it\u0027s log to gdb, and gdb replies with \u0027OK\u0027.\nCalls to LOG_XXX() are also present in the code that communicates\nwith gdb. This can cause infinite nested calls.\n\nOpenOCD uses the flag \u0027gdb_con-\u003ebusy\u0027 to protect the communication\nwith gdb and prevent nested calls.\n\nThere is no reason to check for \u0027gdb_con-\u003ebusy\u0027 in the code for\nkeep-alive, as keep_alive() is never called in this gdb server;\nthe flag would eventually be set if the current keep_alive() will\nsend something to gdb.\n\nDrop the flag \u0027gdb_con-\u003ebusy\u0027 in gdb_keep_client_alive().\nWhile there, document the use of \u0027gdb_con-\u003ebusy\u0027.\n\nChange-Id: I1ea20bf96abb5d2f1fcdba1e3861df257c396bb6\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8166\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}