)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7f074936766270ce3619a85e49ec78fca25072c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9822bcb2_aaf0e16e","updated":"2024-02-28 08:18:02.000000000","message":"Although the message may help in some cases, it could be totally misleading in other cases: on targets where memory is accessible regardless of CPU is running or halted, on errors caused by anything else (communication to adapter, JTAG/SWD transport, target deep sleep etc...)\n\nI would prefer to fix the problem in the target specific code - e.g. cortex_a.c seems to fail correctly with \"not halted\" error message - others should do the same if applicable.","commit_id":"7db933233444f51f54dbe287181bf88e760c016c"},{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"ac5c61c24e10201e3de35c0a001c295e03fd3111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"385dde3e_29b41da5","updated":"2024-02-28 06:44:37.000000000","message":"Note to reviewers: this is a suggestion to improve logging (a little bit) till suggestions from https://review.openocd.org/c/openocd/+/8127 are implemented","commit_id":"7db933233444f51f54dbe287181bf88e760c016c"},{"author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"change_message_id":"d85de770a7564c91f3eec55671f984a4362ede42","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ae082ac_8f14cc58","in_reply_to":"9822bcb2_aaf0e16e","updated":"2024-03-01 05:21:37.000000000","message":"I see... Yeah, as it is probably target-specific part is more appropriate. The thing was that memory read/write for riscv-specific part is a mess and I\u0027ve tried to implement a shortcut. Looks like I\u0027ll just end up doing some plumbing in target-specific code :).\n\nIn any case - thank you for the review. I will discard this patch.","commit_id":"7db933233444f51f54dbe287181bf88e760c016c"}]}
