)]}'
{"id":"openocd~master~Ia6c5b838b9b7208bf1ecac7f95b5efc319aeabf5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-03-16 14:42:17.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ia6c5b838b9b7208bf1ecac7f95b5efc319aeabf5","subject":"openocd: dump full command line in the debug log","status":"MERGED","created":"2024-03-02 13:16:07.000000000","updated":"2024-03-16 14:42:20.000000000","submitted":"2024-03-16 14:42:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8170","meta_rev_id":"3db2bd9c4a68be6e0c279f820ecae5f18774e55a","_number":8170,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-16 14:42:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-16 14:42:20.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-16 14:42:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-02 13:33:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-11 20:40:25.000000000","updated_by":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"}],"messages":[{"id":"e2f28a3196241e2fbe24e92524862e2b5b44c439","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-02 13:16:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"54f14779552014021ba9722acfa7318fd235fb05","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-02 13:33:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19405/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18566/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cd59819a4a3c91eac60c68122c842964358b4786","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-02 17:48:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9219a579d88cdda7ed0d472cebabdc2dcd45762d","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2024-03-11 20:40:25.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cc5fba9a016a42892cfedd74262d326bf340d468","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 14:42:17.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3db2bd9c4a68be6e0c279f820ecae5f18774e55a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 14:42:20.000000000","message":"Change has been successfully cherry-picked as 1d076d6ce1908d5c154bfc6ee2ccd8a629853ef1","accounts_in_message":[],"_revision_number":2}],"current_revision":"1d076d6ce1908d5c154bfc6ee2ccd8a629853ef1","revisions":{"1d076d6ce1908d5c154bfc6ee2ccd8a629853ef1":{"kind":"REWORK","_number":2,"created":"2024-03-16 14:42:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/8170/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8170/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/2 \u0026\u0026 git checkout -b change-8170 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8170/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e9df8a5102106de5a13956759ae52eb72ff68113","subject":"target: aarch64: add support for 32 bit MON mode"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-02 13:01:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-16 14:42:20.000000000","tz":0},"subject":"openocd: dump full command line in the debug log","message":"openocd: dump full command line in the debug log\n\nWhen receiving an OpenOCD debug log to investigate about errors or\nissues, the first question is often about providing the complete\ncommand line to better understand the use context.\nPlus, when OpenOCD is lunched by an IDE, its command line is kept\nhidden inside the IDE, adding troubles to the user to recover it.\n\nAdd the full command line directly inside the debug log.\n\nIt could have been useful to also search and add in the log the\nfull path of the OpenOCD executable, but this is not an immediate\ntask due to portability among OS\u0027s. See, for example:\n\thttps://stackoverflow.com/questions/933850\nThis part could be handled in a future change, if really needed.\n\nChange-Id: Ia6c5b838b9b7208bf1ecac7f95b5efc319aeabf5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8170\nTested-by: jenkins\nReviewed-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}},"28089bca20866e5b812b3c5f60ee273e3d63decf":{"kind":"REWORK","_number":1,"created":"2024-03-02 13:16:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/70/8170/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/70/8170/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/1 \u0026\u0026 git checkout -b change-8170 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/70/8170/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/70/8170/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07141132a7d787005c0829618a60b4a842be7847","subject":"gdb_server: don\u0027t send unrequested ACK at connection"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-02 13:01:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-02 13:14:55.000000000","tz":60},"subject":"openocd: dump full command line in the debug log","message":"openocd: dump full command line in the debug log\n\nWhen receiving an OpenOCD debug log to investigate about errors or\nissues, the first question is often about providing the complete\ncommand line to better understand the use context.\nPlus, when OpenOCD is lunched by an IDE, its command line is kept\nhidden inside the IDE, adding troubles to the user to recover it.\n\nAdd the full command line directly inside the debug log.\n\nIt could have been useful to also search and add in the log the\nfull path of the OpenOCD executable, but this is not an immediate\ntask due to portability among OS\u0027s. See, for example:\n\thttps://stackoverflow.com/questions/933850\nThis part could be handled in a future change, if really needed.\n\nChange-Id: Ia6c5b838b9b7208bf1ecac7f95b5efc319aeabf5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
