)]}'
{"id":"openocd~master~I6d86752c50158f3174c4e8c4add81e9998d01e0e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2024-03-24 13:41:03.000000000","reason":"Change was submitted"},"1002186":{"account":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"last_update":"2024-03-24 13:41:03.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6d86752c50158f3174c4e8c4add81e9998d01e0e","subject":"helper/list: Replace Linux code with FreeBSD one","status":"MERGED","created":"2024-03-09 17:29:54.000000000","updated":"2024-03-24 13:41:03.000000000","submitted":"2024-03-24 13:41:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8172","meta_rev_id":"bf23191e83e98fedacadb08779e611047b060e03","_number":8172,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-24 13:41:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-24 13:41:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-09 17:29:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"state":"REVIEWER"},{"updated":"2024-03-09 17:29:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2024-03-09 18:20:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6b7d21ae057f2e2e4015f5b9768187a05f38680c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 17:29:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d5e7f71ce11d0674da61127349f8ab2920db4ac9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-09 18:20:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19410/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18570/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a4691413db982f22aeff7573e5cc046cfc0de332","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 23:30:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d1a2fe409c0b6c92ef425cc996fc18004fb62a60","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-24 13:40:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bf23191e83e98fedacadb08779e611047b060e03","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-24 13:41:03.000000000","message":"Change has been successfully cherry-picked as a213afad09e50402be8d02298f48757ff4e2e1cf","accounts_in_message":[],"_revision_number":2}],"current_revision":"a213afad09e50402be8d02298f48757ff4e2e1cf","revisions":{"a213afad09e50402be8d02298f48757ff4e2e1cf":{"kind":"REWORK","_number":2,"created":"2024-03-24 13:41:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8172/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8172/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/2 \u0026\u0026 git checkout -b change-8172 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8172/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35e4c4616f5a924313e85290f56f84f7a8534801","subject":"gdb_server: drop useless check in gdb_keep_client_alive()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 16:53:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-24 13:41:03.000000000","tz":0},"subject":"helper/list: Replace Linux code with FreeBSD one","message":"helper/list: Replace Linux code with FreeBSD one\n\nThe file list.h was originally taken from the Linux kernel code,\nthus under license GPL-2.0-only. This locks OpenOCD to follow the\nsame license, even if the majority of OpenOCD files are licensed\nas GPL-2.0-or-later.\n\nA similar file is also present in FreeBSD code base under the more\npermissive license BSD-2-Clause.\n\nDrop the code from Linux kernel and replace it with the code from\nFreeBSD 13.3.0.\nAdapt the code to OpenOCD coding style by fixing the majority of\nissues identified by checkpatch.\nAdd the OpenOCD specific macros and comments.\n\nUnfortunately this causes the lost of all the doxygen comments.\n\nCheckpatch-ignore: MACRO_ARG_REUSE, MACRO_ARG_PRECEDENCE\nChange-Id: I6d86752c50158f3174c4e8c4add81e9998d01e0e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8172\nTested-by: jenkins\n"}},"b1c5338d25a04bb15a1448b1cf6b78f08c402fdf":{"kind":"REWORK","_number":1,"created":"2024-03-09 17:29:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8172/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8172/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/1 \u0026\u0026 git checkout -b change-8172 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8172/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8172/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"561ea48d83ae4b83ff823888a80cbcc282b61333","subject":"target/mips32: add dsp access support"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 16:53:16.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 17:01:51.000000000","tz":60},"subject":"helper/list: Replace Linux code with FreeBSD one","message":"helper/list: Replace Linux code with FreeBSD one\n\nThe file list.h was originally taken from the Linux kernel code,\nthus under license GPL-2.0-only. This locks OpenOCD to follow the\nsame license, even if the majority of OpenOCD files are licensed\nas GPL-2.0-or-later.\n\nA similar file is also present in FreeBSD code base under the more\npermissive license BSD-2-Clause.\n\nDrop the code from Linux kernel and replace it with the code from\nFreeBSD 13.3.0.\nAdapt the code to OpenOCD coding style by fixing the majority of\nissues identified by checkpatch.\nAdd the OpenOCD specific macros and comments.\n\nUnfortunately this causes the lost of all the doxygen comments.\n\nCheckpatch-ignore: MACRO_ARG_REUSE, MACRO_ARG_PRECEDENCE\nChange-Id: I6d86752c50158f3174c4e8c4add81e9998d01e0e\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}