)]}'
{"id":"openocd~master~Idd31b5bf607e226cac44ef41b2aa335ae4dbf519","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2024-03-24 13:41:17.000000000","reason":"Change was submitted"},"1002186":{"account":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"last_update":"2024-03-24 13:41:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idd31b5bf607e226cac44ef41b2aa335ae4dbf519","subject":"helper/list: include the correct header file","status":"MERGED","created":"2024-03-09 17:29:54.000000000","updated":"2024-03-24 13:41:17.000000000","submitted":"2024-03-24 13:41:17.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8173","meta_rev_id":"5b786b42baabf948c608986ba9c24ba71ec08696","_number":8173,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-24 13:41:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-24 13:41:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-09 17:29:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002186,"name":"Walter J.","display_name":"Walter Ji","email":"walter.ji@oss.cipunited.com","username":"709924470","status":"Currently working at CIP United Co., Ltd."},"state":"REVIEWER"},{"updated":"2024-03-09 17:29:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"state":"REVIEWER"},{"updated":"2024-03-09 19:02:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"54afc0736848dfd03f9691e2dd4e6533aacce1e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 17:29:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"da02590cb2086c06971c9f66bf28fad4473d3588","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-09 19:02:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19409/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18571/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6df9601cf565c6d319257749cf897fbcb2d6bf99","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-09 23:30:37.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c6192b97a2e9cc9ce9d8a2a3b12bc060ab993fe9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-24 13:41:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5b786b42baabf948c608986ba9c24ba71ec08696","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-24 13:41:17.000000000","message":"Change has been successfully cherry-picked as c02cf9404dc9dba2a6bc60c4db65c0287168a338","accounts_in_message":[],"_revision_number":2}],"current_revision":"c02cf9404dc9dba2a6bc60c4db65c0287168a338","revisions":{"7fc2abf391cf8697be660ba80b2b8825cd1ccc26":{"kind":"REWORK","_number":1,"created":"2024-03-09 17:29:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/73/8173/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/8173/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/1 \u0026\u0026 git checkout -b change-8173 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/8173/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1c5338d25a04bb15a1448b1cf6b78f08c402fdf","subject":"helper/list: Replace Linux code with FreeBSD one"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 17:12:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 17:12:36.000000000","tz":60},"subject":"helper/list: include the correct header file","message":"helper/list: include the correct header file\n\nThe file \u0027list.h\u0027, copied from FreeBSD, does not depend from any\nOpenOCD specific include file, but only needs \u0027stddef.h\u0027 for the\ntype \u0027size_t\u0027.\n\nLet \u0027list.h\u0027 to include the correct header file, then fix the now\nbroken dependencies in the other files that were incorrectly\nrelying on \u0027list.h\u0027 to include \u0027helper/types.h\u0027\n\nChange-Id: Idd31b5bf607e226cac44ef41b2aa335ae4dbf519\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c02cf9404dc9dba2a6bc60c4db65c0287168a338":{"kind":"REWORK","_number":2,"created":"2024-03-24 13:41:17.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/73/8173/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/73/8173/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/2 \u0026\u0026 git checkout -b change-8173 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/73/8173/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/73/8173/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a213afad09e50402be8d02298f48757ff4e2e1cf","subject":"helper/list: Replace Linux code with FreeBSD one"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-09 17:12:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-24 13:41:17.000000000","tz":0},"subject":"helper/list: include the correct header file","message":"helper/list: include the correct header file\n\nThe file \u0027list.h\u0027, copied from FreeBSD, does not depend from any\nOpenOCD specific include file, but only needs \u0027stddef.h\u0027 for the\ntype \u0027size_t\u0027.\n\nLet \u0027list.h\u0027 to include the correct header file, then fix the now\nbroken dependencies in the other files that were incorrectly\nrelying on \u0027list.h\u0027 to include \u0027helper/types.h\u0027\n\nChange-Id: Idd31b5bf607e226cac44ef41b2aa335ae4dbf519\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8173\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}