)]}'
{"id":"openocd~master~Ife6071c509719f8d7dc312fe9a780bdcf2575f69","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-03-10 17:54:47.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"Ife6071c509719f8d7dc312fe9a780bdcf2575f69","subject":"flash/nor/nrf5: drop useless for cycle condition","status":"MERGED","created":"2024-03-10 11:35:43.000000000","updated":"2024-03-10 17:54:52.000000000","submitted":"2024-03-10 17:54:52.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8174","meta_rev_id":"ebd95b9ad8da58b7dac7cbe98082153cb5af2238","_number":8174,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-10 17:54:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-10 17:54:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-10 11:50:29.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-10 17:07:00.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"f65f7e449d35217f01473e1d67a697e8ad3cba25","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-03-10 11:35:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"55941dd3138744251504eb2ca76af220b99bea89","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-10 11:50:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19411/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18572/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b4e0cb498ae48338c16507024c6934cffd972186","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-10 17:07:00.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"816aed6d1861851b871ee1d41f0d655c4dd6eded","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-03-10 17:54:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ebd95b9ad8da58b7dac7cbe98082153cb5af2238","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-03-10 17:54:52.000000000","message":"Change has been successfully cherry-picked as 12ff36bd19e4f25dd7505c46a77d9f2c47dc350a","accounts_in_message":[],"_revision_number":2}],"current_revision":"12ff36bd19e4f25dd7505c46a77d9f2c47dc350a","revisions":{"12ff36bd19e4f25dd7505c46a77d9f2c47dc350a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-03-10 17:54:52.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/74/8174/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/8174/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/2 \u0026\u0026 git checkout -b change-8174 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/8174/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"561ea48d83ae4b83ff823888a80cbcc282b61333","subject":"target/mips32: add dsp access support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-03-10 11:12:55.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-03-10 17:54:52.000000000","tz":0},"subject":"flash/nor/nrf5: drop useless for cycle condition","message":"flash/nor/nrf5: drop useless for cycle condition\n\nCommit [1] added a break on error to the nrf5_erase() sector loop\nand the checking of the res value became useless in the for loop condition.\n\nRemoving nrf5_get_probed_chip_if_halted() later in [2]\ndropped res initialization and clang static analyser complains\n  \"The left operand of \u0027\u003d\u003d\u0027 is a garbage value\"\n\nDrop the useless test!\n\nFixes: [1] commit 491636c8b832 (\"flash/nor/nrf5: check protection before flash erase/write on nRF51\")\nFixes: [2] commit 2db325f5395f (\"flash/nor/nrf5: drop nrf5_get_probed_chip_if_halted()\")\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ife6071c509719f8d7dc312fe9a780bdcf2575f69\nReviewed-on: https://review.openocd.org/c/openocd/+/8174\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"6e42ed4cb490c6e3f25d1b341c78bf8c1286a568":{"kind":"REWORK","_number":1,"created":"2024-03-10 11:35:43.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/74/8174/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/8174/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/1 \u0026\u0026 git checkout -b change-8174 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/8174/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/8174/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"561ea48d83ae4b83ff823888a80cbcc282b61333","subject":"target/mips32: add dsp access support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-03-10 11:12:55.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2024-03-10 11:34:00.000000000","tz":60},"subject":"flash/nor/nrf5: drop useless for cycle condition","message":"flash/nor/nrf5: drop useless for cycle condition\n\nCommit [1] added a break on error to the nrf5_erase() sector loop\nand the checking of the res value became useless in the for loop condition.\n\nRemoving nrf5_get_probed_chip_if_halted() later in [2]\ndropped res initialization and clang static analyser complains\n  \"The left operand of \u0027\u003d\u003d\u0027 is a garbage value\"\n\nDrop the useless test!\n\nFixes: [1] commit 491636c8b832 (\"flash/nor/nrf5: check protection before flash erase/write on nRF51\")\nFixes: [2] commit 2db325f5395f (\"flash/nor/nrf5: drop nrf5_get_probed_chip_if_halted()\")\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nChange-Id: Ife6071c509719f8d7dc312fe9a780bdcf2575f69\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}