)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Flemming Richter \u003cfrm@emlogic.no\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-13 00:58:50 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tcl/board: Add support for Terasic DE1-SoC"},{"line_number":8,"context_line":"tcl/target: Add support for connecting via the FPGA JTAG chain"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The altera_fpgasoc.cfg assumes that the JTAG connector"},{"line_number":11,"context_line":"is connected to the CPU JTAG, but for Terasic DE1-SoC,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fadd60f2_a6a852c8","line":8,"range":{"start_line":7,"start_character":1,"end_line":8,"end_character":18},"updated":"2024-03-17 16:34:30.000000000","message":"The commit message should start with a single line for the title, followed by an empty line.\nKeep only the first line here\n```\ntcl/board: Add support for Terasic DE1-SoC\n```\nand drop the second or move part of it in the text below.","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7982f47c_b76c215a","updated":"2024-03-17 16:34:30.000000000","message":"Thanks for the patch.\nThere is something redundant in the code; please have a look at it.\nFrom what I understand in this patch, by using a different JTAG port the two TAPs get swapped. Is it correct? Could you report it in a comment in altera_fpgasoc.cfg?","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"}],"tcl/board/terasic-de1-soc.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":true,"context_lines":[{"line_number":12,"context_line":"gdb_memory_map enable"},{"line_number":13,"context_line":"gdb_flash_program enable"},{"line_number":14,"context_line":"gdb_report_data_abort enable"},{"line_number":15,"context_line":"gdb_report_register_access_error enable"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"proc _apu_up {} {"},{"line_number":18,"context_line":"\tset _current_target [target current]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"220015e7_1cbfeb61","line":15,"updated":"2024-03-17 16:34:30.000000000","message":"OpenOCD default is already\n```\ngdb_memory_map enable\ngdb_flash_program enable\n```\nso these two could be dropped.\n\nThe other two are disabled by default, so correct to enable them here.\nFor my curiosity, why you need to enable them? What issue you get that let you require these flags?","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":true,"context_lines":[{"line_number":18,"context_line":"\tset _current_target [target current]"},{"line_number":19,"context_line":"\tset _current_type [${_current_target} cget -type]"},{"line_number":20,"context_line":"\t${_current_target} arp_examine"},{"line_number":21,"context_line":"\tcortex_a smp off"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"echo {Adding post_init_commands}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"81567f29_41f29090","line":21,"updated":"2024-03-17 16:34:30.000000000","message":"This proc looks completely useless:\n- Variable ```_current_type``` is not used. Can be dropped?\n- ```arp_examine``` has sense for targets created with ```-defer-examine```, which is not the case in ```tcl/target/altera_fpgasoc.cfg```.\n- ```smp``` commands are used when ```target smp``` command has been run before init. Again not present here.","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":true,"context_lines":[{"line_number":25,"context_line":"lappend post_init_commands {echo \"OpenOCD successfully initialized\"}"},{"line_number":26,"context_line":"lappend post_init_commands {_apu_up}"},{"line_number":27,"context_line":"lappend post_init_commands {echo \"Configured cores\"}"},{"line_number":28,"context_line":"lappend post_init_commands {fpgasoc.cpu.0 cortex_a smp off}"},{"line_number":29,"context_line":"lappend post_init_commands {fpgasoc.cpu.0 cortex_a dbginit}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"b284a1fd_1544952a","line":28,"updated":"2024-03-17 16:34:30.000000000","message":"This is already executed inside _apu_up and not useful there too. Can be dropped?","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":true,"context_lines":[{"line_number":26,"context_line":"lappend post_init_commands {_apu_up}"},{"line_number":27,"context_line":"lappend post_init_commands {echo \"Configured cores\"}"},{"line_number":28,"context_line":"lappend post_init_commands {fpgasoc.cpu.0 cortex_a smp off}"},{"line_number":29,"context_line":"lappend post_init_commands {fpgasoc.cpu.0 cortex_a dbginit}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"82015253_66f13662","line":29,"updated":"2024-03-17 16:34:30.000000000","message":"The CPU don\u0027t have ```-defer-examine``` so it is examined during init. And the examination already executed the ```dbginit```\nAlso this line is not useful.","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"}],"tcl/target/altera_fpgasoc.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11c6f5565a73d36bc92f269c6f5e88bb232b8c40","unresolved":true,"context_lines":[{"line_number":32,"context_line":"\tjtag newtap $_CHIPNAME.fpga tap -irlen 10 -ircapture 0x01 \\"},{"line_number":33,"context_line":"\t\t     -irmask 0x3 -expected-id $_FPGA_TAPID"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":"# Subsidiary TAP: fpga"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"a3884985_a421ce62","line":35,"updated":"2024-03-17 16:34:30.000000000","message":"this comment here has no meaning anymore. Can be dropped","commit_id":"bd8f69e51ba4e0c760aa95e7c09effe4885530a9"}]}