)]}'
{"id":"openocd~master~I1ec40d070cb8d0d569d3884c9f18fb909b72aa63","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-03-20 10:43:41.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I1ec40d070cb8d0d569d3884c9f18fb909b72aa63","subject":"target/cortex_m: drop check on defer_examine","status":"ABANDONED","created":"2024-03-16 21:43:26.000000000","updated":"2024-03-20 10:43:41.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"54ec86cf731052e48d6f873e8329d84108282438","_number":8177,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2024-03-16 22:32:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":1,"date":"2024-03-16 21:57:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-16 22:32:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-17 18:40:42.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"0ebe02a57da93c89e47630bae51d4068d6d8a2f3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 21:43:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c7097921d25f54fc0c49d22e03b51b004ce42a0f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-16 21:57:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c57fff5acc647e69f913be7b775c9d976b55b699","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-16 22:32:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19416/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18577/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"95e5316b604c9beab2f018798692af60c813e219","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-03-17 18:40:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"54ec86cf731052e48d6f873e8329d84108282438","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-20 10:43:41.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision":"432aa59211cd5274baeaeb157b1b48ac317c52ec","revisions":{"432aa59211cd5274baeaeb157b1b48ac317c52ec":{"kind":"REWORK","_number":1,"created":"2024-03-16 21:43:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/8177/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/8177/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/8177/1 \u0026\u0026 git checkout -b change-8177 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/8177/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/8177/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/8177/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/8177/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/8177/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"894dae1b54c9c581a5d08b44af40dd9a8d45c58a","subject":"target: do not reset targets with -defer-examine flag"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-15 14:14:53.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-16 21:42:02.000000000","tz":60},"subject":"target/cortex_m: drop check on defer_examine","message":"target/cortex_m: drop check on defer_examine\n\nThe callback assert_reset() will never be called on targets that\nhave defer_examine set.\n\nDrop the useless check on defer_examine.\n\nThis modifies the commit f65d1da01356 (\"target/cortex_m: try to\nre-examine under reset in cortex_m_assert_reset()\") and reverts\nthe commit 38616990744b (\"target/cortex_m: prevent asserting reset\nif examine is deferred\").\n\nChange-Id: I1ec40d070cb8d0d569d3884c9f18fb909b72aa63\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}
