)]}'
{"id":"openocd~master~I56ce70f9e18ea55cb4dc2a280e7f81c4f0c7f971","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-04-07 10:23:34.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-04-07 20:17:15.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I56ce70f9e18ea55cb4dc2a280e7f81c4f0c7f971","subject":"checkpatch: allow indentation of 2 TAB in if block","status":"ABANDONED","created":"2024-03-24 22:00:14.000000000","updated":"2024-04-07 20:17:15.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"c752127e59b1629e655a81210905cdb5e6615672","_number":8188,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2024-03-24 22:14:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":-1,"date":"2024-04-07 10:23:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-24 22:14:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-06 12:33:36.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"}],"messages":[{"id":"c4cb0666129e8bc4948a75c47005677fbdcc0959","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-24 22:00:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad5af536b4a2819ba9dac68d4b148a23c6fce77c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-24 22:14:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19435/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18595/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"83b45d624b0170bdf83b3743335b340ee0cb3762","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-04-06 12:33:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8637f01c7e05d2ccf599b4e8dc059face473784c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-07 10:23:34.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c752127e59b1629e655a81210905cdb5e6615672","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-07 20:17:15.000000000","message":"Abandoned\n\npreferred option I56ce70f9e18ea55cb4dc2a280e7f81c4f0c7f971","accounts_in_message":[],"_revision_number":1}],"current_revision":"4fb7bd5a7c35fa452a1a8b5b1e16694f24e264a5","revisions":{"4fb7bd5a7c35fa452a1a8b5b1e16694f24e264a5":{"kind":"REWORK","_number":1,"created":"2024-03-24 22:00:14.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/88/8188/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/8188/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/8188/1 \u0026\u0026 git checkout -b change-8188 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/8188/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/8188/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/8188/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/8188/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/8188/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7032ff8457ae264d29fd7e74e6012bddb1f5a0bb","subject":"jtag: linuxgpiod: drop extra parenthesis"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-24 21:47:52.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-24 21:59:41.000000000","tz":60},"subject":"checkpatch: allow indentation of 2 TAB in if block","message":"checkpatch: allow indentation of 2 TAB in if block\n\nThe coding style of OpenOCD requires indentation by one TAB and\nalso requires TAB to be 4 characters.\nThe indentation of 4 characters has the same length of the string\n\"if (\" and this can make hard to distinguish between the last line\nof a multi-line condition and the first line of the \u0027true\u0027 block.\nE.g.:\n\tif (condition_1 ||\n\t    condition_2) {\n\t    block;\n\t}\n\nA simple way to make the code more readable consists in using two\nTAB indentation in this special case, e.g.:\n\tif (condition_1 ||\n\t    condition_2) {\n\t        block;\n\t}\n\nModify checkpatch script to allow two TAB indentation for the\n\u0027true\u0027 block of a condition.\n\nChange-Id: I56ce70f9e18ea55cb4dc2a280e7f81c4f0c7f971\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}