)]}'
{"id":"openocd~master~I04d2790a33bff9d47eb7f69b3275fd9a271625ae","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002115":{"account":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"last_update":"2024-04-01 09:23:00.000000000","reason":"\u003cGERRIT_ACCOUNT_1002115\u003e replied on the change","reason_account":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"}},"1002210":{"account":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"last_update":"2024-04-01 17:36:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1002210\u003e replied on the change","reason_account":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"}},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-04-01 09:09:08.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002138":{"account":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"last_update":"2024-04-07 19:36:29.000000000","reason":"Change was submitted"},"1002143":{"account":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"last_update":"2024-04-07 19:36:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I04d2790a33bff9d47eb7f69b3275fd9a271625ae","subject":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD","status":"MERGED","created":"2024-03-30 15:50:15.000000000","updated":"2024-04-07 19:36:29.000000000","submitted":"2024-04-07 19:36:29.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8191","meta_rev_id":"44c928439a4b852e5e1425d63da0293e3fb2bf84","_number":8191,"owner":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},{"value":0,"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-07 19:36:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-07 19:36:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-07 19:36:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-07 19:36:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-30 15:52:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-30 17:48:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-04-01 09:09:08.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2024-04-01 09:09:08.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002143,"name":"Marek Vrbka","email":"marek.vrbka@codasip.com","username":"MarekVCodasip"},"state":"REVIEWER"},{"updated":"2024-04-01 09:09:08.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"state":"REVIEWER"},{"updated":"2024-04-01 09:09:08.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"state":"REVIEWER"}],"messages":[{"id":"477605aae8286693b1525a92768fd8421476da06","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"real_author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"date":"2024-03-30 15:50:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3f8309a71dc2d25645df6752f154d894a5d7536d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-30 15:52:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19441/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18602/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"aab969274ac522e3cd8adc890d2fb741848adcb1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"real_author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"date":"2024-03-30 17:00:32.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3e580dee0395b9ba5618ad34bb351c726fd9c026","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-30 17:01:22.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19442/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18603/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"829104ea163178e79f8459a738618995a5eb765a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-30 17:48:48.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d63cbdf3654ac4f1b1fa2716f5d15fc8e7ce78d8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"real_author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"date":"2024-03-30 20:14:42.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"37f1fb88f07c4c6226398990164230b24812718b","author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"real_author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"date":"2024-03-30 20:16:41.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"36ef5b5d8363027cbee855db4f74987d84504941","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-30 20:28:38.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19443/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18604/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"9fe1e4ec9073b827deabf7b981c27a4c8c955ad8","author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"real_author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"date":"2024-03-31 08:05:56.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"570d5718d1a806850e5d491a0f4b695a4fe4dcb4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"real_author":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"date":"2024-03-31 08:13:07.000000000","message":"Uploaded patch set 4: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"5abe13ca999b126540c2f278ef8d0b92bb57b5d1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-03-31 08:25:58.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19450/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18611/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"72fefa9267b09265b7ba94c4d244f6de29be99b3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-01 09:09:08.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"c33add1cfc30ecb7e95b87a5d56444161c77f8cd","author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"real_author":{"_account_id":1002115,"name":"Jeremy Herbert","email":"jeremy.006@gmail.com","username":"jeremyherbert"},"date":"2024-04-01 09:23:00.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a2b606425708e4449b23acdc815803a3ef636c76","author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"real_author":{"_account_id":1002210,"name":"David Ryskalczyk","email":"david.rysk@gmail.com","username":"d235j"},"date":"2024-04-01 17:36:38.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f71b8a0c19ae13114ad47547e45086b71b44aa2f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-07 19:36:25.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"44c928439a4b852e5e1425d63da0293e3fb2bf84","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-07 19:36:29.000000000","message":"Change has been successfully cherry-picked as 79b51fedab9e8023a2e72551c4dcaf4373274287","accounts_in_message":[],"_revision_number":5}],"current_revision":"79b51fedab9e8023a2e72551c4dcaf4373274287","revisions":{"fb8d9e6f789d7bfc3483116dc8da6bfa86f06c89":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2024-03-31 08:13:07.000000000","uploader":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"ref":"refs/changes/91/8191/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8191/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/4 \u0026\u0026 git checkout -b change-8191 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8191/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a35e254c5383008cdacf7838a777f7f17af5eeb1","subject":"target/adi_v5_swd: move setting of do_reconnect one level up"}],"author":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 12:18:43.000000000","tz":60},"committer":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-31 08:13:02.000000000","tz":120},"subject":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD","message":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD\n\nIt was noticed that the remote_bitbang protocol has a design issue:\nSWD and sleep commands cannot be implemented at the same time, because\nthey overlap:\n\n - SWD uses d,e,f,g for setting pin state\n - sleep uses d,D for microsecond and millisecond sleep, respectively\n\nThis has previously been reported by Marek Vrbka, but it wasn\u0027t fixed.\n\nThis commit does the following to resolve the issue:\n\n - Change the sleep commands to \u0027Z\u0027 for 1 ms, \u0027z\u0027 for 1 µs\n - Document \u0027D\u0027 and \u0027d\u0027 as deprecated aliases\n - Switch the remote_bitbang driver in OpenOCD to \u0027Z\u0027 and \u0027z\u0027\n\nUnfortunately that\u0027s a breaking change, because existing adapter-side\nimplementations of the protocol will have to implement the new commands\nto keep working with future versions of OpenOCD. Fortunately, the\nremote sleep commands haven\u0027t been part of an OpenOCD release yet,\nwhich should limit the breakage somewhat.\n\nReported-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nLink: https://sourceforge.net/p/openocd/mailman/openocd-devel/thread/670d28d2-75a1-45ec-afe5-541415701d7a%40codasip.com/\nFixes: e8e09b1b5 (\"remote_bitbang: add use_remote_sleep option to send delays to remote\")\nChange-Id: I04d2790a33bff9d47eb7f69b3275fd9a271625ae\nSigned-off-by: J. Neuschäfer \u003cj.neuschaefer@gmx.net\u003e\n"}},"79b51fedab9e8023a2e72551c4dcaf4373274287":{"kind":"REWORK","_number":5,"created":"2024-04-07 19:36:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/8191/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8191/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/5 \u0026\u0026 git checkout -b change-8191 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8191/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e035756b22f96adc95b791aaa01de7a2c11d7f2e","subject":"jtag: linuxgpiod: fix detection for line request bias"}],"author":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 12:18:43.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-07 19:36:29.000000000","tz":0},"subject":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD","message":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD\n\nIt was noticed that the remote_bitbang protocol has a design issue:\nSWD and sleep commands cannot be implemented at the same time, because\nthey overlap:\n\n - SWD uses d,e,f,g for setting pin state\n - sleep uses d,D for microsecond and millisecond sleep, respectively\n\nThis has previously been reported by Marek Vrbka, but it wasn\u0027t fixed.\n\nThis commit does the following to resolve the issue:\n\n - Change the sleep commands to \u0027Z\u0027 for 1 ms, \u0027z\u0027 for 1 µs\n - Document \u0027D\u0027 and \u0027d\u0027 as deprecated aliases\n - Switch the remote_bitbang driver in OpenOCD to \u0027Z\u0027 and \u0027z\u0027\n\nUnfortunately that\u0027s a breaking change, because existing adapter-side\nimplementations of the protocol will have to implement the new commands\nto keep working with future versions of OpenOCD. Fortunately, the\nremote sleep commands haven\u0027t been part of an OpenOCD release yet,\nwhich should limit the breakage somewhat.\n\nReported-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nLink: https://sourceforge.net/p/openocd/mailman/openocd-devel/thread/670d28d2-75a1-45ec-afe5-541415701d7a%40codasip.com/\nFixes: e8e09b1b5 (\"remote_bitbang: add use_remote_sleep option to send delays to remote\")\nChange-Id: I04d2790a33bff9d47eb7f69b3275fd9a271625ae\nSigned-off-by: J. Neuschäfer \u003cj.neuschaefer@gmx.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8191\nReviewed-by: David Ryskalczyk \u003cdavid.rysk@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Jeremy Herbert \u003cjeremy.006@gmail.com\u003e\n"}},"2c9004b08ca82e0a8ade337318232168041772da":{"kind":"REWORK","_number":1,"created":"2024-03-30 15:50:15.000000000","uploader":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"ref":"refs/changes/91/8191/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8191/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/1 \u0026\u0026 git checkout -b change-8191 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8191/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a35e254c5383008cdacf7838a777f7f17af5eeb1","subject":"target/adi_v5_swd: move setting of do_reconnect one level up"}],"author":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 12:18:43.000000000","tz":60},"committer":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 13:26:07.000000000","tz":60},"subject":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD","message":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD\n\nIt was noticed that the remote_bitbang protocol has a design issue:\nSWD and sleep commands cannot be implemented at the same time, because\nthey overlap:\n\n - SWD uses d,e,f,g for setting pin state\n - sleep uses d,D for microsecond and millisecond sleep, respectively\n\nThis has previously been reported by Marek Vrbka[1], but it wasn\u0027t fixed.\n\nThis commit does the following to resolve the issue:\n\n - Change the sleep commands to \u0027Z\u0027 for 1 ms, \u0027z\u0027 for 1 µs\n - Document that \u0027D\u0027 and \u0027d\u0027 as deprecated aliases\n - Switch the remote_bitbang driver in OpenOCD to \u0027Z\u0027 and \u0027z\u0027\n\nUnfortunately that\u0027s a breaking change, because existing adapter-side\nimplementations of the protocol will have to implement the new commands\nto keep working with future versions of OpenOCD. Fortunately, the\nremote sleep commands haven\u0027t been part of an OpenOCD release yet,\nwhich should limit the breakage somewhat.\n\n[1]: https://sourceforge.net/p/openocd/mailman/openocd-devel/thread/670d28d2-75a1-45ec-afe5-541415701d7a%40codasip.com/\n\nFixes: e8e09b1b5 (\"remote_bitbang: add use_remote_sleep option to send delays to remote\")\nChange-Id: I04d2790a33bff9d47eb7f69b3275fd9a271625ae\nSigned-off-by: J. Neuschäfer \u003cj.neuschaefer@gmx.net\u003e\n"}},"b49b123944428cd3124d5faafd00155e4ad67431":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-03-30 17:00:32.000000000","uploader":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"ref":"refs/changes/91/8191/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8191/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/2 \u0026\u0026 git checkout -b change-8191 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8191/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a35e254c5383008cdacf7838a777f7f17af5eeb1","subject":"target/adi_v5_swd: move setting of do_reconnect one level up"}],"author":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 12:18:43.000000000","tz":60},"committer":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 17:00:18.000000000","tz":60},"subject":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD","message":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD\n\nIt was noticed that the remote_bitbang protocol has a design issue:\nSWD and sleep commands cannot be implemented at the same time, because\nthey overlap:\n\n - SWD uses d,e,f,g for setting pin state\n - sleep uses d,D for microsecond and millisecond sleep, respectively\n\nThis has previously been reported by Marek Vrbka, but it wasn\u0027t fixed.\n\nThis commit does the following to resolve the issue:\n\n - Change the sleep commands to \u0027Z\u0027 for 1 ms, \u0027z\u0027 for 1 µs\n - Document that \u0027D\u0027 and \u0027d\u0027 as deprecated aliases\n - Switch the remote_bitbang driver in OpenOCD to \u0027Z\u0027 and \u0027z\u0027\n\nUnfortunately that\u0027s a breaking change, because existing adapter-side\nimplementations of the protocol will have to implement the new commands\nto keep working with future versions of OpenOCD. Fortunately, the\nremote sleep commands haven\u0027t been part of an OpenOCD release yet,\nwhich should limit the breakage somewhat.\n\nReported-by: Marek Vrbka\nLink: https://sourceforge.net/p/openocd/mailman/openocd-devel/thread/670d28d2-75a1-45ec-afe5-541415701d7a%40codasip.com/\nFixes: e8e09b1b5 (\"remote_bitbang: add use_remote_sleep option to send delays to remote\")\nChange-Id: I04d2790a33bff9d47eb7f69b3275fd9a271625ae\nSigned-off-by: J. Neuschäfer \u003cj.neuschaefer@gmx.net\u003e\n"}},"49c4ec021349d8f968a002553335421295abf57d":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-03-30 20:14:42.000000000","uploader":{"_account_id":1002138,"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","username":"neuschaefer"},"ref":"refs/changes/91/8191/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/8191/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/3 \u0026\u0026 git checkout -b change-8191 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/8191/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/8191/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a35e254c5383008cdacf7838a777f7f17af5eeb1","subject":"target/adi_v5_swd: move setting of do_reconnect one level up"}],"author":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 12:18:43.000000000","tz":60},"committer":{"name":"J. Neuschäfer","email":"j.neuschaefer@gmx.net","date":"2024-03-30 20:14:27.000000000","tz":60},"subject":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD","message":"remote_bitbang: Change sleep commands to Zz to avoid conflict with SWD\n\nIt was noticed that the remote_bitbang protocol has a design issue:\nSWD and sleep commands cannot be implemented at the same time, because\nthey overlap:\n\n - SWD uses d,e,f,g for setting pin state\n - sleep uses d,D for microsecond and millisecond sleep, respectively\n\nThis has previously been reported by Marek Vrbka, but it wasn\u0027t fixed.\n\nThis commit does the following to resolve the issue:\n\n - Change the sleep commands to \u0027Z\u0027 for 1 ms, \u0027z\u0027 for 1 µs\n - Document that \u0027D\u0027 and \u0027d\u0027 as deprecated aliases\n - Switch the remote_bitbang driver in OpenOCD to \u0027Z\u0027 and \u0027z\u0027\n\nUnfortunately that\u0027s a breaking change, because existing adapter-side\nimplementations of the protocol will have to implement the new commands\nto keep working with future versions of OpenOCD. Fortunately, the\nremote sleep commands haven\u0027t been part of an OpenOCD release yet,\nwhich should limit the breakage somewhat.\n\nReported-by: Marek Vrbka \u003cmarek.vrbka@codasip.com\u003e\nLink: https://sourceforge.net/p/openocd/mailman/openocd-devel/thread/670d28d2-75a1-45ec-afe5-541415701d7a%40codasip.com/\nFixes: e8e09b1b5 (\"remote_bitbang: add use_remote_sleep option to send delays to remote\")\nChange-Id: I04d2790a33bff9d47eb7f69b3275fd9a271625ae\nSigned-off-by: J. Neuschäfer \u003cj.neuschaefer@gmx.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}