)]}'
{"id":"openocd~master~Iab026e7da8d6b8ba052514c3fd3b5cdfe301f330","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-04-09 08:45:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-04-06 03:14:41.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"hashtags":[],"change_id":"Iab026e7da8d6b8ba052514c3fd3b5cdfe301f330","subject":"target: cortex_m: fix display of DWT registers","status":"MERGED","created":"2024-04-05 22:45:35.000000000","updated":"2024-05-04 08:24:27.000000000","submitted":"2024-05-04 08:24:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8198","meta_rev_id":"69d88a75b48401355f597f03b1b6086b32301aab","_number":8198,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-04 08:24:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-04 08:24:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-04 08:24:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-05 22:58:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-05 23:01:00.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"c467e410d5b3148251f0e8ca8b2fd4c3e373205a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-05 22:45:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fb1d3199206cd2b4ab6cc9761ce788b0c0ad883e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-04-05 22:58:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19461/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18622/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b0cad0e896eeae3a1243d26bd13490a289630f6d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-05 23:01:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bb5e84c4dd4c0cfd50e6f22b5910b731fa7a46f1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-05 23:16:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c86d928e7d66193c47c869db17a5006d7fa5f199","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-04-06 03:14:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c893cc394ce2e0eaef800c3eac1c90eb89ee0a9d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-07 21:09:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7cc581573aa3a27283fc1d5fa82f33862033c6f3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-04-08 04:56:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c5a4451ca0071ae3a460d75893f82d00ec31ace0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-08 14:11:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"975bb9df7e1069f811f0a46122f365cca8bf2d35","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-04-09 05:38:43.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2e5b4ca3d5b3f4515715d23697a1a427d20b4fcc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-09 08:45:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"711e996fe6c907c63c5c6723291f0105ad9246ff","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 08:24:20.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"69d88a75b48401355f597f03b1b6086b32301aab","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 08:24:27.000000000","message":"Change has been successfully cherry-picked as ac6b00c3cae5def9c1b3f08fae68703abc494109","accounts_in_message":[],"_revision_number":2}],"current_revision":"ac6b00c3cae5def9c1b3f08fae68703abc494109","revisions":{"05296eba04f9bc661d0640012168ab94a26bb15c":{"kind":"REWORK","_number":1,"created":"2024-04-05 22:45:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/98/8198/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/8198/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/1 \u0026\u0026 git checkout -b change-8198 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/8198/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd1758272276e20d5b60c16146a820ec8b5bfaa1","subject":"flash/nor/eneispif: support ENE KB1200 ispi flash"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-05 22:26:38.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-05 22:43:42.000000000","tz":120},"subject":"target: cortex_m: fix display of DWT registers","message":"target: cortex_m: fix display of DWT registers\n\nCommit 16b4b8cf5453 (\"Cortex-M3: expose most DWT registers\") added\nthe DWT registers to the list of CPU registers.\nThe commit message from 2009 reports the reason behind this odd\nmixing of CPU and DWT registers.\nThis feature got broken in 2017 with the introduction of the field\nstruct reg::exist and its further use in the code. As result, the\ncommand \u0027reg\u0027 on a target Cortex-M reports only the core registers\nand then the header line\n\t\u003d\u003d\u003d\u003d\u003d Cortex-M DWT registers\nnot anymore followed by the DWT registers.\n\nFix it by tagging each DWT registers as existing.\n\nChange-Id: Iab026e7da8d6b8ba052514c3fd3b5cdfe301f330\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: b5964191f0d2 (\"register: support non-existent registers\")\n"}},"ac6b00c3cae5def9c1b3f08fae68703abc494109":{"kind":"REWORK","_number":2,"created":"2024-05-04 08:24:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/98/8198/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/8198/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/2 \u0026\u0026 git checkout -b change-8198 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/8198/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/8198/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a9e8ca55a6f44cf6edef7ea5ca66927fa02f3cca","subject":"jtag: linuxgpiod: minor alignment to coding style"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-05 22:26:38.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 08:24:27.000000000","tz":0},"subject":"target: cortex_m: fix display of DWT registers","message":"target: cortex_m: fix display of DWT registers\n\nCommit 16b4b8cf5453 (\"Cortex-M3: expose most DWT registers\") added\nthe DWT registers to the list of CPU registers.\nThe commit message from 2009 reports the reason behind this odd\nmixing of CPU and DWT registers.\nThis feature got broken in 2017 with the introduction of the field\nstruct reg::exist and its further use in the code. As result, the\ncommand \u0027reg\u0027 on a target Cortex-M reports only the core registers\nand then the header line\n\t\u003d\u003d\u003d\u003d\u003d Cortex-M DWT registers\nnot anymore followed by the DWT registers.\n\nFix it by tagging each DWT registers as existing.\n\nChange-Id: Iab026e7da8d6b8ba052514c3fd3b5cdfe301f330\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: b5964191f0d2 (\"register: support non-existent registers\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8198\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}