)]}'
{"id":"openocd~master~I81ae782ddce07431d5f2c1bea3e2f19dfcd6d1ce","project":"openocd","branch":"master","hashtags":[],"change_id":"I81ae782ddce07431d5f2c1bea3e2f19dfcd6d1ce","subject":"target: cortex_a: fix regs invalidation when -defer-examine","status":"MERGED","created":"2024-04-15 16:54:06.000000000","updated":"2024-05-04 08:35:00.000000000","submitted":"2024-05-04 08:35:00.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8215","meta_rev_id":"98cdf7c262a2578e69a64503dce9803225d7e42e","_number":8215,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-04 08:35:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-04 08:35:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-15 17:23:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"69470763ebe7af87e3ba88dcc571d26848421de4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-04-15 16:54:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b1e5533c213ea9e0fa3611efd5dbac7aaf15ddc0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-04-15 17:23:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19483/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18642/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8333386b2e28b2ba5ca97fccdb488d1822df515b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 08:34:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"98cdf7c262a2578e69a64503dce9803225d7e42e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 08:35:00.000000000","message":"Change has been successfully cherry-picked as c72afedce794a7251fd9c822e3bfc89f870b9fc1","accounts_in_message":[],"_revision_number":2}],"current_revision":"c72afedce794a7251fd9c822e3bfc89f870b9fc1","revisions":{"c72afedce794a7251fd9c822e3bfc89f870b9fc1":{"kind":"REWORK","_number":2,"created":"2024-05-04 08:35:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/8215/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8215/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/2 \u0026\u0026 git checkout -b change-8215 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8215/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"42e31d75b443e369597669b5ff7901de902ad35e","subject":"target: aarch64: fix regs invalidation when -defer-examine"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-13 16:54:12.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 08:35:00.000000000","tz":0},"subject":"target: cortex_a: fix regs invalidation when -defer-examine","message":"target: cortex_a: fix regs invalidation when -defer-examine\n\nThe code for cortex_a allocates the register cache during the very\nfirst examine of the target.\nTo prevent a segmentation fault in assert_reset(), the call to\nregister_cache_invalidate() is guarded by target_was_examined().\n\nBut for targets with -defer-examine, the target is set as not\nexamined in handle_target_reset() just before entering in\nassert_reset().\n\nThis causes registers to not be invalidated while reset a target\nexamined but with -defer-examine.\n\nChange the condition and invalidate the register cache if it has\nbeen already allocated.\n\nChange-Id: I81ae782ddce07431d5f2c1bea3e2f19dfcd6d1ce\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8215\nTested-by: jenkins\n"}},"a43eac24bbf9d509ac09ca393d0e93ebb014872c":{"kind":"REWORK","_number":1,"created":"2024-04-15 16:54:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/8215/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/8215/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/1 \u0026\u0026 git checkout -b change-8215 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/8215/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/8215/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2bb8590f0877dc4998208613db90901590e489d1","subject":"target: aarch64: fix regs invalidation when -defer-examine"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-13 16:54:12.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-15 16:51:45.000000000","tz":120},"subject":"target: cortex_a: fix regs invalidation when -defer-examine","message":"target: cortex_a: fix regs invalidation when -defer-examine\n\nThe code for cortex_a allocates the register cache during the very\nfirst examine of the target.\nTo prevent a segmentation fault in assert_reset(), the call to\nregister_cache_invalidate() is guarded by target_was_examined().\n\nBut for targets with -defer-examine, the target is set as not\nexamined in handle_target_reset() just before entering in\nassert_reset().\n\nThis causes registers to not be invalidated while reset a target\nexamined but with -defer-examine.\n\nChange the condition and invalidate the register cache if it has\nbeen already allocated.\n\nChange-Id: I81ae782ddce07431d5f2c1bea3e2f19dfcd6d1ce\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}