)]}'
{"id":"openocd~master~If8c1dae9549dd10e2f21d5b896414d47edac9fc2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-05-26 09:53:03.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-08 15:19:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"If8c1dae9549dd10e2f21d5b896414d47edac9fc2","subject":"target/arm_tpiu_swo: Fix division by zero","status":"MERGED","created":"2024-04-30 19:33:23.000000000","updated":"2024-05-26 09:53:03.000000000","submitted":"2024-05-26 09:53:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8224","meta_rev_id":"608b1650891b78138b366938820bfd5c575887cc","_number":8224,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 09:53:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-26 09:53:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-30 19:58:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-04 09:32:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"537fd7b64dc47e63b204c874ec4f14e4b5e2b2e6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-04-30 19:33:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"77d10916337bbc262819b434ebb6b05a876fe9d4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-04-30 19:58:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19519/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18679/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"16c78a7ab283ae7c7e4710fa03bed12cbdfafa07","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 09:32:54.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"14e090b481c7e7c9e3b85cd5c2928ad9cdb62d38","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-06 19:59:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ec95d1dfc3084c001a75a2695f50e14d7122f422","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-07 06:25:45.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"441d78132c8b05839b10e29748b10182aa0d661a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-07 06:41:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19535/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18694/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"855709bf2bc95ae347f09b99a387f67b1022676c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-08 13:02:10.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"49a89928bc745ce01170c7a229cf10ab4468b7d4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-08 13:48:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19542/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18704/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"1451acd8658a0cc3092de39a30c576c6d3dc6ab4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-08 15:19:38.000000000","message":"Patch Set 3: Code-Review+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7a1e82e416f631ba6c531b5d7022a94a40228706","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:52:59.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"608b1650891b78138b366938820bfd5c575887cc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:53:03.000000000","message":"Change has been successfully cherry-picked as 2506ccb5091504fa50bc71979852701a74246f06","accounts_in_message":[],"_revision_number":4}],"current_revision":"2506ccb5091504fa50bc71979852701a74246f06","revisions":{"2c9c2bdf790fc5a34b43b381be5ba16f37504665":{"kind":"REWORK","_number":1,"created":"2024-04-30 19:33:23.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/24/8224/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8224/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/1 \u0026\u0026 git checkout -b change-8224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8224/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"04154af5d6cd5fe76a2583778379bdacb5aa6fb0","subject":"jtag: linuxgpiod: drop extra parenthesis"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-04-28 10:47:42.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-04-30 19:33:03.000000000","tz":120},"subject":"target/arm_tpiu_swo: Fix division by zero","message":"target/arm_tpiu_swo: Fix division by zero\n\nWhen external capturing is configured (default), the SWO pin frequency\nis required. Enforce this to avoid a division by zero error.\n\nWhile at it, ensure that the \u0027out_filename\u0027 variable always contains a\nvalid string. This saves a few checks and makes the code more clean and\nreadable.\n\nChange-Id: If8c1dae9549dd10e2f21d5b896414d47edac9fc2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"dbc09ae4bd16b72c45251893194c8546134697ac":{"kind":"REWORK","_number":2,"created":"2024-05-07 06:25:45.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/24/8224/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8224/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/2 \u0026\u0026 git checkout -b change-8224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8224/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"04154af5d6cd5fe76a2583778379bdacb5aa6fb0","subject":"jtag: linuxgpiod: drop extra parenthesis"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-04-28 10:47:42.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-07 06:22:31.000000000","tz":120},"subject":"target/arm_tpiu_swo: Fix division by zero","message":"target/arm_tpiu_swo: Fix division by zero\n\nWhen external capturing is configured (default), the SWO pin frequency\nis required. Enforce this to avoid a division by zero error.\n\nWhile at it, ensure that the \u0027out_filename\u0027 variable always contains a\nvalid string. This saves a few checks and makes the code more clean and\nreadable.\n\nChange-Id: If8c1dae9549dd10e2f21d5b896414d47edac9fc2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"1c7785aac73a9e2aabc85f2ea3c9f3485285d866":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-05-08 13:02:10.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/24/8224/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8224/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/3 \u0026\u0026 git checkout -b change-8224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8224/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc9ca5f4a82ccbbdbe07108a83f7979b53e89889","subject":"ipdbg: fix double free of virtual-ir data"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-04-28 10:47:42.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-08 13:01:56.000000000","tz":120},"subject":"target/arm_tpiu_swo: Fix division by zero","message":"target/arm_tpiu_swo: Fix division by zero\n\nWhen external capturing is configured (default), the SWO pin frequency\nis required. Enforce this to avoid a division by zero error.\n\nWhile at it, ensure that the \u0027out_filename\u0027 variable always contains a\nvalid string. This saves a few checks and makes the code more clean and\nreadable.\n\nChange-Id: If8c1dae9549dd10e2f21d5b896414d47edac9fc2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"2506ccb5091504fa50bc71979852701a74246f06":{"kind":"REWORK","_number":4,"created":"2024-05-26 09:53:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/24/8224/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/24/8224/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/4 \u0026\u0026 git checkout -b change-8224 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/24/8224/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/24/8224/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-04-28 10:47:42.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 09:53:03.000000000","tz":0},"subject":"target/arm_tpiu_swo: Fix division by zero","message":"target/arm_tpiu_swo: Fix division by zero\n\nWhen external capturing is configured (default), the SWO pin frequency\nis required. Enforce this to avoid a division by zero error.\n\nWhile at it, ensure that the \u0027out_filename\u0027 variable always contains a\nvalid string. This saves a few checks and makes the code more clean and\nreadable.\n\nChange-Id: If8c1dae9549dd10e2f21d5b896414d47edac9fc2\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8224\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}