)]}'
{"id":"openocd~master~Ie65c92f259f92502e688914f334655b635874179","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-15 16:10:47.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2024-06-08 08:38:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie65c92f259f92502e688914f334655b635874179","subject":"server: gdb: respect command gdb_report_register_access_error","status":"MERGED","created":"2024-05-04 16:50:55.000000000","updated":"2024-06-08 08:38:26.000000000","submitted":"2024-06-08 08:38:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8228","meta_rev_id":"9a015baa670c37b483a84d1d37eee9faacb9f9c8","_number":8228,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:38:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-08 08:38:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-04 16:50:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2024-05-04 17:07:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b63e7bdf29dd9c7a404b26f82d6dfb8474e92816","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 16:50:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"264cdbc535ae9c543d6e4b66eaae37ca4a1b174c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-04 17:07:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19525/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18685/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0e6963682d8754a462b940b41afe6cbf1affdc43","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-06 13:41:21.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2a5fba8ceb8fad1b90286f4a33cd1bec56591792","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-05-07 10:18:37.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ba26409087e6b607bc0a12bd7fb4b8281c155f45","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-11 08:22:22.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ef0947fa6e4dd6e2c318359e7e42e9c908e5c516","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2024-05-15 13:41:23.000000000","message":"Patch Set 1: Code-Review+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"dcf8499c67375643cf7e476876eea7b0a2e31994","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-15 15:51:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f81a35fea91205fe7da236e7c3855b892e8d16c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-15 16:10:28.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9b7b97bf1e6a3d61935989b90c723a7dc7a5c9f7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-15 16:10:47.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"02fc40398a48fb5c93ca9f751625902c983d331f","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-15 16:22:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19571/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18731/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c325e986192aa16625b458ba3649607b5f78e498","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:38:20.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9a015baa670c37b483a84d1d37eee9faacb9f9c8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:38:26.000000000","message":"Change has been successfully cherry-picked as 71013521d7b195022616284aabc5e072a60c52bf","accounts_in_message":[],"_revision_number":3}],"current_revision":"71013521d7b195022616284aabc5e072a60c52bf","revisions":{"b833d13491f28561872aca59a497ea65a06656a4":{"kind":"REWORK","_number":1,"created":"2024-05-04 16:50:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8228/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8228/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/1 \u0026\u0026 git checkout -b change-8228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8228/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc9ca5f4a82ccbbdbe07108a83f7979b53e89889","subject":"ipdbg: fix double free of virtual-ir data"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-03 21:04:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 16:49:48.000000000","tz":120},"subject":"server: gdb: respect command gdb_report_register_access_error","message":"server: gdb: respect command gdb_report_register_access_error\n\nCommit 236c54c94a53 (\"server/gdb_server.c: support unavailable\nregisters\") correctly returns a string of \u0027x\u0027 when the register is\nnot available in the current target.\n\nWhile implementing this, it incorrectly drops the pre-existing\nfeature of optionally ignoring errors while reading a register.\n\nRe-add the check on \u0027gdb_report_register_access_error\u0027 to keep the\npre-existing behavior when a register error has to be ignored:\n- return a string of \u00270\u0027;\n- drop a debug message.\n\nChange-Id: Ie65c92f259f92502e688914f334655b635874179\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 236c54c94a53 (\"server/gdb_server.c: support unavailable registers\")\n"}},"71013521d7b195022616284aabc5e072a60c52bf":{"kind":"REWORK","_number":3,"created":"2024-06-08 08:38:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8228/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8228/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/3 \u0026\u0026 git checkout -b change-8228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8228/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"437dde701c13e707e5fd912ef6403e09052e4d9b","subject":"Documentation: fix warning \"unbalanced square brackets\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-03 21:04:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-08 08:38:26.000000000","tz":0},"subject":"server: gdb: respect command gdb_report_register_access_error","message":"server: gdb: respect command gdb_report_register_access_error\n\nCommit 236c54c94a53 (\"server/gdb_server.c: support unavailable\nregisters\") correctly returns a string of \u0027x\u0027 when the register is\nnot available in the current target.\n\nWhile implementing this, it incorrectly drops the pre-existing\nfeature of optionally ignoring errors while reading a register.\nThis feature has a real use case documented in the OpenOCD manual\nin chapter \u0027Using GDB as a non-intrusive memory inspector\u0027, where\nGDB attaches to a target without halting it. For targets that need\nto be halted to read its registers, we need to hack the values of\nthe registers returned to GDB; either returning \u0027xxxx\u0027 or an error\ncauses GDB to drop the connection.\n\nRe-add the check on \u0027gdb_report_register_access_error\u0027 to keep the\npre-existing behavior when a register error has to be ignored:\n- return a string of \u00270\u0027;\n- drop a debug message.\n\nChange-Id: Ie65c92f259f92502e688914f334655b635874179\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 236c54c94a53 (\"server/gdb_server.c: support unavailable registers\")\nReviewed-on: https://review.openocd.org/c/openocd/+/8228\nTested-by: jenkins\n"}},"e67f991401c6557df65dad006d0e0b8523a2128d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-15 16:10:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/8228/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/8228/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/2 \u0026\u0026 git checkout -b change-8228 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/8228/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/8228/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc9ca5f4a82ccbbdbe07108a83f7979b53e89889","subject":"ipdbg: fix double free of virtual-ir data"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-03 21:04:46.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-15 16:10:27.000000000","tz":0},"subject":"server: gdb: respect command gdb_report_register_access_error","message":"server: gdb: respect command gdb_report_register_access_error\n\nCommit 236c54c94a53 (\"server/gdb_server.c: support unavailable\nregisters\") correctly returns a string of \u0027x\u0027 when the register is\nnot available in the current target.\n\nWhile implementing this, it incorrectly drops the pre-existing\nfeature of optionally ignoring errors while reading a register.\nThis feature has a real use case documented in the OpenOCD manual\nin chapter \u0027Using GDB as a non-intrusive memory inspector\u0027, where\nGDB attaches to a target without halting it. For targets that need\nto be halted to read its registers, we need to hack the values of\nthe registers returned to GDB; either returning \u0027xxxx\u0027 or an error\ncauses GDB to drop the connection.\n\nRe-add the check on \u0027gdb_report_register_access_error\u0027 to keep the\npre-existing behavior when a register error has to be ignored:\n- return a string of \u00270\u0027;\n- drop a debug message.\n\nChange-Id: Ie65c92f259f92502e688914f334655b635874179\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: 236c54c94a53 (\"server/gdb_server.c: support unavailable registers\")\n"},"description":"Edit commit message"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}