)]}'
{"id":"openocd~master~I0399f1081b08c4929e0795b76f4a686630f41d56","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-11 11:54:40.000000000","reason":"Change was submitted"},"1000410":{"account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"last_update":"2024-05-07 09:00:14.000000000","reason":"\u003cGERRIT_ACCOUNT_1000410\u003e replied on the change","reason_account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}},"hashtags":[],"change_id":"I0399f1081b08c4929e0795b76f4a686630f41d56","subject":"cortex_a: drop the command \u0027cache auto\u0027","status":"MERGED","created":"2024-05-04 18:43:29.000000000","updated":"2024-05-11 11:54:40.000000000","submitted":"2024-05-11 11:54:40.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8230","meta_rev_id":"1d625a128226f2b81ebd8a1adce7781b74021e73","_number":8230,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-11 11:54:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-11 11:54:40.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-11 11:54:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-04 18:43:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2024-05-04 19:18:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"451a23d721856d77b5de3634e21b2354a3e81b38","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 18:43:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3026be9fae3e9835c3e6e10af68eb87aa2cd8a8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-04 19:18:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19527/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18687/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fc63a17cc07063cdef73fa5dbcb1bd0afa99cb02","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-06 13:41:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d4de646b3c7f621ee21b6d17f5c4e73b9ac95ce2","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2024-05-07 09:00:14.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1d625a128226f2b81ebd8a1adce7781b74021e73","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-11 11:54:40.000000000","message":"Change has been successfully cherry-picked as caabdd4a6627a86be43cd91e09f127173eb9e692","accounts_in_message":[],"_revision_number":2}],"current_revision":"caabdd4a6627a86be43cd91e09f127173eb9e692","revisions":{"caabdd4a6627a86be43cd91e09f127173eb9e692":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-11 11:54:40.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/30/8230/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/30/8230/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/2 \u0026\u0026 git checkout -b change-8230 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/30/8230/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbef02789fb1f30ae77020754b1468549fd16510","subject":"cortex_a: drop useless cache invalidate on mem write"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 18:09:51.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-11 11:54:40.000000000","tz":0},"subject":"cortex_a: drop the command \u0027cache auto\u0027","message":"cortex_a: drop the command \u0027cache auto\u0027\n\nThe command \u0027cache auto\u0027 was introduced with commit cd440bd32a12\n(\"add armv7a_cache handlers\") in 2015 to allow disabling the cache\nhandling done automatically by OpenOCD.\nThis was probably a way to test the cache handling when there were\nstill the two independent accesses for APB-AP CPU debug and for\nAHB-AP memory bus.\n\nThe handling of cache for cortex_a is robust and there is no more\nreason to disable it.\nThe command \u0027cache auto\u0027 is not used in any upstream script.\nOn target aarch64 this command has never been introduced as the\ncache is always handled automatically by OpenOCD.\n\nDrop the command \u0027cache auto\u0027 and add it in the deprecated list.\nDrop the flag \u0027auto_cache_enabled\u0027 by considering it as true.\nRename the function \u0027armv7a_cache_auto_flush_all_data()\u0027 as\n\u0027armv7a_cache_flush_all_data()\u0027 and, while there, fix the error\npropagation in SMP case.\n\nChange-Id: I0399f1081b08c4929e0795b76f4a686630f41d56\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8230\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\n"}},"62be729e1d1706b8a6c5619f35bc900bca1cf545":{"kind":"REWORK","_number":1,"created":"2024-05-04 18:43:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/30/8230/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/30/8230/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/1 \u0026\u0026 git checkout -b change-8230 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/30/8230/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/30/8230/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"37f28569f5901f0c971ba1c1a0c119e6fd0d5b21","subject":"cortex_a: drop useless cache invalidate on mem write"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 18:09:51.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 18:38:18.000000000","tz":120},"subject":"cortex_a: drop the command \u0027cache auto\u0027","message":"cortex_a: drop the command \u0027cache auto\u0027\n\nThe command \u0027cache auto\u0027 was introduced with commit cd440bd32a12\n(\"add armv7a_cache handlers\") in 2015 to allow disabling the cache\nhandling done automatically by OpenOCD.\nThis was probably a way to test the cache handling when there were\nstill the two independent accesses for APB-AP CPU debug and for\nAHB-AP memory bus.\n\nThe handling of cache for cortex_a is robust and there is no more\nreason to disable it.\nThe command \u0027cache auto\u0027 is not used in any upstream script.\nOn target aarch64 this command has never been introduced as the\ncache is always handled automatically by OpenOCD.\n\nDrop the command \u0027cache auto\u0027 and add it in the deprecated list.\nDrop the flag \u0027auto_cache_enabled\u0027 by considering it as true.\nRename the function \u0027armv7a_cache_auto_flush_all_data()\u0027 as\n\u0027armv7a_cache_flush_all_data()\u0027 and, while there, fix the error\npropagation in SMP case.\n\nChange-Id: I0399f1081b08c4929e0795b76f4a686630f41d56\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}