)]}'
{"id":"openocd~master~I2f5e9015f0e27fa5a6d8337a1ae25e753e2e1d26","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-11 11:54:51.000000000","reason":"Change was submitted"},"1000410":{"account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"last_update":"2024-05-07 09:01:48.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I2f5e9015f0e27fa5a6d8337a1ae25e753e2e1d26","subject":"cortex_a: drop cortex_a_dap_write_memap_register_u32()","status":"MERGED","created":"2024-05-04 18:43:29.000000000","updated":"2024-05-11 11:54:51.000000000","submitted":"2024-05-11 11:54:51.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8231","meta_rev_id":"6a2c269ab786bfa3eff7cd41c2558d8520dd3116","_number":8231,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-11 11:54:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-11 11:54:51.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-11 11:54:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-04 18:43:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2024-05-04 19:01:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"83b24af1079045c4210a944827599d93127c215d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-04 18:43:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d539d0323ffcbcd6080fbb2f1b3db02ab88955bd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-04 19:01:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19526/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18686/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d708fe7fb935e2d6fac61550a2d11151786860c9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-06 13:41:58.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"79c5cd953a07d3c29f0b49eb8a19bc89ed077953","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2024-05-07 09:01:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6a2c269ab786bfa3eff7cd41c2558d8520dd3116","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-11 11:54:51.000000000","message":"Change has been successfully cherry-picked as 126d8a0972ab6031588eb2f0e1fc3957bd3ccc6b","accounts_in_message":[],"_revision_number":2}],"current_revision":"126d8a0972ab6031588eb2f0e1fc3957bd3ccc6b","revisions":{"126d8a0972ab6031588eb2f0e1fc3957bd3ccc6b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-11 11:54:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/8231/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/8231/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/2 \u0026\u0026 git checkout -b change-8231 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/8231/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"caabdd4a6627a86be43cd91e09f127173eb9e692","subject":"cortex_a: drop the command \u0027cache auto\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 17:13:51.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-11 11:54:51.000000000","tz":0},"subject":"cortex_a: drop cortex_a_dap_write_memap_register_u32()","message":"cortex_a: drop cortex_a_dap_write_memap_register_u32()\n\nHistorically, the function cortex_a_dap_write_memap_register_u32()\nwas used to discriminate the register write in APB-AP CPU debug\nagainst the complex memory access in AHB-AP memory bus.\n\nIt has no sense to keep the function and its comment.\nPlus, by forcing atomic write it impacts the debug performance.\n\nDrop it!\nA further rework to enqueue sequence of atomic writes is needed.\n\nChange-Id: I2f5e9015f0e27fa5a6d8337a1ae25e753e2e1d26\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8231\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\nTested-by: jenkins\n"}},"7673bcb7db1f23ca8d684228a49e1103fd47d906":{"kind":"REWORK","_number":1,"created":"2024-05-04 18:43:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/31/8231/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/31/8231/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/1 \u0026\u0026 git checkout -b change-8231 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/31/8231/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/31/8231/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"62be729e1d1706b8a6c5619f35bc900bca1cf545","subject":"cortex_a: drop the command \u0027cache auto\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 17:13:51.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-04 18:39:11.000000000","tz":120},"subject":"cortex_a: drop cortex_a_dap_write_memap_register_u32()","message":"cortex_a: drop cortex_a_dap_write_memap_register_u32()\n\nHistorically, the function cortex_a_dap_write_memap_register_u32()\nwas used to discriminate the register write in APB-AP CPU debug\nagainst the complex memory access in AHB-AP memory bus.\n\nIt has no sense to keep the function and its comment.\nPlus, by forcing atomic write it impacts the debug performance.\n\nDrop it!\nA further rework to enqueue sequence of atomic writes is needed.\n\nChange-Id: I2f5e9015f0e27fa5a6d8337a1ae25e753e2e1d26\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}