)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"9a796d1a8b528047db2ea0cfca8ffd5a9f6b8eb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a11abe82_ea82046f","updated":"2024-08-19 08:38:00.000000000","message":"Thanks!","commit_id":"64b6827e59de691d6cf355cd8aa968824626d173"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"50332db38e08a34e4b4a91a57a58e0740ca79409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3087bca_9b017393","updated":"2024-08-25 20:46:25.000000000","message":"Incorrect review on my side!\nThank you Tomas","commit_id":"b4626c8244450bdc1637bd8f177cdc43fbffaf10"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"903eb18193e7da5a240c63527495e54ab8ae46aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6157d8a0_a9f1a391","updated":"2024-08-25 17:41:24.000000000","message":"Thanks for the patch.\nWould you mind checking my comment below?","commit_id":"b4626c8244450bdc1637bd8f177cdc43fbffaf10"}],"src/jtag/drivers/cmsis_dap_usb_hid.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e716bc5cc74603f9a91de8bfeb61202107492696","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"\t\t\tif (cur_dev-\u003eserial_number) {"},{"line_number":124,"context_line":"\t\t\t\tsize_t len \u003d mbstowcs(NULL, serial, 0) + 1;"},{"line_number":125,"context_line":"\t\t\t\twchar_t *wserial \u003d malloc(len * sizeof(wchar_t));"},{"line_number":126,"context_line":"\t\t\t\tmbstowcs(wserial, serial, len);"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"\t\t\t\tif (wcscmp(wserial, cur_dev-\u003eserial_number) \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"864818c4_31f98873","line":125,"updated":"2024-08-19 08:42:32.000000000","message":"BTW malloc() return should be checked for NULL - but it isn\u0027t related to your patch.","commit_id":"64b6827e59de691d6cf355cd8aa968824626d173"},{"author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"change_message_id":"6b235d4f49f2035adee21fd5b2c78f1201a74e72","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"\t\t\tif (cur_dev-\u003eserial_number) {"},{"line_number":124,"context_line":"\t\t\t\tsize_t len \u003d mbstowcs(NULL, serial, 0) + 1;"},{"line_number":125,"context_line":"\t\t\t\twchar_t *wserial \u003d malloc(len * sizeof(wchar_t));"},{"line_number":126,"context_line":"\t\t\t\tmbstowcs(wserial, serial, len);"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"\t\t\t\tif (wcscmp(wserial, cur_dev-\u003eserial_number) \u003d\u003d 0) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"13a6e298_64619019","line":125,"in_reply_to":"864818c4_31f98873","updated":"2024-08-20 14:24:18.000000000","message":"Thank you for your review. I\u0027ve pushed an updated patch adding a NULL check as well","commit_id":"64b6827e59de691d6cf355cd8aa968824626d173"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"012727da95fbd0fe88af92802f023168e7e3054d","unresolved":true,"context_lines":[{"line_number":121,"context_line":"\t\t\t\tbreak;"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"\t\t\tif (cur_dev-\u003eserial_number) {"},{"line_number":124,"context_line":"\t\t\t\tsize_t len \u003d mbstowcs(NULL, serial, 0) + 1;"},{"line_number":125,"context_line":"\t\t\t\twchar_t *wserial \u003d malloc(len * sizeof(wchar_t));"},{"line_number":126,"context_line":"\t\t\t\tif (!wserial) {"},{"line_number":127,"context_line":"\t\t\t\t\tLOG_ERROR(\"unable to allocate serial number buffer\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"fb5da8a6_04bc83b6","line":124,"range":{"start_line":124,"start_character":42,"end_line":124,"end_character":46},"updated":"2024-08-25 19:57:29.000000000","message":"Antonio, didn\u0027t you missed this + 1 ?","commit_id":"b4626c8244450bdc1637bd8f177cdc43fbffaf10"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"50332db38e08a34e4b4a91a57a58e0740ca79409","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\t\t\t\tbreak;"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"\t\t\tif (cur_dev-\u003eserial_number) {"},{"line_number":124,"context_line":"\t\t\t\tsize_t len \u003d mbstowcs(NULL, serial, 0) + 1;"},{"line_number":125,"context_line":"\t\t\t\twchar_t *wserial \u003d malloc(len * sizeof(wchar_t));"},{"line_number":126,"context_line":"\t\t\t\tif (!wserial) {"},{"line_number":127,"context_line":"\t\t\t\t\tLOG_ERROR(\"unable to allocate serial number buffer\");"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"06e90245_8ba4eb02","line":124,"range":{"start_line":124,"start_character":42,"end_line":124,"end_character":46},"in_reply_to":"fb5da8a6_04bc83b6","updated":"2024-08-25 20:46:25.000000000","message":"you are right! Thanks!","commit_id":"b4626c8244450bdc1637bd8f177cdc43fbffaf10"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"903eb18193e7da5a240c63527495e54ab8ae46aa","unresolved":true,"context_lines":[{"line_number":127,"context_line":"\t\t\t\t\tLOG_ERROR(\"unable to allocate serial number buffer\");"},{"line_number":128,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":129,"context_line":"\t\t\t\t}"},{"line_number":130,"context_line":"\t\t\t\tmbstowcs(wserial, serial, len);"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t\t\t\tif (wcscmp(wserial, cur_dev-\u003eserial_number) \u003d\u003d 0) {"},{"line_number":133,"context_line":"\t\t\t\t\tfree(wserial);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0fb3d59c_7b70eaaa","line":130,"updated":"2024-08-25 17:41:24.000000000","message":"shouldn\u0027t we use `len + 1` here?\nOn Linux `man mbstowcs` reports an example that uses `mbslen + 1` in the equivalent part of this line.","commit_id":"b4626c8244450bdc1637bd8f177cdc43fbffaf10"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"50332db38e08a34e4b4a91a57a58e0740ca79409","unresolved":false,"context_lines":[{"line_number":127,"context_line":"\t\t\t\t\tLOG_ERROR(\"unable to allocate serial number buffer\");"},{"line_number":128,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"},{"line_number":129,"context_line":"\t\t\t\t}"},{"line_number":130,"context_line":"\t\t\t\tmbstowcs(wserial, serial, len);"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t\t\t\tif (wcscmp(wserial, cur_dev-\u003eserial_number) \u003d\u003d 0) {"},{"line_number":133,"context_line":"\t\t\t\t\tfree(wserial);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"44dd6673_7311e4c2","line":130,"in_reply_to":"0fb3d59c_7b70eaaa","updated":"2024-08-25 20:46:25.000000000","message":"missed it above!","commit_id":"b4626c8244450bdc1637bd8f177cdc43fbffaf10"}]}