)]}'
{"id":"openocd~master~I668de6f0acc9b3ec5aca033d870dd9ef354f9077","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002225":{"account":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"last_update":"2024-08-27 09:03:55.000000000","reason":"Removed by \u003cGERRIT_ACCOUNT_1002225\u003e by clicking the attention icon","reason_account":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2024-08-25 04:11:00.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I668de6f0acc9b3ec5aca033d870dd9ef354f9077","subject":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()","status":"MERGED","created":"2024-05-06 09:56:15.000000000","updated":"2024-09-07 11:37:46.000000000","submitted":"2024-09-07 11:37:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8232","meta_rev_id":"662ba9d8877e36dd4532c5a07cd2b4c774ba7589","_number":8232,"owner":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-09-07 11:37:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-07 11:37:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-09-07 11:37:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-06 10:11:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-19 08:38:00.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-08-25 17:41:24.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"2f221f02f444f1ca2393846b624177542e9e570c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"real_author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"date":"2024-05-06 09:56:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a07b4a00014b6dbe53ea3ba6b2a6d7f4e511cab","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-06 10:11:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19530/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18690/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5a715d0aa737dd65afd3a71f54872b416856d996","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"real_author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"date":"2024-08-05 08:16:39.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9f0ccff3d90b1660bbc4fd107830f006f48980c0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-05 08:39:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19856/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19011/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9a796d1a8b528047db2ea0cfca8ffd5a9f6b8eb1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-19 08:38:00.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e716bc5cc74603f9a91de8bfeb61202107492696","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-19 08:42:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7c547b6dd8da09bcf2484676d6395481205c30c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"real_author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"date":"2024-08-20 14:22:31.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6b235d4f49f2035adee21fd5b2c78f1201a74e72","author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"real_author":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"date":"2024-08-20 14:24:18.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"ac55c990556371526c248a32f909094e2d12b340","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-08-20 14:35:25.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19950/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/19105/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"a27bfa60c6531c0ac55f787a620a0d1541adb1ac","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-25 04:11:00.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"903eb18193e7da5a240c63527495e54ab8ae46aa","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 17:41:24.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"012727da95fbd0fe88af92802f023168e7e3054d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-08-25 19:57:29.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"50332db38e08a34e4b4a91a57a58e0740ca79409","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 20:46:25.000000000","message":"Patch Set 3: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"662ba9d8877e36dd4532c5a07cd2b4c774ba7589","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-09-07 11:37:46.000000000","message":"Change has been successfully cherry-picked as e01e180f6248590348bad5c354c6b4e0cf1a956a","accounts_in_message":[],"_revision_number":4}],"current_revision":"e01e180f6248590348bad5c354c6b4e0cf1a956a","revisions":{"64b6827e59de691d6cf355cd8aa968824626d173":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-08-05 08:16:39.000000000","uploader":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"ref":"refs/changes/32/8232/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/8232/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/2 \u0026\u0026 git checkout -b change-8232 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/8232/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9224c0c0f2a3d1ec52aab6ca985d1affa9a18b9","subject":"transport: Remove echo in transport selection"}],"author":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-05-06 09:40:00.000000000","tz":120},"committer":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-08-05 08:15:59.000000000","tz":120},"subject":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()","message":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()\n\nUse mbstowcs() to get required length of wide character string and\ninclude space for terminating null wide character.\n\nChange-Id: I668de6f0acc9b3ec5aca033d870dd9ef354f9077\nSigned-off-by: Marcus Nilsson \u003cbrainbomb@gmail.com\u003e\n"}},"b4626c8244450bdc1637bd8f177cdc43fbffaf10":{"kind":"REWORK","_number":3,"created":"2024-08-20 14:22:31.000000000","uploader":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"ref":"refs/changes/32/8232/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/8232/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/3 \u0026\u0026 git checkout -b change-8232 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/8232/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9224c0c0f2a3d1ec52aab6ca985d1affa9a18b9","subject":"transport: Remove echo in transport selection"}],"author":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-05-06 09:40:00.000000000","tz":120},"committer":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-08-20 14:21:55.000000000","tz":120},"subject":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()","message":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()\n\nUse mbstowcs() to get required length of wide character string and\ninclude space for terminating null wide character.\n\nChange-Id: I668de6f0acc9b3ec5aca033d870dd9ef354f9077\nSigned-off-by: Marcus Nilsson \u003cbrainbomb@gmail.com\u003e\n"}},"8b763a4e48b9620a861307e3869691357305c7b4":{"kind":"REWORK","_number":1,"created":"2024-05-06 09:56:15.000000000","uploader":{"_account_id":1002225,"name":"Marcus Nilsson","username":"metmo"},"ref":"refs/changes/32/8232/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/8232/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/1 \u0026\u0026 git checkout -b change-8232 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/8232/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc9ca5f4a82ccbbdbe07108a83f7979b53e89889","subject":"ipdbg: fix double free of virtual-ir data"}],"author":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-05-06 09:40:00.000000000","tz":120},"committer":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-05-06 09:40:00.000000000","tz":120},"subject":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()","message":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()\n\nUse mbstowcs() to get required length of wide character string and\ninclude space for terminating null wide character.\n\nChange-Id: I668de6f0acc9b3ec5aca033d870dd9ef354f9077\nSigned-off-by: Marcus Nilsson \u003cbrainbomb@gmail.com\u003e\n"}},"e01e180f6248590348bad5c354c6b4e0cf1a956a":{"kind":"REWORK","_number":4,"created":"2024-09-07 11:37:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/32/8232/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/32/8232/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/4 \u0026\u0026 git checkout -b change-8232 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/32/8232/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/32/8232/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4680d6ebdf142f9dd1acdc439d4e146ed36a290b","subject":"binarybuffer: str_to_buf(): align prefix to TCL syntax"}],"author":{"name":"Marcus Nilsson","email":"brainbomb@gmail.com","date":"2024-05-06 09:40:00.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-09-07 11:37:46.000000000","tz":0},"subject":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()","message":"drivers/cmsis_dap: Fix buffer overflow in cmsis_dap_hid_open()\n\nUse mbstowcs() to get required length of wide character string and\ninclude space for terminating null wide character.\n\nChange-Id: I668de6f0acc9b3ec5aca033d870dd9ef354f9077\nSigned-off-by: Marcus Nilsson \u003cbrainbomb@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8232\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}