)]}'
{"id":"openocd~master~I422033e36ca006e38aa4504d491b7947def1237a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-05-26 09:54:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I422033e36ca006e38aa4504d491b7947def1237a","subject":"target/arm_tpiu_swo: Handle errors in pre/post-enable events","status":"MERGED","created":"2024-05-07 06:25:45.000000000","updated":"2024-05-26 09:54:01.000000000","submitted":"2024-05-26 09:54:01.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8254","meta_rev_id":"c7e939cedf00178cec06d6eaef4480c238f944f4","_number":8254,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 09:54:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-26 09:54:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-07 07:26:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-08 15:21:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"45427acd184a1644f45716ad5a44d7cd9513b204","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-07 06:25:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8cc8470a3c32ed9c5c06df8872660057111b4c03","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-07 07:26:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19536/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18697/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"89c39beaa8d0db465bf1052ac2e0fb7d5c38a928","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-08 13:02:10.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a756af89de9da552d422ea6286b1f81a3360b8c3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-08 13:59:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19545/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18705/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"42289f89a04bb83e9020abe7841675d4d6fc9ff7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-08 15:21:35.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"3963f598bd7898fac4dcdd3beeb61886e618a647","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:53:58.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c7e939cedf00178cec06d6eaef4480c238f944f4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:54:01.000000000","message":"Change has been successfully cherry-picked as be1aebd8183c5b6b3bbecfc065a84b7e10bd8f8e","accounts_in_message":[],"_revision_number":3}],"current_revision":"be1aebd8183c5b6b3bbecfc065a84b7e10bd8f8e","revisions":{"dd6fde0a89a17999eaa7fa524ced4b6476505711":{"kind":"REWORK","_number":1,"created":"2024-05-07 06:25:45.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/54/8254/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/8254/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/1 \u0026\u0026 git checkout -b change-8254 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/8254/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0809e4d934461ffc0055bf72e9d26cf81dcab1c2","subject":"server/gdb: Use \u0027bool\u0027 data type where appropriate"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 10:58:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-07 06:22:31.000000000","tz":120},"subject":"target/arm_tpiu_swo: Handle errors in pre/post-enable events","message":"target/arm_tpiu_swo: Handle errors in pre/post-enable events\n\nCurrently, errors in pre/post-enable events are ignored and capturing is\nalways started, even if necessary device configuration fails. This\nbehaviour is confusing to users. Also, the TPIU must be disabled before\nre-configuration is possible.\n\nStart capturing and enable TPIU only if no errors in pre/post-enable\nevents occurred.\n\nChange-Id: I422033e36ca006e38aa4504d491b7947def1237a\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"a4a0c0e6478b902335602e9f268627d52d1eacf9":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-05-08 13:02:10.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/54/8254/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/8254/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/2 \u0026\u0026 git checkout -b change-8254 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/8254/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"62df5f6c35eeafc206a698b1491f14cbdb76b91c","subject":"server/gdb: Use \u0027bool\u0027 data type where appropriate"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 10:58:18.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-08 13:01:56.000000000","tz":120},"subject":"target/arm_tpiu_swo: Handle errors in pre/post-enable events","message":"target/arm_tpiu_swo: Handle errors in pre/post-enable events\n\nCurrently, errors in pre/post-enable events are ignored and capturing is\nalways started, even if necessary device configuration fails. This\nbehaviour is confusing to users. Also, the TPIU must be disabled before\nre-configuration is possible.\n\nStart capturing and enable TPIU only if no errors in pre/post-enable\nevents occurred.\n\nChange-Id: I422033e36ca006e38aa4504d491b7947def1237a\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"be1aebd8183c5b6b3bbecfc065a84b7e10bd8f8e":{"kind":"REWORK","_number":3,"created":"2024-05-26 09:54:01.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/8254/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/8254/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/3 \u0026\u0026 git checkout -b change-8254 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/8254/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/8254/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c831758ea4f0baf6e4d1b2ee69ae3c895922fee5","subject":"server/gdb: Use \u0027bool\u0027 data type where appropriate"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 10:58:18.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 09:54:01.000000000","tz":0},"subject":"target/arm_tpiu_swo: Handle errors in pre/post-enable events","message":"target/arm_tpiu_swo: Handle errors in pre/post-enable events\n\nCurrently, errors in pre/post-enable events are ignored and capturing is\nalways started, even if necessary device configuration fails. This\nbehaviour is confusing to users. Also, the TPIU must be disabled before\nre-configuration is possible.\n\nStart capturing and enable TPIU only if no errors in pre/post-enable\nevents occurred.\n\nChange-Id: I422033e36ca006e38aa4504d491b7947def1237a\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8254\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}