)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"change_message_id":"419564ee6c26e0afdf5fbc8c14f268319d95e900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a123880a_cde2ee71","updated":"2024-05-08 15:56:02.000000000","message":"One comment inline, otherwise LGTM.","commit_id":"d4c1cf203305d1a9a6862d309b1a908631fe1799"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"2253dcb89dc83afd866894b906ccf1d0f3d093e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8c64b461_34557c7c","updated":"2024-05-18 09:48:18.000000000","message":"Thanks, changed the variable name and added a short comment.","commit_id":"cbafbeb6c07f5a684c7e6aeef2103fb3108d53bc"}],"tcl/target/nrf52.cfg":[{"author":{"_account_id":1002192,"name":"frankplow","email":"post@frankplowman.com","username":"frankplow"},"change_message_id":"419564ee6c26e0afdf5fbc8c14f268319d95e900","unresolved":true,"context_lines":[{"line_number":140,"context_line":"\t\t\t\t4000000  3"},{"line_number":141,"context_line":"\t\t\t}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"\t\t\tset traceclk [$_chipname.tpiu cget -traceclk]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\t\t\tif { ![dict exists $trace_port_speeds $traceclk] } {"},{"line_number":146,"context_line":"\t\t\t\terror \"Trace clock speed is not supported\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"e0e32bf1_e782e0b4","line":143,"range":{"start_line":143,"start_character":3,"end_line":143,"end_character":48},"updated":"2024-05-08 15:56:02.000000000","message":"I don\u0027t have hardware on hand to test, does this definitely give you the trace port speed and not the trace clock speed (half the trace port speed)?  If so, may be worth changing the variable name to something else and add clarification - \"get traceclk\" returning a value different to what the product spec calls \"traceclk\" could be a source of confusion.","commit_id":"d4c1cf203305d1a9a6862d309b1a908631fe1799"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"2253dcb89dc83afd866894b906ccf1d0f3d093e0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"\t\t\t\t4000000  3"},{"line_number":141,"context_line":"\t\t\t}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"\t\t\tset traceclk [$_chipname.tpiu cget -traceclk]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"\t\t\tif { ![dict exists $trace_port_speeds $traceclk] } {"},{"line_number":146,"context_line":"\t\t\t\terror \"Trace clock speed is not supported\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"6f0b838b_368a3e4d","line":143,"range":{"start_line":143,"start_character":3,"end_line":143,"end_character":48},"in_reply_to":"e0e32bf1_e782e0b4","updated":"2024-05-18 09:48:18.000000000","message":"Done","commit_id":"d4c1cf203305d1a9a6862d309b1a908631fe1799"}]}