)]}'
{"id":"openocd~master~I3e5323f145a98d1ff9ea7d03f87ed96140f49a18","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2024-05-26 09:55:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3e5323f145a98d1ff9ea7d03f87ed96140f49a18","subject":"target/semihosting: Fix double free()","status":"MERGED","created":"2024-05-07 06:25:45.000000000","updated":"2024-05-26 09:55:45.000000000","submitted":"2024-05-26 09:55:45.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8257","meta_rev_id":"f116f152b3ae8fb3f750b0eb287930c53d11e103","_number":8257,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 09:55:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-26 09:55:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-07 07:27:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-08 15:43:15.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2024-05-11 12:18:22.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"e381e1a6552e3503e74c30b6e1e9f90f2e87cdd0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-07 06:25:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a5132b7c8aefcb5c1320949c9830935e97f64aba","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-07 07:27:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19538/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18698/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"2d9912fc0b72f48c56d4ee38fe70f314dd3fa9e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-08 07:06:24.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"14cbaea44ee40f023ed59651d66f4ab96c161577","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-08 07:07:39.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19541/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18701/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"ee51d81021864f88c52862a39650fa4e3ae57b06","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-08 13:02:10.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"ddc44335fd2b3494a0ff375ec09b031486854d5d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-08 14:27:28.000000000","message":"Patch Set 3: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/19548/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18708/ : FAILURE","accounts_in_message":[],"_revision_number":3},{"id":"e1f82ba958795e8dd67d7156cbf2634a0db236b2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-08 15:43:15.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"468ea2b03bb0ed10b0617afe99d81a6e071a8a9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2024-05-08 19:52:54.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"601b3a4e6ae7890a74659975efa25320832e12b7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-08 20:07:24.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19549/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18709/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"fbfbd76f2b36aa3bfc5f9bbf9567920564654d4d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-11 12:18:22.000000000","message":"Patch Set 4: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"7e6beaf635a1fd5fae1f499c025e66f24ae4813c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:55:42.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"f116f152b3ae8fb3f750b0eb287930c53d11e103","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:55:45.000000000","message":"Change has been successfully cherry-picked as bd89b91c697d9aea97abfcd3a3b8043a95216d6d","accounts_in_message":[],"_revision_number":5}],"current_revision":"bd89b91c697d9aea97abfcd3a3b8043a95216d6d","revisions":{"d948ba309f18790e3c257a0c527345fbf77a8f50":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-05-08 13:02:10.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/57/8257/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8257/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/3 \u0026\u0026 git checkout -b change-8257 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8257/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d4c1cf203305d1a9a6862d309b1a908631fe1799","subject":"tcl/target/nrf52: Configure trace port speed"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 08:24:32.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-08 13:01:56.000000000","tz":120},"subject":"target/semihosting: Fix double free()","message":"target/semihosting: Fix double free()\n\nDo not free the service in \u0027connection_closed_handler\u0027 because it is\nfree\u0027d by the server infrastructure.\n\nThis error was detected with valgrind:\n\n\u003d\u003d272468\u003d\u003d Invalid free() / delete / delete[] / realloc()\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x1F34C7: remove_service (server.c:374)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d  Address 0x5fff650 is 0 bytes inside a block of size 24 free\u0027d\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ECA42: semihosting_service_connection_closed_handler (semihosting_common.c:1807)\n\u003d\u003d272468\u003d\u003d    by 0x1F2E39: remove_connection.isra.0 (server.c:164)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_connections (server.c:350)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_service (server.c:364)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d  Block was alloc\u0027d at\n\u003d\u003d272468\u003d\u003d    at 0x484DA83: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ED326: handle_common_semihosting_redirect_command (semihosting_common.c:1931)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x400000002: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\nChange-Id: I3e5323f145a98d1ff9ea7d03f87ed96140f49a18\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"141800a52b35e3298d23cb1a9e39d802f23e5666":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-08 07:06:24.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/57/8257/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8257/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/2 \u0026\u0026 git checkout -b change-8257 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8257/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4d868e3d9894cead57b804b85fc25826f0c102f6","subject":"tcl/target/nrf52: Configure trace port speed"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 08:24:32.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-08 07:04:34.000000000","tz":120},"subject":"target/semihosting: Fix double free()","message":"target/semihosting: Fix double free()\n\nDo not free the service in \u0027connection_closed_handler\u0027 because it is\nfree\u0027d by the server infrastructure.\n\nThis error was detected with valgrind:\n\n\u003d\u003d272468\u003d\u003d Invalid free() / delete / delete[] / realloc()\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x1F34C7: remove_service (server.c:374)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d  Address 0x5fff650 is 0 bytes inside a block of size 24 free\u0027d\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ECA42: semihosting_service_connection_closed_handler (semihosting_common.c:1807)\n\u003d\u003d272468\u003d\u003d    by 0x1F2E39: remove_connection.isra.0 (server.c:164)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_connections (server.c:350)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_service (server.c:364)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d  Block was alloc\u0027d at\n\u003d\u003d272468\u003d\u003d    at 0x484DA83: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ED326: handle_common_semihosting_redirect_command (semihosting_common.c:1931)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x400000002: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\nChange-Id: I3e5323f145a98d1ff9ea7d03f87ed96140f49a18\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"1b0bcfde03e2ddf9bd1241efe7641ccf4ef0d231":{"kind":"REWORK","_number":1,"created":"2024-05-07 06:25:45.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/57/8257/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8257/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/1 \u0026\u0026 git checkout -b change-8257 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8257/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4d868e3d9894cead57b804b85fc25826f0c102f6","subject":"tcl/target/nrf52: Configure trace port speed"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 08:24:32.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-07 06:23:57.000000000","tz":120},"subject":"target/semihosting: Fix double free()","message":"target/semihosting: Fix double free()\n\nDo not free the service in \u0027connection_closed_handler\u0027 because it is\nfree\u0027d by the server infrastructure.\n\nThis error was detected with valgrind:\n\n\u003d\u003d272468\u003d\u003d Invalid free() / delete / delete[] / realloc()\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x1F34C7: remove_service (server.c:374)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d  Address 0x5fff650 is 0 bytes inside a block of size 24 free\u0027d\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ECA42: semihosting_service_connection_closed_handler (semihosting_common.c:1807)\n\u003d\u003d272468\u003d\u003d    by 0x1F2E39: remove_connection.isra.0 (server.c:164)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_connections (server.c:350)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_service (server.c:364)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d  Block was alloc\u0027d at\n\u003d\u003d272468\u003d\u003d    at 0x484DA83: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ED326: handle_common_semihosting_redirect_command (semihosting_common.c:1931)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x400000002: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d\n\nChange-Id: I3e5323f145a98d1ff9ea7d03f87ed96140f49a18\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"bd89b91c697d9aea97abfcd3a3b8043a95216d6d":{"kind":"REWORK","_number":5,"created":"2024-05-26 09:55:45.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/57/8257/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8257/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/5 \u0026\u0026 git checkout -b change-8257 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8257/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"edb14a02e9b698d015696a959ca81f821d49d4e3","subject":"tcl/target/nrf52: Configure trace port speed"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 08:24:32.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 09:55:45.000000000","tz":0},"subject":"target/semihosting: Fix double free()","message":"target/semihosting: Fix double free()\n\nDo not free the service in \u0027connection_closed_handler\u0027 because it is\nfree\u0027d by the server infrastructure.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nThis error was detected with valgrind:\n\n\u003d\u003d272468\u003d\u003d Invalid free() / delete / delete[] / realloc()\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x1F34C7: remove_service (server.c:374)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d  Address 0x5fff650 is 0 bytes inside a block of size 24 free\u0027d\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ECA42: semihosting_service_connection_closed_handler (semihosting_common.c:1807)\n\u003d\u003d272468\u003d\u003d    by 0x1F2E39: remove_connection.isra.0 (server.c:164)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_connections (server.c:350)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_service (server.c:364)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d  Block was alloc\u0027d at\n\u003d\u003d272468\u003d\u003d    at 0x484DA83: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ED326: handle_common_semihosting_redirect_command (semihosting_common.c:1931)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x400000002: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d\n\nChange-Id: I3e5323f145a98d1ff9ea7d03f87ed96140f49a18\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8257\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8ee5f4f669281fd2c058f0cff11c4774645d9bb5":{"kind":"REWORK","_number":4,"created":"2024-05-08 19:52:54.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/57/8257/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/57/8257/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/4 \u0026\u0026 git checkout -b change-8257 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/57/8257/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/57/8257/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d4c1cf203305d1a9a6862d309b1a908631fe1799","subject":"tcl/target/nrf52: Configure trace port speed"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-01 08:24:32.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2024-05-08 19:52:09.000000000","tz":120},"subject":"target/semihosting: Fix double free()","message":"target/semihosting: Fix double free()\n\nDo not free the service in \u0027connection_closed_handler\u0027 because it is\nfree\u0027d by the server infrastructure.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nThis error was detected with valgrind:\n\n\u003d\u003d272468\u003d\u003d Invalid free() / delete / delete[] / realloc()\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x1F34C7: remove_service (server.c:374)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d  Address 0x5fff650 is 0 bytes inside a block of size 24 free\u0027d\n\u003d\u003d272468\u003d\u003d    at 0x484B27F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ECA42: semihosting_service_connection_closed_handler (semihosting_common.c:1807)\n\u003d\u003d272468\u003d\u003d    by 0x1F2E39: remove_connection.isra.0 (server.c:164)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_connections (server.c:350)\n\u003d\u003d272468\u003d\u003d    by 0x1F349E: remove_service (server.c:364)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: semihosting_tcp_close_cnx (semihosting_common.c:1819)\n\u003d\u003d272468\u003d\u003d    by 0x2ED3D5: handle_common_semihosting_redirect_command (semihosting_common.c:1926)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x300000001: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d  Block was alloc\u0027d at\n\u003d\u003d272468\u003d\u003d    at 0x484DA83: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)\n\u003d\u003d272468\u003d\u003d    by 0x2ED326: handle_common_semihosting_redirect_command (semihosting_common.c:1931)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: exec_command (command.c:520)\n\u003d\u003d272468\u003d\u003d    by 0x1FC703: jim_command_dispatch (command.c:931)\n\u003d\u003d272468\u003d\u003d    by 0x36980F: JimInvokeCommand (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x1FFFFFFFFF: ???\n\u003d\u003d272468\u003d\u003d    by 0x53ED09F: ???\n\u003d\u003d272468\u003d\u003d    by 0x400000002: ???\n\u003d\u003d272468\u003d\u003d    by 0x1FFEFFF7FF: ???\n\u003d\u003d272468\u003d\u003d    by 0x3D3984: ??? (in /home/marc/openocd/build/src/openocd)\n\u003d\u003d272468\u003d\u003d    by 0x2: ???\n\u003d\u003d272468\u003d\u003d\n\nChange-Id: I3e5323f145a98d1ff9ea7d03f87ed96140f49a18\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}