)]}'
{"id":"openocd~master~I3c0832d4201578b116c5214203f95b6153dad30e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002269":{"account":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"last_update":"2024-05-26 09:56:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3c0832d4201578b116c5214203f95b6153dad30e","subject":"Fix build with clang even if it sets __GNUC__ to \u003e\u003d 4.4","status":"MERGED","created":"2024-05-09 13:40:08.000000000","updated":"2024-05-26 09:56:50.000000000","submitted":"2024-05-26 09:56:50.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8258","meta_rev_id":"fd26a870091fe037b5950a94026469ce0faccae2","_number":8258,"owner":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 09:56:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-26 09:56:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-09 14:01:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-10 12:48:13.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"958f5d5a56648d68cb6db8dda99c2d79a32f2342","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"real_author":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"date":"2024-05-09 13:40:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1b8e7c4f2e8ef1078fe955941086ba6b08931c53","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-09 14:01:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19550/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18710/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"323cad13c56eed3f84db6ba073fd191624cb0ad5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-10 12:48:13.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"47e99937a3972c6e1741de131114844d0922f067","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:56:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fd26a870091fe037b5950a94026469ce0faccae2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:56:50.000000000","message":"Change has been successfully cherry-picked as ccc5c1642b32ab79d5ab315e4b308e53392a77c4","accounts_in_message":[],"_revision_number":2}],"current_revision":"ccc5c1642b32ab79d5ab315e4b308e53392a77c4","revisions":{"90d29e22ea3f9909ed172621ab93c2bfd0620a1e":{"kind":"REWORK","_number":1,"created":"2024-05-09 13:40:08.000000000","uploader":{"_account_id":1002269,"name":"Bernhard Rosenkränzer","display_name":"Bernhard \"bero\" Rosenkränzer","email":"bero@baylibre.com","username":"bero","status":"BayLibre"},"ref":"refs/changes/58/8258/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/8258/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/1 \u0026\u0026 git checkout -b change-8258 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/8258/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc9ca5f4a82ccbbdbe07108a83f7979b53e89889","subject":"ipdbg: fix double free of virtual-ir data"}],"author":{"name":"Bernhard Rosenkränzer","email":"bero@baylibre.com","date":"2024-05-09 13:30:13.000000000","tz":120},"committer":{"name":"Bernhard Rosenkränzer","email":"bero@baylibre.com","date":"2024-05-09 13:39:57.000000000","tz":120},"subject":"Fix build with clang even if it sets __GNUC__ to \u003e\u003d 4.4","message":"Fix build with clang even if it sets __GNUC__ to \u003e\u003d 4.4\n\nclang doesn\u0027t support the gnu_printf attribute that OpenOCD uses if\n__GNUC__ and __GNUC_MINOR__ indicates gcc \u003e\u003d 4.4.\n\nMost clang builds set __GNUC__/__GNUC_MINOR__ to 4.2 for historical\nreasons, so they don\u0027t trigger this condition; however, some builds set\nit to something much higher to work around code using __GNUC__ to\ndetermine if a feature that does exist in clang (but not gcc 4.2) is\navailable, causing OpenOCD to use attribute gnu_printf.\n\nThe problem can be reproduced without a special clang build by adding\n-fgnuc-version\u003d14.1 to CFLAGS.\n\nChange-Id: I3c0832d4201578b116c5214203f95b6153dad30e\nSigned-off-by: Bernhard Rosenkränzer \u003cbero@baylibre.com\u003e\n"}},"ccc5c1642b32ab79d5ab315e4b308e53392a77c4":{"kind":"REWORK","_number":2,"created":"2024-05-26 09:56:50.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/58/8258/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/8258/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/2 \u0026\u0026 git checkout -b change-8258 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/8258/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/8258/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bd89b91c697d9aea97abfcd3a3b8043a95216d6d","subject":"target/semihosting: Fix double free()"}],"author":{"name":"Bernhard Rosenkränzer","email":"bero@baylibre.com","date":"2024-05-09 13:30:13.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 09:56:50.000000000","tz":0},"subject":"Fix build with clang even if it sets __GNUC__ to \u003e\u003d 4.4","message":"Fix build with clang even if it sets __GNUC__ to \u003e\u003d 4.4\n\nclang doesn\u0027t support the gnu_printf attribute that OpenOCD uses if\n__GNUC__ and __GNUC_MINOR__ indicates gcc \u003e\u003d 4.4.\n\nMost clang builds set __GNUC__/__GNUC_MINOR__ to 4.2 for historical\nreasons, so they don\u0027t trigger this condition; however, some builds set\nit to something much higher to work around code using __GNUC__ to\ndetermine if a feature that does exist in clang (but not gcc 4.2) is\navailable, causing OpenOCD to use attribute gnu_printf.\n\nThe problem can be reproduced without a special clang build by adding\n-fgnuc-version\u003d14.1 to CFLAGS.\n\nChange-Id: I3c0832d4201578b116c5214203f95b6153dad30e\nSigned-off-by: Bernhard Rosenkränzer \u003cbero@baylibre.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8258\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}