)]}'
{"id":"openocd~master~I86c0e0bbad51db93500c0efa27b7d6f1a67a02c2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-26 09:57:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I86c0e0bbad51db93500c0efa27b7d6f1a67a02c2","subject":"openocd: drop include of target_type.h","status":"MERGED","created":"2024-05-12 10:29:02.000000000","updated":"2024-05-26 09:57:51.000000000","submitted":"2024-05-26 09:57:51.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8260","meta_rev_id":"28953ede1ea1fe522e38da1e6e5357395b3c4fd5","_number":8260,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 09:57:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 09:57:51.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-26 09:57:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-12 10:45:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-13 03:02:03.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"2407ff4a05f733f63784a880b04c4a5035de97e8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-12 10:29:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"18c0589597913faf01032592b88d059e041e6356","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-12 10:45:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19552/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18712/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b46b2daa73d62c960b956d516befc4d5560aa618","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-12 13:31:34.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"466a1fea95b392967a05bbc1352e43438d57f8a8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-05-13 03:02:03.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"28953ede1ea1fe522e38da1e6e5357395b3c4fd5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-26 09:57:51.000000000","message":"Change has been successfully cherry-picked as fbea7d5d38d0dcbdd71cb574da9bd12c78b568cf","accounts_in_message":[],"_revision_number":2}],"current_revision":"fbea7d5d38d0dcbdd71cb574da9bd12c78b568cf","revisions":{"684d5bc4d6c156c6fdd95bbd8a6b75d2ac4f3fe6":{"kind":"REWORK","_number":1,"created":"2024-05-12 10:29:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/60/8260/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8260/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/1 \u0026\u0026 git checkout -b change-8260 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8260/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-08 23:29:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-12 10:20:55.000000000","tz":120},"subject":"openocd: drop include of target_type.h","message":"openocd: drop include of target_type.h\n\nFew files include target_type.h even if it is not needed.\nDrop the include.\n\nOther files access directly to target type\u0027s name instead of using\nthe proper API target_type_name().\nUse the API and drop the include.\n\nChange-Id: I86c0e0bbad51db93500c0efa27b7d6f1a67a02c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"fbea7d5d38d0dcbdd71cb574da9bd12c78b568cf":{"kind":"REWORK","_number":2,"created":"2024-05-26 09:57:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/60/8260/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/60/8260/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/2 \u0026\u0026 git checkout -b change-8260 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/60/8260/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/60/8260/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ccc5c1642b32ab79d5ab315e4b308e53392a77c4","subject":"Fix build with clang even if it sets __GNUC__ to \u003e\u003d 4.4"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-04-08 23:29:34.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-26 09:57:51.000000000","tz":0},"subject":"openocd: drop include of target_type.h","message":"openocd: drop include of target_type.h\n\nFew files include target_type.h even if it is not needed.\nDrop the include.\n\nOther files access directly to target type\u0027s name instead of using\nthe proper API target_type_name().\nUse the API and drop the include.\n\nChange-Id: I86c0e0bbad51db93500c0efa27b7d6f1a67a02c2\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8260\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}