)]}'
{"id":"openocd~master~Ie4d98063006d70d9e2bcfc00bc930133caf33515","project":"openocd","branch":"master","hashtags":[],"change_id":"Ie4d98063006d70d9e2bcfc00bc930133caf33515","subject":"target: aarch64: align armv8_read_reg() and armv8_read_reg32()","status":"MERGED","created":"2024-05-14 12:52:25.000000000","updated":"2024-06-23 09:28:08.000000000","submitted":"2024-06-23 09:28:08.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8266","meta_rev_id":"9b432177dd9b9cada1a8247a6c6208825c12b0df","_number":8266,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:28:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-23 09:28:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-14 13:29:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7bd100affc45ce52386b007afa4b044368eeccb2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-14 12:52:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82fe741ca80112f1e25d6ef50664d7489ec9a956","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-14 13:29:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19560/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18719/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1a5b0ad47d79b73a92b647196478861c80e7bbea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:41:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9b432177dd9b9cada1a8247a6c6208825c12b0df","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:28:08.000000000","message":"Change has been successfully cherry-picked as 91043cecee396209bd4d616fe6e78d835bebd978","accounts_in_message":[],"_revision_number":2}],"current_revision":"91043cecee396209bd4d616fe6e78d835bebd978","revisions":{"91043cecee396209bd4d616fe6e78d835bebd978":{"kind":"REWORK","_number":2,"created":"2024-06-23 09:28:08.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/8266/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8266/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/2 \u0026\u0026 git checkout -b change-8266 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8266/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c5358c84ad0d3e7497498e0457cec7785f72910a","subject":"target: Do not use LOG_USER() for error messages"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-13 13:40:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-23 09:28:08.000000000","tz":0},"subject":"target: aarch64: align armv8_read_reg() and armv8_read_reg32()","message":"target: aarch64: align armv8_read_reg() and armv8_read_reg32()\n\nThese functions are today always called with non-NULL parameter\nregval, so the actual check is not needed.\nAnyway, for any future code change, check the parameter at the\nentry of the functions and return error if it is not valid.\nSimplify the check to assign the result value and align the code\nof the two functions.\n\nChange-Id: Ie4d98063006d70d9e2bcfc00bc930133caf33515\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8266\nTested-by: jenkins\n"}},"eb3ba1e3e67f134df1401f19246cd5e2526df53b":{"kind":"REWORK","_number":1,"created":"2024-05-14 12:52:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/66/8266/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/66/8266/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/1 \u0026\u0026 git checkout -b change-8266 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/66/8266/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/66/8266/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-13 13:40:15.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 12:51:08.000000000","tz":120},"subject":"target: aarch64: align armv8_read_reg() and armv8_read_reg32()","message":"target: aarch64: align armv8_read_reg() and armv8_read_reg32()\n\nThese functions are today always called with non-NULL parameter\nregval, so the actual check is not needed.\nAnyway, for any future code change, check the parameter at the\nentry of the functions and return error if it is not valid.\nSimplify the check to assign the result value and align the code\nof the two functions.\n\nChange-Id: Ie4d98063006d70d9e2bcfc00bc930133caf33515\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}