)]}'
{"id":"openocd~master~Idf02b42a7339df83260c1e44ceabbb05fbf392b9","project":"openocd","branch":"master","hashtags":[],"change_id":"Idf02b42a7339df83260c1e44ceabbb05fbf392b9","subject":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3","status":"MERGED","created":"2024-05-14 12:52:25.000000000","updated":"2024-06-23 09:29:04.000000000","submitted":"2024-06-23 09:29:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8271","meta_rev_id":"f0e21c1ace3d3fdaebf47209fd65b091efbb3096","_number":8271,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:29:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-23 09:29:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-14 14:27:05.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9d3b8334351be54ad179da05badbad10f8fb36fa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-14 12:52:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3f2a09d9eee95f068fa73ca359087517707967c2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-14 14:27:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19563/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18722/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"32ae25d1523490314826535e9476b850586fa24e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:41:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f0e21c1ace3d3fdaebf47209fd65b091efbb3096","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:29:04.000000000","message":"Change has been successfully cherry-picked as 190176a6bc947fd2516b959217084e531374b9bf","accounts_in_message":[],"_revision_number":2}],"current_revision":"190176a6bc947fd2516b959217084e531374b9bf","revisions":{"71a390a195f6cbf742e79c2afd6c797a39fc23b8":{"kind":"REWORK","_number":1,"created":"2024-05-14 12:52:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/8271/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/8271/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/1 \u0026\u0026 git checkout -b change-8271 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/8271/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f6231e3533dc526fb8d9e88a579edeb48ad08010","subject":"target: aarch64: access reg SPSR_EL3 only in EL3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 09:03:45.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 12:51:14.000000000","tz":120},"subject":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3","message":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3\n\nThe register ELR_EL2 is accessible and it\u0027s content is relevant\nonly when the target is in EL2 or EL3.\nVirtualization SW in EL1 can also access it, but this either\ntriggers a trap to EL2 or returns ELR_EL1. Debugger should not mix\nthe real ELR_EL2 with the virtual register.\n\nWithout this patch, an error:\n\tError: Opcode 0xd53c4020, DSCR.ERR\u003d1, DSCR.EL\u003d1\nis triggered by GDB register window or through GDB command\n\tx/p $ELR_EL2\nor through OpenOCD command\n\treg ELR_EL2\n\nDetect the EL and return error if the register cannot be accessed.\n\nChange-Id: Idf02b42a7339df83260c1e44ceabbb05fbf392b9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"190176a6bc947fd2516b959217084e531374b9bf":{"kind":"REWORK","_number":2,"created":"2024-06-23 09:29:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/8271/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/8271/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/2 \u0026\u0026 git checkout -b change-8271 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/8271/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/8271/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"405e78771b7f2a09298b675e7fbd05803672416c","subject":"target: aarch64: access reg SPSR_EL3 only in EL3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 09:03:45.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-23 09:29:04.000000000","tz":0},"subject":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3","message":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3\n\nThe register ELR_EL2 is accessible and it\u0027s content is relevant\nonly when the target is in EL2 or EL3.\nVirtualization SW in EL1 can also access it, but this either\ntriggers a trap to EL2 or returns ELR_EL1. Debugger should not mix\nthe real ELR_EL2 with the virtual register.\n\nWithout this patch, an error:\n\tError: Opcode 0xd53c4020, DSCR.ERR\u003d1, DSCR.EL\u003d1\nis triggered by GDB register window or through GDB command\n\tx/p $ELR_EL2\nor through OpenOCD command\n\treg ELR_EL2\n\nDetect the EL and return error if the register cannot be accessed.\n\nChange-Id: Idf02b42a7339df83260c1e44ceabbb05fbf392b9\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8271\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}