)]}'
{"id":"openocd~master~Icb32b44886d50907f29b068ce61e4be8bed10208","project":"openocd","branch":"master","hashtags":[],"change_id":"Icb32b44886d50907f29b068ce61e4be8bed10208","subject":"target: aarch64: access reg ESR_EL2 only in EL2 and EL3","status":"MERGED","created":"2024-05-14 12:52:25.000000000","updated":"2024-06-23 09:29:16.000000000","submitted":"2024-06-23 09:29:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8272","meta_rev_id":"c45f5c6bacf711b8437668200587ec7dee26ca36","_number":8272,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-23 09:29:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-23 09:29:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-14 14:41:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a45c5d8738769b33e92ad4b3066ada4ebc1ecff1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-14 12:52:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9234e441218d00f24993cc186da0b9298de00343","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-14 14:41:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19565/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18723/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"68a93e9a06d4a8f6fd108a3684b9709a640348b8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:41:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c45f5c6bacf711b8437668200587ec7dee26ca36","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-23 09:29:16.000000000","message":"Change has been successfully cherry-picked as 766a84b79892c1321f3f86d3f1b301519269b4f5","accounts_in_message":[],"_revision_number":2}],"current_revision":"766a84b79892c1321f3f86d3f1b301519269b4f5","revisions":{"066f9daf47cb420cb91e6b88353875a11213fca8":{"kind":"REWORK","_number":1,"created":"2024-05-14 12:52:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8272/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8272/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/1 \u0026\u0026 git checkout -b change-8272 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8272/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"71a390a195f6cbf742e79c2afd6c797a39fc23b8","subject":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 10:07:58.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 12:51:14.000000000","tz":120},"subject":"target: aarch64: access reg ESR_EL2 only in EL2 and EL3","message":"target: aarch64: access reg ESR_EL2 only in EL2 and EL3\n\nThe register ESR_EL2 is accessible and it\u0027s content is relevant\nonly when the target is in EL2 or EL3.\nVirtualization SW in EL1 can also access it, but this either\ntriggers a trap to EL2 or returns ESR_EL1. Debugger should not mix\nthe real ESR_EL2 with the virtual register.\nPlus, the register is 64 bits wide.\n\nWithout this patch, an error:\n\tError: Opcode 0xd53c5200, DSCR.ERR\u003d1, DSCR.EL\u003d1\nis triggered by GDB register window or through GDB command\n        x/p $ESR_EL2\nor through OpenOCD command\n        reg ESR_EL2\n\nDetect the EL and return error if the register cannot be accessed.\nHandle the register as 64 bits.\n\nChange-Id: Icb32b44886d50907f29b068ce61e4be8bed10208\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"766a84b79892c1321f3f86d3f1b301519269b4f5":{"kind":"REWORK","_number":2,"created":"2024-06-23 09:29:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/72/8272/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/72/8272/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/2 \u0026\u0026 git checkout -b change-8272 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/72/8272/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/72/8272/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"190176a6bc947fd2516b959217084e531374b9bf","subject":"target: aarch64: access reg ELR_EL2 only in EL2 and EL3"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-05-14 10:07:58.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-23 09:29:16.000000000","tz":0},"subject":"target: aarch64: access reg ESR_EL2 only in EL2 and EL3","message":"target: aarch64: access reg ESR_EL2 only in EL2 and EL3\n\nThe register ESR_EL2 is accessible and it\u0027s content is relevant\nonly when the target is in EL2 or EL3.\nVirtualization SW in EL1 can also access it, but this either\ntriggers a trap to EL2 or returns ESR_EL1. Debugger should not mix\nthe real ESR_EL2 with the virtual register.\nPlus, the register is 64 bits wide.\n\nWithout this patch, an error:\n\tError: Opcode 0xd53c5200, DSCR.ERR\u003d1, DSCR.EL\u003d1\nis triggered by GDB register window or through GDB command\n        x/p $ESR_EL2\nor through OpenOCD command\n        reg ESR_EL2\n\nDetect the EL and return error if the register cannot be accessed.\nHandle the register as 64 bits.\n\nChange-Id: Icb32b44886d50907f29b068ce61e4be8bed10208\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8272\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}