)]}'
{"id":"openocd~master~I38276dd1af011ce5781b0264b7cbb08c32a1a2ad","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Øyvind Harboe","email":"oyvind.harboe@zylin.com","username":"oyvind"},"last_update":"2024-08-25 12:42:44.000000000","reason":"Change was submitted"},"1002273":{"account":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"last_update":"2024-08-25 12:42:44.000000000","reason":"Change was submitted"},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2024-06-28 22:06:58.000000000","reason":"\u003cGERRIT_ACCOUNT_1000859\u003e replied on the change","reason_account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}}},"hashtags":[],"change_id":"I38276dd1af011ce5781b0264b7cbb08c32a1a2ad","subject":"target: fix profiler output on Windows","status":"MERGED","created":"2024-05-15 17:30:58.000000000","updated":"2024-08-25 12:42:44.000000000","submitted":"2024-08-25 12:42:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8278","meta_rev_id":"c6e4d26bf56d238a21776e8b9daaf83cdb69bc90","_number":8278,"owner":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:42:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-08-25 12:42:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-08-25 12:42:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Øyvind Harboe","email":"oyvind.harboe@zylin.com","username":"oyvind"}],"reviewers":{"CC":[{"_account_id":1002278,"name":"bryghtlabs-richard","display_name":"Richard Allen","username":"bryghtlabs-richard","status":"Firmware at BryghtLabs. Also rsaxvc at home."}],"REVIEWER":[{"_account_id":1000003,"name":"Øyvind Harboe","email":"oyvind.harboe@zylin.com","username":"oyvind"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-15 17:56:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-22 17:53:25.000000000","updated_by":{"_account_id":1002278,"name":"bryghtlabs-richard","display_name":"Richard Allen","username":"bryghtlabs-richard","status":"Firmware at BryghtLabs. Also rsaxvc at home."},"reviewer":{"_account_id":1002278,"name":"bryghtlabs-richard","display_name":"Richard Allen","username":"bryghtlabs-richard","status":"Firmware at BryghtLabs. Also rsaxvc at home."},"state":"CC"},{"updated":"2024-05-22 17:53:25.000000000","updated_by":{"_account_id":1002278,"name":"bryghtlabs-richard","display_name":"Richard Allen","username":"bryghtlabs-richard","status":"Firmware at BryghtLabs. Also rsaxvc at home."},"reviewer":{"_account_id":1000003,"name":"Øyvind Harboe","email":"oyvind.harboe@zylin.com","username":"oyvind"},"state":"REVIEWER"},{"updated":"2024-06-28 16:40:55.000000000","updated_by":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2024-08-03 17:25:39.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"f39e03d7e1e600b8254d3a9db31b30cf8464f227","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"real_author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"date":"2024-05-15 17:30:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"83614943b14a1dad6fa5a478889d6896251bfbc8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-15 17:56:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19573/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18733/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"71a0a5f4e544df5f7914829c2306ad155da434dc","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-06-28 22:06:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b5a68233185c38da243230e597ee8328feb145b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"real_author":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"date":"2024-06-29 02:51:17.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"43990961cb1210734fec5bfa1a2be98ae7ba1480","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-06-29 03:06:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19751/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18907/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"cd3ed1bdf7b8067af27cd95c837d1abc85b01622","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2024-06-29 22:08:27.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"06b6371f15b26665c1a377676bfa4e8aca00ce83","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-03 17:25:39.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c6e4d26bf56d238a21776e8b9daaf83cdb69bc90","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-08-25 12:42:44.000000000","message":"Change has been successfully cherry-picked as 5cb184a732c998eed1d4e1a54c682d204f6f34d2","accounts_in_message":[],"_revision_number":3}],"current_revision":"5cb184a732c998eed1d4e1a54c682d204f6f34d2","revisions":{"82ec63084078f9151b7f6bf2b78af177554d0cd4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-06-29 02:51:17.000000000","uploader":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"ref":"refs/changes/78/8278/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/8278/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/2 \u0026\u0026 git checkout -b change-8278 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/8278/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Richard Allen","email":"rsaxvc@gmail.com","date":"2024-05-15 17:29:05.000000000","tz":-300},"committer":{"name":"Richard Allen","email":"rsaxvc@gmail.com","date":"2024-06-29 02:51:17.000000000","tz":0},"subject":"target: fix profiler output on Windows","message":"target: fix profiler output on Windows\n\nOpen output file in binary mode to disable EOL\nconversion on Windows (and sometimes cygwin depending\non installation settings and path).\n\nChange-Id: I38276dd1af011ce5781b0264b7cbb08c32a1a2ad\nSigned-off-by: Richard Allen \u003crsaxvc@gmail.com\u003e\n"},"description":"Edit commit message"},"5cb184a732c998eed1d4e1a54c682d204f6f34d2":{"kind":"REWORK","_number":3,"created":"2024-08-25 12:42:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/78/8278/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/8278/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/3 \u0026\u0026 git checkout -b change-8278 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/8278/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff22f78d4605d7037a70fa36232986c7396f2946","subject":"doc: document that breakpoints are disabled on step/resume"}],"author":{"name":"Richard Allen","email":"rsaxvc@gmail.com","date":"2024-05-15 17:29:05.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-08-25 12:42:44.000000000","tz":0},"subject":"target: fix profiler output on Windows","message":"target: fix profiler output on Windows\n\nOpen output file in binary mode to disable EOL\nconversion on Windows (and sometimes cygwin depending\non installation settings and path).\n\nChange-Id: I38276dd1af011ce5781b0264b7cbb08c32a1a2ad\nSigned-off-by: Richard Allen \u003crsaxvc@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8278\nReviewed-by: Karl Palsson \u003ckarlp@tweak.au\u003e\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0dabb131cb3d5dcd3b375a7b35f484e1def99704":{"kind":"REWORK","_number":1,"created":"2024-05-15 17:30:58.000000000","uploader":{"_account_id":1002273,"name":"Richard Allen","email":"rsaxvc@gmail.com","username":"rsaxvc","status":"@BryghtLabs, @rsaxvc.net"},"ref":"refs/changes/78/8278/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/8278/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/1 \u0026\u0026 git checkout -b change-8278 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/8278/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/8278/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Richard Allen","email":"rsaxvc@gmail.com","date":"2024-05-15 17:29:05.000000000","tz":-300},"committer":{"name":"Richard Allen","email":"rsaxvc@gmail.com","date":"2024-05-15 17:30:49.000000000","tz":-300},"subject":"target: open profiler output in binary mode","message":"target: open profiler output in binary mode\n\nChange-Id: I38276dd1af011ce5781b0264b7cbb08c32a1a2ad\nSigned-off-by: Richard Allen \u003crsaxvc@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}