)]}'
{"id":"openocd~master~I510d46222f4fb02d6ef73121b231d5b2df77e5c0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002274":{"account":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"last_update":"2024-06-08 08:42:34.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-24 12:54:11.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I510d46222f4fb02d6ef73121b231d5b2df77e5c0","subject":"tcl/memory: fix syntax errors","status":"MERGED","created":"2024-05-16 02:43:41.000000000","updated":"2024-06-08 08:42:34.000000000","submitted":"2024-06-08 08:42:34.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8279","meta_rev_id":"5974d409fc504fbec05de9dd094c64d64f0b74b8","_number":8279,"owner":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:42:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-08 08:42:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-16 02:58:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-21 08:08:36.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ec3256d635667eec0dae728224e2fb24b71e5c1a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-16 02:43:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b7da9fe2dd685c995663ab25ce83bb5190ef6233","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-16 02:58:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19576/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18736/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5bf3bdf7b1b698852454a66043c57099fe15ff45","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-21 08:08:36.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73a92c81305a289b9370e3404400b6712bcd5b7e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-22 00:28:10.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5b749d4cfa02937d3aace210a5c6b2cbe225829e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-22 00:54:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19603/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18761/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"090f231fa73a8656c4c709a13929aa8bc931a585","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-24 12:54:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d73af86f6c2efb2a68258fd437f814891b639ebd","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-25 16:14:23.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"eb6df7fbc25461c1ce30e04734af2ba3053e894e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-25 16:26:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5974d409fc504fbec05de9dd094c64d64f0b74b8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:42:34.000000000","message":"Change has been successfully cherry-picked as eecba412cd8a6d515c925d87fe53e79881305517","accounts_in_message":[],"_revision_number":3}],"current_revision":"eecba412cd8a6d515c925d87fe53e79881305517","revisions":{"6192020457feb7c5f94d6834ec4b10b5be85f2ff":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-22 00:28:10.000000000","uploader":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"ref":"refs/changes/79/8279/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/8279/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/2 \u0026\u0026 git checkout -b change-8279 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/8279/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:39:12.000000000","tz":-240},"committer":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-22 00:14:21.000000000","tz":-240},"subject":"tcl/memory: fix syntax errors","message":"tcl/memory: fix syntax errors\n\nUsing a command in an expression requires a bracketed command\nsubstitution.\n\nThese syntax errors were caught by tclint v0.2.5\n(https://github.com/nmoroze/tclint):\n\n```\ntclint tcl/memory.tcl | grep \"syntax error\"\n```\n\nChange-Id: I510d46222f4fb02d6ef73121b231d5b2df77e5c0\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\n"}},"eecba412cd8a6d515c925d87fe53e79881305517":{"kind":"REWORK","_number":3,"created":"2024-06-08 08:42:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/79/8279/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/8279/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/3 \u0026\u0026 git checkout -b change-8279 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/8279/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c7c4d4d48c63c1048414779f633641ea4e9657c8","subject":"contrib: Drop \u0027coresight-trace.txt\u0027"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:39:12.000000000","tz":-240},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-08 08:42:34.000000000","tz":0},"subject":"tcl/memory: fix syntax errors","message":"tcl/memory: fix syntax errors\n\nUsing a command in an expression requires a bracketed command\nsubstitution.\n\nThese syntax errors were caught by tclint v0.2.5\n(https://github.com/nmoroze/tclint):\n\n```\ntclint tcl/memory.tcl | grep \"syntax error\"\n```\n\nChange-Id: I510d46222f4fb02d6ef73121b231d5b2df77e5c0\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8279\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"b31e12fe32ed7dafb23491d97dcbaa6c97dc2ae7":{"kind":"REWORK","_number":1,"created":"2024-05-16 02:43:41.000000000","uploader":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"ref":"refs/changes/79/8279/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/8279/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/1 \u0026\u0026 git checkout -b change-8279 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/8279/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/8279/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2c8376b79d104a855bd3a559e59edf330309bcad","subject":"target/xtensa: avoid IHI for writes to non-executable memory"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:39:12.000000000","tz":-240},"committer":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:41:02.000000000","tz":-240},"subject":"tcl/memory: fix syntax errors","message":"tcl/memory: fix syntax errors\n\nUsing a command in an expression requires a bracketed command\nsubstitution.\n\nChange-Id: I510d46222f4fb02d6ef73121b231d5b2df77e5c0\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}