)]}'
{"id":"openocd~master~I511c54353c4853560adca6b4852d48df2aade283","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002274":{"account":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"last_update":"2024-06-08 08:43:30.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-05-24 12:54:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I511c54353c4853560adca6b4852d48df2aade283","subject":"tcl/target/c100helper: fix syntax errors","status":"MERGED","created":"2024-05-16 02:53:38.000000000","updated":"2024-06-08 08:43:30.000000000","submitted":"2024-06-08 08:43:30.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8280","meta_rev_id":"1680a700125fb3779f6ddbe9efaf58b2be2bc73e","_number":8280,"owner":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-08 08:43:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-08 08:43:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-16 03:14:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-21 08:15:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"a9749a30bd01082c1796f7347f240ee9869552ab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-16 02:53:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"41478f58dbb31c7c740881a5245f06e5831cc3ed","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-16 03:14:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19577/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18737/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ba5c00eeea94a12be93a48d65629e29dbeebef05","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-21 08:15:42.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"65d9812746ce658c14bba14328e8cc322e8b8012","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-21 09:10:37.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"24f2c795705630458b50754f3438fe4e9d6d9c1a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-22 00:28:10.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"069c3af1970da0423e199d57c1084999a1b4f03e","author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"real_author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"date":"2024-05-22 00:33:51.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"252d4110bf490a7e68d39d634e2ec18df5dcc6e8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2024-05-22 01:34:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/19602/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/18763/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4fb4fa83f98ea9b8c9f7e6ee3d65639d7a1cd837","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-05-24 12:54:45.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"4cfd119b8c420eab13ce2c54d32eb68ee374874d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:43:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1680a700125fb3779f6ddbe9efaf58b2be2bc73e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-06-08 08:43:30.000000000","message":"Change has been successfully cherry-picked as 223e3d8fe76d86f01111bbe37f83a19d719ac81a","accounts_in_message":[],"_revision_number":3}],"current_revision":"223e3d8fe76d86f01111bbe37f83a19d719ac81a","revisions":{"223e3d8fe76d86f01111bbe37f83a19d719ac81a":{"kind":"REWORK","_number":3,"created":"2024-06-08 08:43:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/80/8280/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/8280/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/3 \u0026\u0026 git checkout -b change-8280 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/8280/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eecba412cd8a6d515c925d87fe53e79881305517","subject":"tcl/memory: fix syntax errors"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:47:53.000000000","tz":-240},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-06-08 08:43:30.000000000","tz":0},"subject":"tcl/target/c100helper: fix syntax errors","message":"tcl/target/c100helper: fix syntax errors\n\nFixes: 64d89d5ee1a5 (\"tcl: [3/3] prepare for jimtcl 0.81 \u0027expr\u0027 syntax change\")\n\nThese syntax errors were caught by tclint v0.2.5\n(https://github.com/nmoroze/tclint):\n\n```\ntclint tcl/target/c100helper.tcl | grep \"syntax error\"\n```\n\nChange-Id: I511c54353c4853560adca6b4852d48df2aade283\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/8280\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"aa7e6a5d65f47803d468a2552dd8e92223c83ca1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-22 00:28:10.000000000","uploader":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"ref":"refs/changes/80/8280/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/8280/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/2 \u0026\u0026 git checkout -b change-8280 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/8280/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6192020457feb7c5f94d6834ec4b10b5be85f2ff","subject":"tcl/memory: fix syntax errors"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:47:53.000000000","tz":-240},"committer":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-22 00:18:36.000000000","tz":-240},"subject":"tcl/target/c100helper: fix syntax errors","message":"tcl/target/c100helper: fix syntax errors\n\nFixes: 64d89d5ee1a5 (\"tcl: [3/3] prepare for jimtcl 0.81 \u0027expr\u0027 syntax change\")\n\nThese syntax errors were caught by tclint v0.2.5\n(https://github.com/nmoroze/tclint):\n\n```\ntclint tcl/target/c100helper.tcl | grep \"syntax error\"\n```\n\nChange-Id: I511c54353c4853560adca6b4852d48df2aade283\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\n"}},"780289563c9772be2557cf42c634994677282a21":{"kind":"REWORK","_number":1,"created":"2024-05-16 02:53:38.000000000","uploader":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"ref":"refs/changes/80/8280/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/80/8280/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/1 \u0026\u0026 git checkout -b change-8280 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/80/8280/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/80/8280/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b31e12fe32ed7dafb23491d97dcbaa6c97dc2ae7","subject":"tcl/memory: fix syntax errors"}],"author":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:47:53.000000000","tz":-240},"committer":{"name":"Noah Moroze","email":"noahmoroze@gmail.com","date":"2024-05-16 02:47:53.000000000","tz":-240},"subject":"tcl/target/c100helper: fix syntax errors","message":"tcl/target/c100helper: fix syntax errors\n\nChange-Id: I511c54353c4853560adca6b4852d48df2aade283\nSigned-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}