)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"763d77e6a4054e2fa1836d0432eb16f42129862e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Noah Moroze \u003cnoahmoroze@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-15 22:53:24 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tcl/chip/st/spear: fix syntax errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2763d93095e3db7590644652f16b7b24939d6cae"},{"line_number":10,"context_line":"Signed-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"74df5ee0_2374ece6","line":7,"updated":"2024-05-21 09:04:54.000000000","message":"Please update the commit message with something like (please\nrephrase it as you prefer):\n```\ntcl/chip/st/spear: fix TCL syntax errors\n\nWhile the syntax error is not detected by current jimtcl, the\nTCL dodekalogue states that the string terminated at the second\ndouble quote character. Any additional text after the second\ndouble quote character is not part of the string.\n```","commit_id":"47a5429e71ef9e99c2a35bab1e74b4a0a422a2d5"},{"author":{"_account_id":1002274,"name":"Noah Moroze","email":"noahmoroze@gmail.com","username":"nmoroze"},"change_message_id":"f38d0d77b4791349cd2806be47b4f6d872afcab7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Noah Moroze \u003cnoahmoroze@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-15 22:53:24 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tcl/chip/st/spear: fix syntax errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2763d93095e3db7590644652f16b7b24939d6cae"},{"line_number":10,"context_line":"Signed-off-by: Noah Moroze \u003cnoahmoroze@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"739ab624_305bc4dc","line":7,"in_reply_to":"74df5ee0_2374ece6","updated":"2024-05-22 00:35:44.000000000","message":"Done","commit_id":"47a5429e71ef9e99c2a35bab1e74b4a0a422a2d5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"05cbc014dfa2fdb0c147b9958bfd5c4ed07e2d12","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dfc060b1_0f880b65","updated":"2024-05-18 03:03:36.000000000","message":"IMO jimtcl interprets this construct just fine as two concatenated strings, no syntax error:\n```\n\u003e set ddr_type xxx\nxxx\n\u003e error \"sp3xx_ddr_init: unrecognized DDR type \"$ddr_type\nsp3xx_ddr_init: unrecognized DDR type xxx\n\u003e error \"sp3xx_ddr_init: unrecognized DDR type $ddr_type\"\nsp3xx_ddr_init: unrecognized DDR type xxx\n\n\u003e script chip/st/spear/spear3xx_ddr.tcl\nddr_spr3xx_mt47h64m16_3_333_cl5_async\n\u003e sp3xx_ddr_init xxx\ntcl/chip/st/spear/spear3xx_ddr.tcl:24: Error: sp3xx_ddr_init: unrecognized DDR type xxx\nin procedure \u0027sp3xx_ddr_init\u0027\nat file \"tcl/chip/st/spear/spear3xx_ddr.tcl\", line 24\n\n\u003e sp3xx_ddr_init mt47h64m16_3_333_cl5_async 3\ntcl/chip/st/spear/spear3xx_ddr.tcl:13: Error: Only 1 or 2 DDR chips permitted. Wrong value 3\nin procedure \u0027sp3xx_ddr_init\u0027\nat file \"tcl/chip/st/spear/spear3xx_ddr.tcl\", line 13\n```\nAnyway the variable inside the string looks better.\nConsider rewording the commit message.","commit_id":"47a5429e71ef9e99c2a35bab1e74b4a0a422a2d5"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"763d77e6a4054e2fa1836d0432eb16f42129862e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"feba636a_d1996551","in_reply_to":"dfc060b1_0f880b65","updated":"2024-05-21 09:04:54.000000000","message":"Looks like an incorrect implementation of jimtcl:\n```\n#\u003e jimsh\nWelcome to Jim version 0.82\n. set x 123\n123\n. error \"hello\"$x\nhello123\n```\n\nthat does not work with \"standard\" (?) tcl 8.6.13:\n```\n#\u003e tclsh\n% set x 123\n123\n% error \"hello\"$x\nextra characters after close-quote\n```\n\nThe TCL dodekalogue ``http://www.tcl.tk/man/tcl/TclCmd/Tcl.htm#M8`` reports:\n```\n[4] Double quotes.\n    If the first character of a word is double-quote (“\"”) then the word is\n    terminated by the next double-quote character. If semi-colons, close\n    brackets, or white space characters (including newlines) appear between\n    the quotes then they are treated as ordinary characters and included in\n    the word. Command substitution, variable substitution, and backslash\n    substitution are performed on the characters between the quotes as\n    described below. The double-quotes are not retained as part of the word.\n```\n\nthat means the variable expansion outside the double quote should be considered not part of the string.","commit_id":"47a5429e71ef9e99c2a35bab1e74b4a0a422a2d5"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f625bd71884f6ebee1c70acb140eb5d597e7fd1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"da9202cd_1d517620","updated":"2024-05-22 05:00:54.000000000","message":"Thanks!","commit_id":"c482e8984b762fb72e76141f44de06d03cfda599"}]}